fix(shared): add optional chain to isInElectron env
#629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add optional chain to navigation.userAgent incase userAgent is undefined
✅ Deploy Preview for vue-devtools-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
webfansplz
changed the title
isInElectron env
webfansplz
approved these changes
Oct 10, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have set-up a laravel, inertia and vue project and integrated devtools-next but kept getting errors on running vite:
failed to load config from {project dir}/vite.config.js error when starting dev server: TypeError: Cannot read properties of undefined (reading 'toLowerCase')Solution
The first conditional in
isInElectronchecks if the navigator class exists, it does but it is empty - so theuserAgentis undefined. I've added an optional chain to the end of the userAgent to ensure it's existence.