Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kit): for better naming of index.vue components #628

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

niksy
Copy link
Contributor

@niksy niksy commented Oct 10, 2024

Similar to vuejs/devtools-v6#1994

Sometimes developers have components nested inside directories and follow classic Node approach of naming them /index.${extension}, in this case /index.vue. Devtools currently display every component as <Index> unless you specify name. This PR will check for those components and use parent directory as component name.

Copy link

netlify bot commented Oct 10, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 2e60f53
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/6707d9e857180a0008dada81

@reslear
Copy link
Contributor

reslear commented Oct 10, 2024

ideally, of course to find his name by meta router, or just the parent's folder
but of course that would require resources

@webfansplz webfansplz changed the title feat: Add support for better naming of index.vue components feat(kit): for better naming of index.vue components Oct 10, 2024
@webfansplz
Copy link
Member

Great! Thanks 🙏

@webfansplz webfansplz merged commit 58195fc into vuejs:main Oct 10, 2024
6 checks passed
Copy link

pkg-pr-new bot commented Oct 10, 2024

Open in Stackblitz

@vue/devtools-applet

pnpm add https://pkg.pr.new/@vue/devtools-applet@628

@vue/devtools-core

pnpm add https://pkg.pr.new/@vue/devtools-core@628

@vue/devtools

pnpm add https://pkg.pr.new/@vue/devtools@628

@vue/devtools-api

pnpm add https://pkg.pr.new/@vue/devtools-api@628

@vue/devtools-kit

pnpm add https://pkg.pr.new/@vue/devtools-kit@628

vite-plugin-vue-devtools

pnpm add https://pkg.pr.new/vite-plugin-vue-devtools@628

commit: 2e60f53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants