fix(kit): inspect error with top-level Proxy value
#701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-devtools-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
cc @webfansplz，would you please review this. thanks |
|
LGTM, due to this being an edge case, adding extra logic might add some performance overhead. Just showing an error in StateViewer is expected.
|
alexzhang1030
approved these changes
Nov 26, 2024
@vue/devtools-applet
@vue/devtools-core
@vue/devtools
@vue/devtools-api
@vue/devtools-kit
vite-plugin-vue-devtools
commit: |
webfansplz
changed the title
Proxy value
|
Why does the the top level proxy contain a foo function? @webfansplz |
User defined |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getSetupStateTypewill try to access the Proxy by some flag to judge whether the Proxy is a reactivity or not. If the getter fail, for example, the getter do function call, then the inspection would down.By wrapping
getSetupStateTypein try...catch block could avoid this situation, but will still get the wrong value.If we have a way to display the Proxy in the StateViewer properly would be impressive.