Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refine bg/text color for dark mode #686

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

alexzhang1030
Copy link
Member

@alexzhang1030 alexzhang1030 commented Nov 5, 2024

closes #685 #677

Before:
image

Now:

image

I just updated background/text color for dark mode to reduce eye strain, especially on darker pages.

I’d appreciate any feedback!

Ref article: https://uxplanet.org/alternatives-to-using-pure-black-000000-for-text-and-backgrounds-54ef0e733cdb

Copy link

netlify bot commented Nov 5, 2024

Deploy Preview for vue-devtools-docs canceled.

Name Link
🔨 Latest commit 70baa9b
🔍 Latest deploy log https://app.netlify.com/sites/vue-devtools-docs/deploys/673214211613400008fcd8eb

Copy link

pkg-pr-new bot commented Nov 5, 2024

Open in Stackblitz

@vue/devtools-applet

pnpm add https://pkg.pr.new/@vue/devtools-applet@686

@vue/devtools-core

pnpm add https://pkg.pr.new/@vue/devtools-core@686

@vue/devtools

pnpm add https://pkg.pr.new/@vue/devtools@686

@vue/devtools-api

pnpm add https://pkg.pr.new/@vue/devtools-api@686

@vue/devtools-kit

pnpm add https://pkg.pr.new/@vue/devtools-kit@686

vite-plugin-vue-devtools

pnpm add https://pkg.pr.new/vite-plugin-vue-devtools@686

commit: 70baa9b

@webfansplz
Copy link
Member

@alexzhang1030 Great work. The whole thing looks a lot better. Here are some personal views to discuss:

  1. The tree node element seems a little too bright, I prefer to display #fff directly in dark mode
image
  1. I prefer the background color in the original dark mode, if we want to improve the contrast, we may need to enhance the specific elements.
image image image

https://coolors.co/contrast-checker/c41a16-212427

@alexzhang1030
Copy link
Member Author

@alexzhang1030 Great work. The whole thing looks a lot better. Here are some personal views to discuss:

  1. The tree node element seems a little too bright, I prefer to display #fff directly in dark mode
image 2. I prefer the background color in the original dark mode, if we want to improve the contrast, we may need to enhance the specific elements.

image image image
coolors.co/contrast-checker/c41a16-212427

Thanks for that, Let me clarify:

  1. If the green is too bright, we can explore other colors; an all-white text color can be hard to read because < and > are the same color as the component name.
  2. According to an article I referred to, pure black (or colors close to #000) can cause eye strain, while a softer dark grey can be easier on the eyes. I will explore some colors to improve the red text color contrast.

@alexzhang1030
Copy link
Member Author

alexzhang1030 commented Nov 6, 2024

https://coolors.co/contrast-checker/ffb980-212427

image

this color looks good

@alexzhang1030
Copy link
Member Author

Revert bg changes due to some limitations, consider css vars in the future.

@webfansplz webfansplz merged commit 9e8ae0e into vuejs:main Nov 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refine color contrast for devtools dark mode
2 participants