feat: filter tree/states for custom inspectors #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vue-devtools-docs canceled.
|
@vue/devtools-applet
@vue/devtools-core
@vue/devtools
@vue/devtools-api
@vue/devtools-kit
vite-plugin-vue-devtools
commit: |
|
Great work. But when I tested it, I found that it caused the custom inspector state don't display as expected. |
|
curious about that, I did not update any core logic |
You can reproduce it in the basic playground's Vuex and Vue Query panel |
@webfansplz fixed, missed something... bad js 😅 |
webfansplz
changed the title
webfansplz
approved these changes
Oct 31, 2024
|
LGTM 🔥. Great work, bro. |
webfansplz
added a commit
that referenced
this pull request
Oct 31, 2024
This reverts commit dce7c1e.
alexzhang1030
added a commit
to alexzhang1030/vue-devtools-next
that referenced
this pull request
Oct 31, 2024
webfansplz
pushed a commit
that referenced
this pull request
Oct 31, 2024
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #657
Leave a Todo here, The pinia applet is very similar to the custom inspector applet, we should extract the common logic into a composable.