fix(extension): inject scripts into html document only, close #904

webfansplz · webfansplz · commit ccec14a6baba · 2025-06-26T21:08:36.000+08:00
diff --git a/packages/chrome-extension/src/detector.ts b/packages/chrome-extension/src/detector.ts
@@ -80,6 +80,6 @@ function detect(win: Window) {
   }, 100)
 }
 
-if (document instanceof Document) {
+if (document instanceof HTMLDocument) {
   detect(window)
 }
diff --git a/packages/chrome-extension/src/devtools-overlay.ts b/packages/chrome-extension/src/devtools-overlay.ts
@@ -1,16 +1,18 @@
-const body = document.getElementsByTagName('body')[0]
+if (document instanceof HTMLDocument) {
+  const body = document.getElementsByTagName('body')[0]
 
-// create detector script
-const detector = document.createElement('script')
-detector.src = chrome.runtime.getURL('dist/detector.js')
-detector.onload = () => {
-  detector.parentNode!.removeChild(detector)
-}
+  // create detector script
+  const detector = document.createElement('script')
+  detector.src = chrome.runtime.getURL('dist/detector.js')
+  detector.onload = () => {
+    detector.parentNode!.removeChild(detector)
+  }
 
-;(document.head || document.documentElement).appendChild(detector)
+  ;(document.head || document.documentElement).appendChild(detector)
 
-window.addEventListener('message', (event) => {
-  if (event.data.key === '__VUE_DEVTOOLS_VUE_DETECTED_EVENT__') {
-    chrome.runtime.sendMessage(event.data.data)
-  }
-}, false)
+  window.addEventListener('message', (event) => {
+    if (event.data.key === '__VUE_DEVTOOLS_VUE_DETECTED_EVENT__') {
+      chrome.runtime.sendMessage(event.data.data)
+    }
+  }, false)
+}
diff --git a/packages/firefox-extension/src/detector.ts b/packages/firefox-extension/src/detector.ts
@@ -80,6 +80,6 @@ function detect(win: Window) {
   }, 100)
 }
 
-if (document instanceof Document) {
+if (document instanceof HTMLDocument) {
   detect(window)
 }
diff --git a/packages/firefox-extension/src/devtools-overlay.ts b/packages/firefox-extension/src/devtools-overlay.ts
@@ -1,16 +1,18 @@
-const body = document.getElementsByTagName('body')[0]
+if (document instanceof HTMLDocument) {
+  const body = document.getElementsByTagName('body')[0]
 
-// create detector script
-const detector = document.createElement('script')
-detector.src = chrome.runtime.getURL('dist/detector.js')
-detector.onload = () => {
-  detector.parentNode!.removeChild(detector)
-}
+  // create detector script
+  const detector = document.createElement('script')
+  detector.src = chrome.runtime.getURL('dist/detector.js')
+  detector.onload = () => {
+    detector.parentNode!.removeChild(detector)
+  }
 
-;(document.head || document.documentElement).appendChild(detector)
+  ;(document.head || document.documentElement).appendChild(detector)
 
-window.addEventListener('message', (event) => {
-  if (event.data.key === '__VUE_DEVTOOLS_VUE_DETECTED_EVENT__') {
-    chrome.runtime.sendMessage(event.data.data)
-  }
-}, false)
+  window.addEventListener('message', (event) => {
+    if (event.data.key === '__VUE_DEVTOOLS_VUE_DETECTED_EVENT__') {
+      chrome.runtime.sendMessage(event.data.data)
+    }
+  }, false)
+}
diff --git a/packages/firefox-extension/src/injection.ts b/packages/firefox-extension/src/injection.ts
@@ -1,4 +1,4 @@
-if (document instanceof Document) {
+if (document instanceof HTMLDocument) {
   const content = chrome.runtime.getURL('dist/prepare.js')
   const script = document.createElement('script')
   script.src = content

Original file line number	Diff line number	Diff line change
`@@ -80,6 +80,6 @@ function detect(win: Window) {`
`80`	`80`	`}, 100)`
`81`	`81`	`}`
`82`	`82`
`83`		`-if (document instanceof Document) {`
	`83`	`+if (document instanceof HTMLDocument) {`
`84`	`84`	`detect(window)`
`85`	`85`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-if (document instanceof Document) {`
	`1`	`+if (document instanceof HTMLDocument) {`
`2`	`2`	`const content = chrome.runtime.getURL('dist/prepare.js')`
`3`	`3`	`const script = document.createElement('script')`
`4`	`4`	`script.src = content`