fix(web-worker): MessagePort objects passed to Worker.postMessage work when clone === "native" #9118
+32
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ject list passed to structuredClone If the MessagePort objects are in the `transfer` list, the `onmessage` event listener on the paired port won't be called.
✅ Deploy Preview for vitest-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
whitphx
changed the title
sheremet-va
requested changes
Nov 27, 2025
| 'none', | ||
| ] satisfies Array<NonNullable<Parameters<typeof defineWebWorkers>[0]>['clone']> | ||
| cloneTypes.forEach((clone) => { | ||
| suite(`defineWebWorkers with clone=${clone}`, () => { |
Member
There was a problem hiding this comment.
Let's not mix describe and suite. describe was already imported, let's use it instead
sheremet-va
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR excludes MessagePort objects from the transferable object list passed to structuredClone.
Because, if the MessagePort objects are in the
transferlist, theonmessageevent listener on the paired port won't be called.Description
Follows #9078.
#9078 made
MessagePortwork with@vitest/web-workerbut it was not complete where the ports are not working as expected whenclone === "native".This PR fixes it.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.