fix: rename collect to import, remove prepare
#9091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
changed the title
collect to importcollect to import, remove prepare
hi-ogawa
reviewed
Nov 25, 2025
Contributor
hi-ogawa
left a comment
hi-ogawa
left a comment
There was a problem hiding this comment.
Makes sense to me. I don't think reporter output only change is breaking change.
| - Transform: How much time was spent transforming the files. See [File Transform](#file-transform). | ||
| - Setup: Time spent for running the [`setupFiles`](/config/#setupfiles) files. | ||
| - Collect: Time spent for collecting all tests in the test files. This includes the time it took to import all file dependencies. | ||
| - Import: Time it took to import your test file. This also includes the time spent collecting all tests. |
Contributor
There was a problem hiding this comment.
I liked "all dependencies" wording of previous docs. I think "import test file" alone can feel un-intuitive. Can we keep that part like this?
Suggested change
| - Import: Time it took to import your test file. This also includes the time spent collecting all tests. | |
| - Import: Time it took to import your test file and all dependencies. This also includes the time spent collecting all tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should make it easier for users to understand what collect means. We get a lot of questions about that.
importis not a perfect description, but close enough. It won't include dynamic imports made inside of tests as those are reported astestI am not sure if this is a breaking change because it changes the output, but previously we did reporter updates as major/fixes
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.