Skip to content

fix(browser): inherit isolate option, deprecate browser.isolate/browser.fileParallelism #8890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 3 commits into from
Nov 3, 2025
Merged

fix(browser): inherit isolate option, deprecate browser.isolate/browser.fileParallelism #8890

sheremet-va merged 3 commits into from
Nov 3, 2025

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Oct 31, 2025

Description

Resolves #8886

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.
  • Please check Allow edits by maintainers to make review process faster. Note that this option is not available for repositories that are owned by Github organizations.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va changed the title fix(browser): inherit isolate option fix(browser): inherit isolate option, deprecated browser.isolate/browser.fileParallelism Oct 31, 2025
@netlify
Copy link

netlify bot commented Oct 31, 2025

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 6791c2d
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/6904804b6edafa00084de3e0
😎 Deploy Preview https://deploy-preview-8890--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@sheremet-va sheremet-va changed the title fix(browser): inherit isolate option, deprecated browser.isolate/browser.fileParallelism fix(browser): inherit isolate option, deprecate browser.isolate/browser.fileParallelism Oct 31, 2025
@yjaaidi
Copy link
Contributor

yjaaidi commented Oct 31, 2025

I think that it would be safer to not ship this change without a fix for this issue #8883

For instance, this behavior is what is preventing Angular's new vitest runner from failing when using --debug option.
They are using isolate: false which is ignored in browser mode.
Cf. https://github.com/angular/angular-cli/blob/cf47d15efb4ad6ff68fc64be6d60df158c53baeb/packages/angular/build/src/builders/unit-test/runners/vitest/executor.ts#L206

@sheremet-va sheremet-va merged commit 9d2b4d5 into vitest-dev:main Nov 3, 2025
10 of 14 checks passed
@sheremet-va sheremet-va deleted the fix/browser-inherit-isolate branch November 3, 2025 16:05
Copilot AI pushed a commit that referenced this pull request Nov 6, 2025
@sheremet-va
fix(browser): inherit isolate option, deprecate browser.isolate/`…
6e17b27 
…browser.fileParallelism` (#8890)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

In browser mode, fallbak to isolate option if browser.isolate is not set.

2 participants

@sheremet-va @yjaaidi