Skip to content

fix(cli): throw error when --shard x/<count> exceeds count of test files #8112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 2 commits into from
Jun 17, 2025
Merged

fix(cli): throw error when --shard x/<count> exceeds count of test files #8112

sheremet-va merged 2 commits into from
Jun 17, 2025

Conversation

@AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Jun 6, 2025

Description

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@AriPerkkio AriPerkkio force-pushed the fix/error-when-shard-count-higher-than-testfile-count branch from 22dde41 to e1cbc14 Compare June 6, 2025 08:32
AriPerkkio
AriPerkkio commented Jun 11, 2025
View reviewed changes
@AriPerkkio AriPerkkio force-pushed the fix/error-when-shard-count-higher-than-testfile-count branch from e1cbc14 to a2e3b0b Compare June 14, 2025 13:31
@netlify
Copy link

netlify bot commented Jun 14, 2025

✅ Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a2e3b0b
🔍 Latest deploy log https://app.netlify.com/projects/vitest-dev/deploys/684d799bc9c81d000802c79a
😎 Deploy Preview https://deploy-preview-8112--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@AriPerkkio AriPerkkio force-pushed the fix/error-when-shard-count-higher-than-testfile-count branch from a2e3b0b to 45e532f Compare June 14, 2025 13:41
@sheremet-va sheremet-va merged commit 8a18c8e into vitest-dev:main Jun 17, 2025
15 checks passed
@AriPerkkio AriPerkkio deleted the fix/error-when-shard-count-higher-than-testfile-count branch June 17, 2025 16:46
@renovate renovate bot mentioned this pull request Jun 21, 2025
Closed
1 task
@shamrt-v shamrt-v mentioned this pull request Jun 27, 2025
Closed
6 tasks
@khankhan389 khankhan389 mentioned this pull request Jul 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sheremet-va sheremet-va sheremet-va approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fails a shard if the shard index is higher than the number of test files

2 participants

@AriPerkkio @sheremet-va