fix: ensure errors keep their message and stack after toJSON serialisation
#8053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
hi-ogawa
approved these changes
May 30, 2025
Comment on lines
-125
to
-133
| // stack is not serialized in worker communication | ||
| // we stringify it first | ||
| if (typeof err.stack === 'string') { | ||
| err.stackStr = String(err.stack) | ||
| } | ||
| if (typeof err.name === 'string') { | ||
| err.nameStr = String(err.name) | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
I was feeling this is mostly redundant for a long time 😄
|
Seems this PR breaks our code because we use |
Member
Author
Yes, use |
Member
Author
By the way, note that Vitest 4 will remove |
|
I see. Good to know. Thanks. |
1 task
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8040
Description
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.