Skip to content

fix(browser): resolve FS commands relative to the project root #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sheremet-va merged 1 commit into from
May 5, 2025
Merged

fix(browser): resolve FS commands relative to the project root #7896

sheremet-va merged 1 commit into from
May 5, 2025

Conversation

@sheremet-va
Copy link
Member

@sheremet-va sheremet-va commented Apr 28, 2025

Description

Related #7563

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

@sheremet-va sheremet-va added this to the 3.2.0 milestone Apr 28, 2025
@netlify
Copy link

netlify bot commented Apr 28, 2025

✅ Deploy Preview for vitest-dev ready!

Name Link
🔨 Latest commit 632022a
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/680f91e441b6aa0008dc7471
😎 Deploy Preview https://deploy-preview-7896--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sheremet-va sheremet-va moved this to P2 - 4 in Team Board Apr 28, 2025
@sheremet-va sheremet-va added the p2-to-be-discussed Enhancement under consideration (priority) label Apr 28, 2025
@sheremet-va sheremet-va moved this from P2 - 4 to Approved in Team Board May 1, 2025
@sheremet-va sheremet-va added p2-nice-to-have Not breaking anything but nice to have (priority) and removed p2-to-be-discussed Enhancement under consideration (priority) labels May 2, 2025
@sheremet-va sheremet-va merged commit 69ac92c into vitest-dev:main May 5, 2025
12 of 15 checks passed
@sheremet-va sheremet-va deleted the fix/resolve-fs-relative-to-root branch May 5, 2025 14:14
@sheremet-va sheremet-va mentioned this pull request May 28, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hi-ogawa hi-ogawa hi-ogawa approved these changes

Assignees

No one assigned

Labels

p2-nice-to-have Not breaking anything but nice to have (priority)

Projects

Team Board
Archived in project

Milestone

3.2.0

Development

Successfully merging this pull request may close these issues.

2 participants

@sheremet-va @hi-ogawa