fix: remove unused exports #7618
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sheremet-va
commented
Mar 6, 2025
✅ Deploy Preview for vitest-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
sheremet-va
commented
Mar 6, 2025
sheremet-va
commented
Mar 6, 2025
AriPerkkio
reviewed
Mar 7, 2025
sheremet-va
added
the
p2-to-be-discussed
sheremet-va
changed the title
Comment on lines
-77
to
-80
| "./utils": { | ||
| "types": "./dist/utils.d.ts", | ||
| "default": "./dist/utils.js" | ||
| }, |
There was a problem hiding this comment.
This is a breaking change. This may or may not be intentional, but I want to make sure you’re aware. I had to make code changes because of this in remcohaszing/monaco-languageserver-types@7183fd5.
Member
Author
There was a problem hiding this comment.
It was never documented, so we don't consider it a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR:
vitest/browsertovitest/internal/browservitest/utilstovitest/internal/browserentry pointvitest/utilsentry pointisFirstRun,runOnce,getRunningMode,isWatchModePlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
pnpm-lock.yamlunless you introduce a new test example.Tests
pnpm test:ci.Documentation
pnpm run docscommand.Changesets
feat:,fix:,perf:,docs:, orchore:.