fix(benchmark): disable type testing while benchmarking (#7068)

AriPerkkio · web-flow · commit 4e60333dc723 · 2024-12-11T15:31:03.000+01:00
diff --git a/packages/vitest/src/node/config/resolveConfig.ts b/packages/vitest/src/node/config/resolveConfig.ts
@@ -557,6 +557,7 @@ export function resolveConfig(
     }
     // override test config
     resolved.coverage.enabled = false
+    resolved.typecheck.enabled = false
     resolved.include = resolved.benchmark.include
     resolved.exclude = resolved.benchmark.exclude
     resolved.includeSource = resolved.benchmark.includeSource
diff --git a/test/benchmark/fixtures/basic/should-not-run.test-d.ts b/test/benchmark/fixtures/basic/should-not-run.test-d.ts
@@ -0,0 +1,7 @@
+import { describe, expectTypeOf, test } from 'vitest'
+
+describe('test', () => {
+  test('some-test', () => {
+    expectTypeOf({ a: 1 }).toEqualTypeOf({ a: "should not match" })
+  })
+})
diff --git a/test/benchmark/test/basic.test.ts b/test/benchmark/test/basic.test.ts
@@ -13,6 +13,9 @@ it('basic', { timeout: 60_000 }, async () => {
     root,
     allowOnly: true,
     outputJson: 'bench.json',
+
+    // Verify that type testing cannot be used with benchmark
+    typecheck: { enabled: true },
   }, [], 'benchmark')
   expect(result.exitCode).toBe(0)
 
diff --git a/tsconfig.check.json b/tsconfig.check.json
@@ -14,6 +14,7 @@
     "./packages/ui/client/**",
     "./examples/**/*.*",
     "./bench/**",
+    "./test/benchmark/fixtures/**",
     "./test/typescript/**",
     "./test/browser/**",
     "**/coverage/fixtures/**",

Original file line number	Diff line number	Diff line change
`@@ -557,6 +557,7 @@ export function resolveConfig(`
`557`	`557`	`}`
`558`	`558`	`// override test config`
`559`	`559`	`resolved.coverage.enabled = false`
	`560`	`+ resolved.typecheck.enabled = false`
`560`	`561`	`resolved.include = resolved.benchmark.include`
`561`	`562`	`resolved.exclude = resolved.benchmark.exclude`
`562`	`563`	`resolved.includeSource = resolved.benchmark.includeSource`