fix(valid-title): also allow string types with settings.typecheck (#682)

JoshuaKGoldberg · web-flow · commit 9fff541ac6a7 · 2025-03-17T20:27:54.000-04:00
diff --git a/src/rules/valid-title.ts b/src/rules/valid-title.ts
@@ -86,6 +86,10 @@ function isClassType(type: ts.Type): boolean {
     || ts.isClassExpression(declaration)) ?? false
 }
 
+function isStringLikeType(type: ts.Type): boolean {
+  return !!(type.flags & (ts.TypeFlags.StringLike))
+}
+
 const compileMatcherPatterns = (matchers:
   | Partial<Record<MatcherGroups, string | MatcherAndMessage>>
   | MatcherAndMessage
@@ -213,7 +217,7 @@ export default createEslintRule<Options, MESSAGE_IDS>({
 
           const type = services.getTypeAtLocation(argument)
 
-          if (isFunctionType(type) || isClassType(type)) return
+          if (isFunctionType(type) || isClassType(type) || isStringLikeType(type)) return
         }
 
         if (!argument || (allowArguments && argument.type === AST_NODE_TYPES.Identifier)) return
diff --git a/tests/valid-title.test.ts b/tests/valid-title.test.ts
@@ -38,6 +38,39 @@ ruleTester.run(RULE_NAME, rule, {
      `,
       settings: { vitest: { typecheck: true } }
     },
+    {
+      code: `
+      declare const outerName: string;
+      describe(outerName, () => {
+        test('item', () => {
+          expect(0).toBe(0)
+        })
+      })
+     `,
+      settings: { vitest: { typecheck: true } }
+    },
+    {
+      code: `
+      declare const outerName: 'a';
+      describe(outerName, () => {
+        test('item', () => {
+          expect(0).toBe(0)
+        })
+      })
+     `,
+      settings: { vitest: { typecheck: true } }
+    },
+    {
+      code: `
+      declare const outerName: \`\${'a'}\`;
+      describe(outerName, () => {
+        test('item', () => {
+          expect(0).toBe(0)
+        })
+      })
+     `,
+      settings: { vitest: { typecheck: true } }
+    },
     {
       code: `
       class foo{}
