Skip to content

Conversation

@illia-v
Copy link
Member

@illia-v illia-v commented Mar 4, 2025

A couple of our actions use Ubuntu 20.04 which is deprecated as a GitHub Actions runner image and will be fully unsupported by April 1 actions/runner-images#11101.
We cannot run tests with Python 3.9.2 and OpenSSL 1.1.1 in newer Ubuntu releases, so I have to drop the two jobs from the matrix.

The rest of the tests are upgraded to ubuntu-latest which is Ubuntu 24.04 as of today.

@illia-v illia-v added the Skip Changelog Pull requests that don't require a changelog entry label Mar 4, 2025
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for keeping our CI running!

@pquentin
Copy link
Member

pquentin commented Mar 5, 2025

I removed OpenSSL 3.0 from the required checks.

@illia-v
Copy link
Member Author

illia-v commented Mar 6, 2025

@pquentin thanks for reviewing this, I've addressed your comments

@illia-v illia-v requested a review from pquentin March 6, 2025 20:16
Copy link
Member

@pquentin pquentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM. Not sure why macOS and Windows are reported as missing when we did not change them.

@illia-v
Copy link
Member Author

illia-v commented Mar 7, 2025

Not sure why macOS and Windows are reported as missing when we did not change them.

Me too. I can see that some options are duplicated in the branch protection settings

I've just tried setting alternative variants for Windows and macOS, but it doesn't help

@illia-v illia-v merged commit 3e8f2db into urllib3:main Mar 7, 2025
35 checks passed
@illia-v illia-v deleted the ubuntu-latest branch March 7, 2025 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip Changelog Pull requests that don't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants