Skip to content

Fix docs build on Python 3.12 #3144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pquentin merged 1 commit into from
Oct 5, 2023
Merged

Fix docs build on Python 3.12 #3144

pquentin merged 1 commit into from
Oct 5, 2023

Conversation

@pquentin
Copy link
Member

@pquentin pquentin commented Oct 5, 2023

ssl.wrap_socket is gone in Python 3.12, let's link to SSLContext.wrap_socket instead: https://docs.python.org/3.12/whatsnew/3.12.html#ssl

@pquentin pquentin added the Skip Changelog Pull requests that don't require a changelog entry label Oct 5, 2023
sethmlarson
sethmlarson approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! :shipit:

@pquentin pquentin merged commit 80808b0 into urllib3:main Oct 5, 2023
@pquentin pquentin deleted the fix-docs-build branch October 5, 2023 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

@illia-v illia-v Awaiting requested review from illia-v

Assignees

No one assigned

Labels

Skip Changelog Pull requests that don't require a changelog entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pquentin @sethmlarson