Make poolmanger threadsafe in 1.26.x #2954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@thomasmaclean Thanks for opening this PR, unfortunately this release stream still supports Python 2.7 so you'll need to find an alternative to |
Author
I'm backporting the CPython version of finalize as it's pretty portable the way it's written. I tried to copy the pattern used for |
sethmlarson
approved these changes
Apr 19, 2023
ghost
mentioned this pull request
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2661, which addresses a thread-safety issue where accessing a
PoolManagerwith many distinct origins would cause connection pools to be closed while requests are in progress. #1252 causes issues in multiprocessing workflows for dependent libraries likerequestsetc.