-
-
Notifications
You must be signed in to change notification settings - Fork 954
fix(eslint): enhance handling of array expressions #4925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for unocss ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
commit: |
zyyv
approved these changes
Sep 18, 2025
This was referenced Sep 23, 2025
This was referenced Sep 23, 2025
This was referenced Oct 1, 2025
This was referenced Oct 10, 2025
This was referenced Sep 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4923
This PR enhances the
@unocss/orderESLint rule to support sorting UnoCSS classes inside arrays passed to functions likeclassnamesand custom utilities. Previously, unordered classes in arrays were not detected or auto-fixed, which led to inconsistent styling and missed linting errors.🐛 Problem
The rule only checked class strings passed directly to functions. When classes appeared inside arrays, unordered classes slipped through without any warning or auto-fix, making it easy for styling inconsistencies to creep into the codebase.
✨ Changes
Now, the ESLint rule inspects and sorts UnoCSS classes within arrays passed to supported functions, so unordered classes are always detected and auto-fixed, whether they appear in strings or arrays. This ensures a consistent developer experience and styling.
Before
After