Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via php.ini #58704

Merged
merged 2 commits into from
Oct 30, 2024
Merged

[HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via php.ini #58704

merged 2 commits into from
Oct 30, 2024

Conversation

ZaneCEO
Copy link
Contributor

@ZaneCEO ZaneCEO commented Oct 29, 2024 •
edited by nicolas-grekas
Loading

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58700
License MIT

HttpClientDataCollector::escapePayload creates a new Process() -> it fails if proc_open is disabled:

The Process class relies on proc_open, which is not available on your PHP installation.

#58700

@carsonbot

This comment was marked as resolved.

Sign in to view
@carsonbot
Copy link

Hey!

Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/
Could you update the PR base branch to target one of these branches instead? 5.4, 6.4, 7.1, 7.2.

Cheers!

Carsonbot

@xabbuh xabbuh changed the base branch from 6.3 to 6.4 October 29, 2024 08:38
@carsonbot carsonbot changed the title fix for HttpClientDataCollector fails if proc_open is disabled via ph… [HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via ph… Oct 29, 2024
@xabbuh
Copy link
Member

xabbuh commented Oct 29, 2024

@ZaneCEO Please rebase your changes onto the 6.4 branch as Symfony 6.3 is not maintained anymore.

@nicolas-grekas nicolas-grekas added this to the 6.4 milestone Oct 29, 2024
@nicolas-grekas nicolas-grekas changed the title [HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via ph… [HttpClient] fix for HttpClientDataCollector fails if proc_open is disabled via php.ini Oct 29, 2024
nicolas-grekas
nicolas-grekas approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we can retarget while merging)

@nicolas-grekas
Copy link
Member

Thank you @ZaneCEO.

@nicolas-grekas nicolas-grekas merged commit 22df28a into symfony:6.4 Oct 30, 2024
8 of 10 checks passed
@ZaneCEO ZaneCEO deleted the patch-1 branch October 30, 2024 23:04
This was referenced Nov 6, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandre-daubois alexandre-daubois alexandre-daubois approved these changes

@xabbuh xabbuh xabbuh approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug HttpClient Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
5 participants
@ZaneCEO @carsonbot @xabbuh @nicolas-grekas @alexandre-daubois