Bump css-tree from 2.3.1 to 3.0.0 #7993

Mouvedia · 2024-09-12T09:02:46Z

Is there anything in the PR that needs further explanation?

Unknown properties are ignored by declaration-property-value-no-unknown.
i.e. most regressions will be picked up by reject, not accept

It doesn't c l o s e #7964 because position-try-options is still unknown.

changeset-bot · 2024-09-12T09:02:50Z

🦋 Changeset detected

Latest commit: 8c0ba7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Mouvedia · 2024-09-12T09:13:36Z

lib/rules/declaration-property-value-no-unknown/__tests__/index.mjs

 		{
 			code: 'a { view-timeline: --bar x; }',
 		},
 		{
-			code: 'a { view-transition-name: qux-baz; }',
+			code: 'a { view-timeline: --qux inline 1px 2px; }',


web-platform-tests/wpt@d7b9c5c#diff-f7ae5e0f8d9c5ece281b294a07b7d296ad851e498e38693eabc775f207916fd0

- [Release notes](https://github.com/csstree/csstree/releases/tag/v3.0.0) - [Commits](csstree/csstree@v2.3.1...v3.0.0)

romainmenke · 2024-09-12T09:24:40Z

Thank you @Mouvedia

The custom handling of initial-value around line 160 can also be removed I think.

ybiquitous · 2024-09-12T12:43:20Z

Great! Do you think it's needed to add some changelog?

Mouvedia · 2024-09-12T13:25:24Z

Great! Do you think it's needed to add some changelog?

If I were to fix position-try-options, yes; but I didn't.

ybiquitous · 2024-09-12T14:08:35Z

Okay. I understand this PR has no user impact.

I thought we might need to mention this important dependency update in CHANGELOG, but there is no such description in CHANGELOG, so it would be unnecessary. 👍🏼

jeddy3 · 2024-09-12T14:14:57Z

Will it close #7241? If so, we can add an changelog entry for that.

jeddy3 · 2024-09-12T14:16:05Z

Nevermind, just saw #7995 (comment).

ybiquitous

Thanks a lot. LGTM 👍🏼

ybiquitous · 2024-09-12T14:27:15Z

If some users would care about this update, it might be good to add changelog, but not strong opinion.

romainmenke · 2024-09-12T14:29:26Z

I think user would want to know, especially when they have custom config for newer CSS that might become obsolete with this update.

Given that this rule doesn't warn on properties without syntax an update to css-tree would also produce more errors if support for new properties was added.

That would imply a new minor version bump.

ybiquitous · 2024-09-12T14:33:59Z

Good point. I agree with adding a changelog. 👍🏼

Add changelog

Mouvedia · 2024-09-12T14:36:53Z

Ill review mdn/data@v2.0.30...v2.10.0#diff-06572a96a5 and list all the properties that are now supported.

It might take some time because of all the testing necessary.
i.e. css-tree had patches

romainmenke · 2024-09-12T14:45:01Z

Maybe sufficient to link to the css-tree changelog?
I think the most important thing is communicating that something has changed.

Mouvedia · 2024-09-12T14:52:48Z

Maybe sufficient to link to the css-tree changelog? I think the most important thing is communicating that something has changed.

OK.

.changeset/many-baboons-care.md

Co-authored-by: Masafumi Koba <[email protected]>

ybiquitous

Thanks. LGTM 👍🏼

Let's wait for other reviews too.

romainmenke

Thank you for this 🙇

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------ | ------- | | npm | stylelint | 16.9.0 | 16.10.0 | ## [v16.10.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16100) - Changed: `shorthand-property-no-redundant-values` reported ranges ([#8008](stylelint/stylelint#8008)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `formatter` configuration property ([#7826](stylelint/stylelint#7826)) ([@emmacharp](https://github.com/emmacharp)). - Added: `validate` option to Node.js API and `--validate` CLI flag ([#8009](stylelint/stylelint#8009)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: fixed section to the output of the `verbose` formatter ([#7985](stylelint/stylelint#7985)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: support for `string | RegExp` to `ignoreValues` option of `value-no-vendor-prefix` ([#7969](stylelint/stylelint#7969)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: support for `string` to `ignoreLonghands` option of `declaration-block-no-redundant-longhand-properties` ([#7971](stylelint/stylelint#7971)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-no-unknown` false positives for `@position-try` ([#7968](stylelint/stylelint#7968)) ([@yelizsevinc](https://github.com/yelizsevinc)). - Fixed: `declaration-block-no-redundant-longhand-properties` autofix for `grid-column`/`grid-row` ([#8023](stylelint/stylelint#8023)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `declaration-property-value-no-unknown` false negatives/positives via [`[email protected]`](https://github.com/csstree/csstree/releases/tag/v3.0.0) ([#7993](stylelint/stylelint#7993)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `declaration-property-value-no-unknown` reported ranges and message ([#8003](stylelint/stylelint#8003)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `keyframe-selector-notation` reported ranges ([#7992](stylelint/stylelint#7992)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `length-zero-no-unit` false positives for Sass variables ([#8035](stylelint/stylelint#8035)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `no-descending-specificity` reported ranges ([#7996](stylelint/stylelint#7996)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-anb-no-unmatchable` reported ranges and message ([#8001](stylelint/stylelint#8001)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `string` formatter handling of log symbols for non-Unicode terminals ([#7981](stylelint/stylelint#7981)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: built `.cjs` files to address Rollup vulnerability ([#8010](stylelint/stylelint#8010)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: incorrect `config` option for Node.js API with `extends` and `overrides` ([#8030](stylelint/stylelint#8030)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: stricter validation for the options of `declaration-property-max-values`, `declaration-property-value-no-unknown` and `number-max-precision` ([#7975](stylelint/stylelint#7975)) ([@Mouvedia](https://github.com/Mouvedia)).

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------ | ------- | | npm | stylelint | 16.9.0 | 16.10.0 | ## [v16.10.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16100) - Changed: `shorthand-property-no-redundant-values` reported ranges ([#8008](stylelint/stylelint#8008)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `formatter` configuration property ([#7826](stylelint/stylelint#7826)) ([@emmacharp](https://github.com/emmacharp)). - Added: `validate` option to Node.js API and `--validate` CLI flag ([#8009](stylelint/stylelint#8009)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: fixed section to the output of the `verbose` formatter ([#7985](stylelint/stylelint#7985)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: support for `string | RegExp` to `ignoreValues` option of `value-no-vendor-prefix` ([#7969](stylelint/stylelint#7969)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: support for `string` to `ignoreLonghands` option of `declaration-block-no-redundant-longhand-properties` ([#7971](stylelint/stylelint#7971)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-no-unknown` false positives for `@position-try` ([#7968](stylelint/stylelint#7968)) ([@yelizsevinc](https://github.com/yelizsevinc)). - Fixed: `declaration-block-no-redundant-longhand-properties` autofix for `grid-column`/`grid-row` ([#8023](stylelint/stylelint#8023)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `declaration-property-value-no-unknown` false negatives/positives via [`[email protected]`](https://github.com/csstree/csstree/releases/tag/v3.0.0) ([#7993](stylelint/stylelint#7993)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `declaration-property-value-no-unknown` reported ranges and message ([#8003](stylelint/stylelint#8003)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `keyframe-selector-notation` reported ranges ([#7992](stylelint/stylelint#7992)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `length-zero-no-unit` false positives for Sass variables ([#8035](stylelint/stylelint#8035)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `no-descending-specificity` reported ranges ([#7996](stylelint/stylelint#7996)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-anb-no-unmatchable` reported ranges and message ([#8001](stylelint/stylelint#8001)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `string` formatter handling of log symbols for non-Unicode terminals ([#7981](stylelint/stylelint#7981)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: built `.cjs` files to address Rollup vulnerability ([#8010](stylelint/stylelint#8010)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: incorrect `config` option for Node.js API with `extends` and `overrides` ([#8030](stylelint/stylelint#8030)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: stricter validation for the options of `declaration-property-max-values`, `declaration-property-value-no-unknown` and `number-max-precision` ([#7975](stylelint/stylelint#7975)) ([@Mouvedia](https://github.com/Mouvedia)).

Mouvedia force-pushed the tree-three branch from 55fab7b to 9204bc6 Compare September 12, 2024 09:10

Mouvedia requested review from ybiquitous and romainmenke September 12, 2024 09:12

Mouvedia marked this pull request as ready for review September 12, 2024 09:12

Mouvedia commented Sep 12, 2024

View reviewed changes

Bump css-tree from 2.3.1 to 3.0.0

5f4af6d

- [Release notes](https://github.com/csstree/csstree/releases/tag/v3.0.0) - [Commits](csstree/csstree@v2.3.1...v3.0.0)

Mouvedia force-pushed the tree-three branch from 9204bc6 to 5f4af6d Compare September 12, 2024 09:17

Mouvedia requested a review from jeddy3 September 12, 2024 09:18

code review 1

4a2ff72

ybiquitous added the pr: dependencies relates to dependencies label Sep 12, 2024

ybiquitous previously approved these changes Sep 12, 2024

View reviewed changes

add changeset

d19eca6

Mouvedia requested a review from ybiquitous September 12, 2024 14:59

ybiquitous reviewed Sep 12, 2024

View reviewed changes

.changeset/many-baboons-care.md Outdated Show resolved Hide resolved

Update .changeset/many-baboons-care.md

8c0ba7e

Co-authored-by: Masafumi Koba <[email protected]>

Mouvedia requested a review from ybiquitous September 12, 2024 16:08

ybiquitous approved these changes Sep 12, 2024

View reviewed changes

romainmenke approved these changes Sep 12, 2024

View reviewed changes

Mouvedia merged commit c5a2df5 into stylelint:main Sep 12, 2024
17 checks passed

Mouvedia deleted the tree-three branch September 12, 2024 22:50

kristerkari mentioned this pull request Oct 13, 2024

Bump css-tree from 2.3.1 to 3.0.0 stylelint-scss/stylelint-scss#1065

Merged

Mouvedia mentioned this pull request Nov 2, 2024

Fix declaration-property-value-no-unknown false positive for stroke-opacity #8104

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump css-tree from 2.3.1 to 3.0.0 #7993

Bump css-tree from 2.3.1 to 3.0.0 #7993

Mouvedia commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

Mouvedia Sep 12, 2024

romainmenke commented Sep 12, 2024

ybiquitous commented Sep 12, 2024

Mouvedia commented Sep 12, 2024

ybiquitous commented Sep 12, 2024

jeddy3 commented Sep 12, 2024

jeddy3 commented Sep 12, 2024

ybiquitous left a comment

ybiquitous commented Sep 12, 2024

romainmenke commented Sep 12, 2024

ybiquitous commented Sep 12, 2024

Mouvedia commented Sep 12, 2024 •

edited

Loading

romainmenke commented Sep 12, 2024

Mouvedia commented Sep 12, 2024

ybiquitous left a comment

romainmenke left a comment

Bump css-tree from 2.3.1 to 3.0.0 #7993

Bump css-tree from 2.3.1 to 3.0.0 #7993

Conversation

Mouvedia commented Sep 12, 2024 • edited Loading

changeset-bot bot commented Sep 12, 2024 • edited Loading

🦋 Changeset detected

Mouvedia Sep 12, 2024

Choose a reason for hiding this comment

romainmenke commented Sep 12, 2024

ybiquitous commented Sep 12, 2024

Mouvedia commented Sep 12, 2024

ybiquitous commented Sep 12, 2024

jeddy3 commented Sep 12, 2024

jeddy3 commented Sep 12, 2024

ybiquitous left a comment

Choose a reason for hiding this comment

ybiquitous commented Sep 12, 2024

romainmenke commented Sep 12, 2024

ybiquitous commented Sep 12, 2024

Mouvedia commented Sep 12, 2024 • edited Loading

romainmenke commented Sep 12, 2024

Mouvedia commented Sep 12, 2024

ybiquitous left a comment

Choose a reason for hiding this comment

romainmenke left a comment

Choose a reason for hiding this comment

Mouvedia commented Sep 12, 2024 •

edited

Loading

changeset-bot bot commented Sep 12, 2024 •

edited

Loading

Mouvedia commented Sep 12, 2024 •

edited

Loading