Fix string formatter handling of log symbols #7981

Mouvedia · 2024-09-02T06:07:19Z

Which issue, if any, is this issue related to?

Is there anything in the PR that needs further explanation?

https://github.com/stylelint/stylelint/pull/5562/files#diff-0d10acb017f5fc20b4b5eb99470f83c79384c9014f32f1c9c7ddf4cfed760211R192
#5741 (comment)
https://github.com/sindresorhus/is-unicode-supported/blob/main/index.js

stylelint/lib/testUtils/getCleanOutput.mjs

Lines 5 to 8 in a8e598f

    
           symbolConversions.set('ℹ', 'i'); 
        
           symbolConversions.set('✔', '√'); 
        
           symbolConversions.set('⚠', '‼'); 
        
           symbolConversions.set('✖', '×');

changeset-bot · 2024-09-02T06:07:23Z

🦋 Changeset detected

Latest commit: ea64a7c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
stylelint	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

ybiquitous

Thank you, overall LGTM 👍🏼

Can you look at my review about the changelog?

.changeset/four-cameras-dream.md

ybiquitous

Thank you. LGTM 👍🏼

lib/utils/isUnicodeSupported.mjs

http://software.schmorp.de/pkg/rxvt-unicode.html

Mouvedia · 2024-09-03T15:08:15Z

@ybiquitous since it's the default formatter, I am being extra cautious.

ybiquitous

LGTM. Thank you.

Just out of curiosity, do you have a plan to return the support for rxvt-unicode upstream? In the future of our pure ESM release, we may get back to is-unicode-supported.

Mouvedia · 2024-09-03T16:04:23Z

Just out of curiosity, do you have a plan to return the support for rxvt-unicode upstream? In the future of our pure ESM release, we may get back to is-unicode-supported.

I might submit an issue.

To be honest, I think the original package is probably handling it roughly.
e.g. maybe checking LC_*, LANG or the version might be necessary
So if I were patching it, it would require a lot of time to test older versions of the terminals listed.
I suppose this package assumes the latest version of these terminals; which is also a valid interpretation.

ybiquitous · 2024-09-03T16:14:03Z

I see. So, can you leave a code comment on the difference between is-unicode-supported and lib/utils/isUnicodeSupported.mjs? The comment could help us understand why we have stopped using is-unicode-supported in the future.

Mouvedia · 2024-09-03T16:18:53Z

I see. So, can you leave a code comment on the difference between is-unicode-supported and lib/utils/isUnicodeSupported.mjs? The comment could help us understand why we have stopped using is-unicode-supported in the future.

I will add a permalink to the JSDoc comment.
The rest can be handled with blame.

ybiquitous

Thanks. The added comment is great. 👍🏼

Mouvedia · 2024-09-09T10:36:35Z

@ybiquitous sindresorhus/is-unicode-supported@c2d514b

ybiquitous · 2024-09-09T12:08:59Z

Nice. Can you backport?

Mouvedia · 2024-09-09T12:17:37Z

Can you backport?

It's essentially the same code. I am treating anything that starts with "rxvt-unicode" as supported, which is a pretty safe assumption.
i.e. it's not necessary

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------ | ------- | | npm | stylelint | 16.9.0 | 16.10.0 | ## [v16.10.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16100) - Changed: `shorthand-property-no-redundant-values` reported ranges ([#8008](stylelint/stylelint#8008)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `formatter` configuration property ([#7826](stylelint/stylelint#7826)) ([@emmacharp](https://github.com/emmacharp)). - Added: `validate` option to Node.js API and `--validate` CLI flag ([#8009](stylelint/stylelint#8009)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: fixed section to the output of the `verbose` formatter ([#7985](stylelint/stylelint#7985)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: support for `string | RegExp` to `ignoreValues` option of `value-no-vendor-prefix` ([#7969](stylelint/stylelint#7969)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: support for `string` to `ignoreLonghands` option of `declaration-block-no-redundant-longhand-properties` ([#7971](stylelint/stylelint#7971)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-no-unknown` false positives for `@position-try` ([#7968](stylelint/stylelint#7968)) ([@yelizsevinc](https://github.com/yelizsevinc)). - Fixed: `declaration-block-no-redundant-longhand-properties` autofix for `grid-column`/`grid-row` ([#8023](stylelint/stylelint#8023)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `declaration-property-value-no-unknown` false negatives/positives via [`[email protected]`](https://github.com/csstree/csstree/releases/tag/v3.0.0) ([#7993](stylelint/stylelint#7993)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `declaration-property-value-no-unknown` reported ranges and message ([#8003](stylelint/stylelint#8003)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `keyframe-selector-notation` reported ranges ([#7992](stylelint/stylelint#7992)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `length-zero-no-unit` false positives for Sass variables ([#8035](stylelint/stylelint#8035)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `no-descending-specificity` reported ranges ([#7996](stylelint/stylelint#7996)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-anb-no-unmatchable` reported ranges and message ([#8001](stylelint/stylelint#8001)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `string` formatter handling of log symbols for non-Unicode terminals ([#7981](stylelint/stylelint#7981)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: built `.cjs` files to address Rollup vulnerability ([#8010](stylelint/stylelint#8010)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: incorrect `config` option for Node.js API with `extends` and `overrides` ([#8030](stylelint/stylelint#8030)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: stricter validation for the options of `declaration-property-max-values`, `declaration-property-value-no-unknown` and `number-max-precision` ([#7975](stylelint/stylelint#7975)) ([@Mouvedia](https://github.com/Mouvedia)).

@Mouvedia

| datasource | package | from | to | | ---------- | --------- | ------ | ------- | | npm | stylelint | 16.9.0 | 16.10.0 | ## [v16.10.0](https://github.com/stylelint/stylelint/blob/HEAD/CHANGELOG.md#16100) - Changed: `shorthand-property-no-redundant-values` reported ranges ([#8008](stylelint/stylelint#8008)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: `formatter` configuration property ([#7826](stylelint/stylelint#7826)) ([@emmacharp](https://github.com/emmacharp)). - Added: `validate` option to Node.js API and `--validate` CLI flag ([#8009](stylelint/stylelint#8009)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: fixed section to the output of the `verbose` formatter ([#7985](stylelint/stylelint#7985)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: support for `string | RegExp` to `ignoreValues` option of `value-no-vendor-prefix` ([#7969](stylelint/stylelint#7969)) ([@Mouvedia](https://github.com/Mouvedia)). - Added: support for `string` to `ignoreLonghands` option of `declaration-block-no-redundant-longhand-properties` ([#7971](stylelint/stylelint#7971)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `at-rule-no-unknown` false positives for `@position-try` ([#7968](stylelint/stylelint#7968)) ([@yelizsevinc](https://github.com/yelizsevinc)). - Fixed: `declaration-block-no-redundant-longhand-properties` autofix for `grid-column`/`grid-row` ([#8023](stylelint/stylelint#8023)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `declaration-property-value-no-unknown` false negatives/positives via [`[email protected]`](https://github.com/csstree/csstree/releases/tag/v3.0.0) ([#7993](stylelint/stylelint#7993)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: `declaration-property-value-no-unknown` reported ranges and message ([#8003](stylelint/stylelint#8003)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `keyframe-selector-notation` reported ranges ([#7992](stylelint/stylelint#7992)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `length-zero-no-unit` false positives for Sass variables ([#8035](stylelint/stylelint#8035)) ([@ryo-manba](https://github.com/ryo-manba)). - Fixed: `no-descending-specificity` reported ranges ([#7996](stylelint/stylelint#7996)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `selector-anb-no-unmatchable` reported ranges and message ([#8001](stylelint/stylelint#8001)) ([@romainmenke](https://github.com/romainmenke)). - Fixed: `string` formatter handling of log symbols for non-Unicode terminals ([#7981](stylelint/stylelint#7981)) ([@Mouvedia](https://github.com/Mouvedia)). - Fixed: built `.cjs` files to address Rollup vulnerability ([#8010](stylelint/stylelint#8010)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: incorrect `config` option for Node.js API with `extends` and `overrides` ([#8030](stylelint/stylelint#8030)) ([@ybiquitous](https://github.com/ybiquitous)). - Fixed: stricter validation for the options of `declaration-property-max-values`, `declaration-property-value-no-unknown` and `number-max-precision` ([#7975](stylelint/stylelint#7975)) ([@Mouvedia](https://github.com/Mouvedia)).

Add isUnicodeSupported utility

9ba221a

ybiquitous reviewed Sep 3, 2024

View reviewed changes

.changeset/four-cameras-dream.md Outdated Show resolved Hide resolved

Update .changeset/four-cameras-dream.md

5be7731

Mouvedia force-pushed the mouvedia-5741 branch from f267a88 to 5be7731 Compare September 3, 2024 11:43

Mouvedia requested a review from ybiquitous September 3, 2024 12:08

ybiquitous approved these changes Sep 3, 2024

View reviewed changes

Mouvedia commented Sep 3, 2024

View reviewed changes

lib/utils/isUnicodeSupported.mjs Outdated Show resolved Hide resolved

support rxvt-unicode

9d207fc

http://software.schmorp.de/pkg/rxvt-unicode.html

Mouvedia requested a review from ybiquitous September 3, 2024 15:08

ybiquitous approved these changes Sep 3, 2024

View reviewed changes

add permalik

ea64a7c

ybiquitous approved these changes Sep 3, 2024

View reviewed changes

Mouvedia merged commit 53b342f into stylelint:main Sep 3, 2024
16 of 17 checks passed

Mouvedia deleted the mouvedia-5741 branch September 3, 2024 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix string formatter handling of log symbols #7981

Fix string formatter handling of log symbols #7981

Mouvedia commented Sep 2, 2024 •

edited

Loading

changeset-bot bot commented Sep 2, 2024 •

edited

Loading

ybiquitous left a comment

ybiquitous left a comment

Mouvedia commented Sep 3, 2024

ybiquitous left a comment •

edited

Loading

Mouvedia commented Sep 3, 2024 •

edited

Loading

ybiquitous commented Sep 3, 2024

Mouvedia commented Sep 3, 2024

ybiquitous left a comment

Mouvedia commented Sep 9, 2024

ybiquitous commented Sep 9, 2024

Mouvedia commented Sep 9, 2024

	symbolConversions.set('ℹ', 'i');
	symbolConversions.set('✔', '√');
	symbolConversions.set('⚠', '‼');
	symbolConversions.set('✖', '×');

Fix string formatter handling of log symbols #7981

Fix string formatter handling of log symbols #7981

Conversation

Mouvedia commented Sep 2, 2024 • edited Loading

changeset-bot bot commented Sep 2, 2024 • edited Loading

🦋 Changeset detected

ybiquitous left a comment

Choose a reason for hiding this comment

ybiquitous left a comment

Choose a reason for hiding this comment

Mouvedia commented Sep 3, 2024

ybiquitous left a comment • edited Loading

Choose a reason for hiding this comment

Mouvedia commented Sep 3, 2024 • edited Loading

ybiquitous commented Sep 3, 2024

Mouvedia commented Sep 3, 2024

ybiquitous left a comment

Choose a reason for hiding this comment

Mouvedia commented Sep 9, 2024

ybiquitous commented Sep 9, 2024

Mouvedia commented Sep 9, 2024

Mouvedia commented Sep 2, 2024 •

edited

Loading

changeset-bot bot commented Sep 2, 2024 •

edited

Loading

ybiquitous left a comment •

edited

Loading

Mouvedia commented Sep 3, 2024 •

edited

Loading