Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose NodePackageImporter in sass_api #2452

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Expose NodePackageImporter in sass_api #2452

merged 2 commits into from
Dec 3, 2024

Conversation

jathak
Copy link
Member

@jathak jathak commented Dec 2, 2024

This will allow the Sass migrator to support pkg: URLs.

@jathak jathak requested a review from nex3 December 2, 2024 22:30
@@ -2,15 +2,15 @@ name: sass_api
# Note: Every time we add a new Sass AST node, we need to bump the *major*
# version because it's a breaking change for anyone who's implementing the
# visitor interface(s).
version: 14.2.0
version: 14.2.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is adding a new feature to sass_api, so it should be 14.3.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops. Had it as a minor version originally, but accidentally did a patch version when I re-did it after syncing

@jathak jathak requested a review from nex3 December 3, 2024 00:32
@jathak jathak merged commit 5163644 into main Dec 3, 2024
39 checks passed
@jathak jathak deleted the node-package-importer branch December 3, 2024 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants