Prevent prototype pollution in cookie memstore #283
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All occurrences of new object creation in `memstore.js` have been changed from `{}` (i.e.; `Object.create(Object.prototype)` to `Object.create(null)` so that we are using object instances that do not have a prototype property that can be polluted.
@fixes #282
awaterma
approved these changes
Jun 5, 2023
Member
awaterma
left a comment
awaterma
left a comment
There was a problem hiding this comment.
Thanks for jumping on this Colin. LGTM.
Merged
shaharduany
added a commit
to shaharduany/tough-cookie
that referenced
this pull request
May 14, 2024
WeissShahar
pushed a commit
to WeissShahar/tough-cookie
that referenced
this pull request
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All occurrences of new object creation in
memstore.jshave been changed from{}(i.e.;Object.create(Object.prototype)toObject.create(null)so that we are using object instances that do not have a prototype property that can be polluted.@fixes #282