Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Rails/CompactBlank to avoid reporting offense for filter in Ruby versions below 2.6 #1361

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

masato-bkn
Copy link
Contributor

@masato-bkn masato-bkn commented Sep 11, 2024

This PR fixes Rails/CompactBlank to avoid reporting offense for filter in Ruby versions below 2.6.

This change is related to #1359. Apologies for the confusion earlier, as I initially mixed up the runtime version with the analysis version when considering Rubocop's supported versions.

Rails/CompactBlank applies to Rails 6.1 and above, where the required Ruby version is 2.5. However, since filter method was introduced in Ruby 2.6, using filter in environments running Ruby 2.5 may result in false positives.

Additionally, since #1359 is still unreleased, I am unsure whether this change should be added to the changelog. I would appreciate any feedback, including thoughts on other aspects of this PR.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
    * [ ] Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.
    * [] If this is a new cop, consider making a corresponding update to the [Rails Style Guide](https://github.com/rubocop/rails-style-guide).

@masato-bkn masato-bkn force-pushed the fix-rails-compact-blank branch 2 times, most recently from 155abd0 to 378af29 Compare September 11, 2024 15:06
@masato-bkn masato-bkn force-pushed the fix-rails-compact-blank branch from 378af29 to f4f3bf1 Compare September 11, 2024 15:08
@koic koic merged commit 5e66785 into rubocop:master Sep 11, 2024
14 checks passed
@koic
Copy link
Member

koic commented Sep 11, 2024

Thank you for following up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants