[Fix #14628] Fix false positives for Style/FloatDivision
#14629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koic
force-pushed
the
fix_false_positives_for_style_float_division
branch
from
ed0037a to
a145697
Compare
Contributor
|
Thanks, I didn't think about this |
This PR fixes false positives for `Style/FloatDivision` when using `Regexp.last_match` or nth reference (e.g., `$1`). For `Regexp.last_match(1)` and `$1`, it assumes that the value is a string matched by a regular expression, and allows conversion with `#to_f`. This cop is already marked as unsafe, but these issues can be avoided. Fixes rubocop#14628.
koic
force-pushed
the
fix_false_positives_for_style_float_division
branch
from
a145697 to
e8abfd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes false positives for
Style/FloatDivisionwhen usingRegexp.last_matchor nth reference (e.g.,$1).For
Regexp.last_match(1)and$1, it assumes that the value is a string matched by a regular expression, and allows conversion with#to_f.This cop is already marked as unsafe, but these issues can be avoided.
Fixes #14628.
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.