Fix an error for InternalAffairs/NodeMatcherDirective when no second argument
#13179
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbatsov
reviewed
Sep 1, 2024
| @@ -103,6 +103,7 @@ def too_many_directives(node) | |||
|
|
|||
| def process_directive(node, actual_name, directive) | |||
| return unless (offense_type = directive_offense_type(directive, actual_name)) | |||
| return unless node.arguments.count == 2 | |||
There was a problem hiding this comment.
I'd add a comment explaining this, as it's quite cryptic without one.
There was a problem hiding this comment.
I didn't even add it add the proper place, oops. Right after on_send it doesn't need one I think but let me know if you still think otherwise.
There was a problem hiding this comment.
The intent of the modified code is clearly readable after this comment.
Earlopain
force-pushed
the
node-matcher-directiry-error
branch
from
56e4567 to
fd4f4d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is code below that assumes the existance of two arguments
Before submitting the PR make sure the following are checked:
[Fix #issue-number](if the related issue exists).master(if not - rebase it).bundle exec rake default. It executes all tests and runs RuboCop on its own code.{change_type}_{change_description}.mdif the new code introduces user-observable changes. See changelog entry format for details.