Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure impure dependencies of pure modules are added #5669

Merged
merged 2 commits into from
Sep 21, 2024

Conversation

lukastaegert
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

I think this is the bug of the original implementation, I missed impure dependencies of pure modules...

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 2:40pm

Copy link

github-actions bot commented Sep 20, 2024

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix-impure-dependencies-of-pure-modules

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-883qw2zp3-rollup-js.vercel.app/repl/?pr=5669

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.39%. Comparing base (b86ffd7) to head (9e04b48).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5669   +/-   ##
=======================================
  Coverage   99.39%   99.39%           
=======================================
  Files         242      242           
  Lines        9346     9350    +4     
  Branches     2470     2471    +1     
=======================================
+ Hits         9289     9293    +4     
  Misses         48       48           
  Partials        9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Performance report!

Rough benchmark

Command Mean [s] Min [s] Max [s] Relative
node _benchmark/previous/bin/rollup -i ./perf/entry.js -o _benchmark/result/previous.js 9.318 ± 0.029 9.287 9.342 1.00
node _benchmark/current/bin/rollup -i ./perf/entry.js -o _benchmark/result/current.js 9.326 ± 0.102 9.242 9.440 1.00 ± 0.01

Internal benchmark

  • BUILD: 8327ms, 754 MB
    • initialize: 0ms, 26 MB
    • generate module graph: 3204ms, 574 MB
      • generate ast: 1545ms, 566 MB
    • sort and bind modules: 459ms, 614 MB
    • mark included statements: 4668ms, 754 MB
      • treeshaking pass 1: 1598ms, 718 MB
      • treeshaking pass 2: 762ms, 736 MB
      • treeshaking pass 3: 296ms, 742 MB
      • treeshaking pass 4: 272ms, 746 MB
      • treeshaking pass 5: 319ms, 752 MB
      • treeshaking pass 6: 266ms, 745 MB
      • treeshaking pass 7: 247ms, 750 MB
      • treeshaking pass 8: 240ms, 749 MB
      • treeshaking pass 9: 216ms, 752 MB
      • treeshaking pass 10: 220ms, 753 MB
      • treeshaking pass 11: 215ms, 754 MB
  • GENERATE: 902ms, 1.02 GB
    • initialize render: 0ms, 912 MB
    • generate chunks: 80ms, 924 MB
      • optimize chunks: 0ms, 915 MB
    • render chunks: 795ms, 999 MB
    • transform chunks: 19ms, 1.02 GB
    • generate bundle: 0ms, 1.02 GB

Copy link

This PR has been released as part of [email protected]. Note that this is a pre-release, so to test it, you need to install Rollup via npm install [email protected] or npm install rollup@beta. It will likely become part of a regular release later.

@lukastaegert lukastaegert merged commit 59cec3e into master Sep 21, 2024
70 checks passed
@lukastaegert lukastaegert deleted the fix-impure-dependencies-of-pure-modules branch September 21, 2024 04:45
Copy link

This PR has been released as part of [email protected]. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant