-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure impure dependencies of pure modules are added #5669
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#fix-impure-dependencies-of-pure-modules Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5669 +/- ##
=======================================
Coverage 99.39% 99.39%
=======================================
Files 242 242
Lines 9346 9350 +4
Branches 2470 2471 +1
=======================================
+ Hits 9289 9293 +4
Misses 48 48
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Performance report!Rough benchmark
Internal benchmark
|
This PR has been released as part of [email protected]. Note that this is a pre-release, so to test it, you need to install Rollup via |
This PR has been released as part of [email protected]. You can test it via |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
Description
I think this is the bug of the original implementation, I missed impure dependencies of pure modules...