fix: watch overwrite rename event on linux #7201

sapphi-red · 2025-11-23T09:25:16Z

requires rolldown/notify#21, rolldown/notify#22

sapphi-red · 2025-11-23T09:25:33Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-11-23T09:26:05Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`b95575a`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69269d8f4d528000087255af

github-actions · 2025-11-23T14:22:22Z

Benchmarks Rust

target: main(18973cd)
pr: 11-23-fix_watch_overwrite_rename_event_on_linux(b95575a)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     62.1±1.32ms        ? ?/sec    1.00     62.3±1.39ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     68.8±1.49ms        ? ?/sec    1.01     69.2±1.60ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    104.9±1.35ms        ? ?/sec    1.01    106.3±2.17ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    118.1±4.05ms        ? ?/sec    1.01    119.5±2.75ms        ? ?/sec
bundle/bundle@threejs                                        1.00     38.8±0.71ms        ? ?/sec    1.03     39.9±2.37ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     42.5±1.43ms        ? ?/sec    1.00     42.2±0.74ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    387.8±5.10ms        ? ?/sec    1.01    390.8±7.74ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    446.3±2.81ms        ? ?/sec    1.00    447.4±4.01ms        ? ?/sec
scan/scan@rome_ts                                            1.00     83.9±1.48ms        ? ?/sec    1.00     84.2±1.52ms        ? ?/sec
scan/scan@threejs                                            1.01     28.5±0.95ms        ? ?/sec    1.00     28.3±0.40ms        ? ?/sec
scan/scan@threejs10x                                         1.01    295.7±5.88ms        ? ?/sec    1.00    293.6±3.86ms        ? ?/sec

sapphi-red · 2025-11-23T15:19:06Z

The CI passed locally with mac and WSL so I have to investigate later on CI...

Copilot

Pull request overview

This PR fixes watch mode rename event handling on Linux by upgrading the notify library and utilizing its new TrackPath target mode. The changes update from notify 8.x to 9.x, which introduces a new WatchMode API that requires both a recursive mode and a target mode. By using TargetMode::TrackPath, the watcher can now properly track files even when they are renamed, addressing issues #6846 and #2634.

Key changes:

Upgraded rolldown-notify from 8.x to 9.1.0 and rolldown-notify-debouncer-full from 0.6.x to 0.7.1
Updated all watcher implementations to use the new WatchMode API with TargetMode::TrackPath
Added handling for RenameMode::To events to treat file renames as updates
Removed redundant notify_watch_files tracking that the new notify API handles internally

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/rolldown_fs_watcher/src/utils.rs	Updated adapter to construct `WatchMode` with `TrackPath` target mode when adding watched paths
crates/rolldown_fs_watcher/src/recommended_fs_watcher.rs	Updated `watch()` to use new `WatchMode` API with `TrackPath` target mode
crates/rolldown_fs_watcher/src/poll_fs_watcher.rs	Updated `watch()` to use new `WatchMode` API with `TrackPath` target mode
crates/rolldown_fs_watcher/src/debounced_recommended_fs_watcher.rs	Updated `watch()` to use new `WatchMode` API with `TrackPath` target mode
crates/rolldown_fs_watcher/src/debounced_poll_fs_watcher.rs	Updated `watch()` to use new `WatchMode` API with `TrackPath` target mode
crates/rolldown/src/watch/watcher_task.rs	Removed redundant file tracking field and logic; updated to use `WatchMode::non_recursive()`
crates/rolldown/src/watch/watcher.rs	Added `RenameMode::To` event handling to treat renames as update events
Cargo.toml	Updated notify dependencies to versions 9.1.0 and 0.7.1
Cargo.lock	Lockfile updates reflecting new dependency versions

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

graphite-app · 2025-11-26T06:25:57Z

Merge activity

Nov 26, 6:25 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
Nov 26, 6:42 AM UTC: Merged by the Graphite merge queue.

fixes #6846, fixes #2634 requires rolldown/notify#21, rolldown/notify#22

@shulaoda

## [1.0.0-beta.52] - 2025-11-26 💥 Breaking Change - Change `output.generatedCode.profilerNames` default to `false` 🔧 Vite-Style TypeScript Configuration - Rolldown now supports Vite-style automatic tsconfig resolution. Use `tsconfig: true` to enable auto-discovery mode where each module finds its nearest `tsconfig.json`. See more details [here](https://rolldown.rs/options/tsconfig) ⚙️ Upgraded to oxc v0.99.0 - Add `TSGlobalDeclaration` type - More details: https://github.com/oxc-project/oxc/releases/tag/crates_v0.99.0 ### 💥 BREAKING CHANGES - change `output.generatedCode.profilerNames` default to false (#7139) by @Copilot ### 🚀 Features - support vite-style tsconfig resolution (#6873) by @shulaoda - rolldown: oxc v0.99.0 (#7165) by @camc314 - browser: export `plugins` (#7210) by @sxzz - rolldown_plugin_vite_css_post: add `inline` parameter to `cssMinify` callback (#7191) by @shulaoda - rolldown_plugin_vite_build_import_analysis: implement `render_chunk` to replace `__VITE_IS_MODERN__` flag (#7178) by @shulaoda - rolldown_plugin_utils: optimize SVG data URL encoding (#7156) by @shulaoda - dev: replace `DevEngine::hasLatestBuildOutput` with `DevEngine::getBundleState` (#7145) by @sapphi-red - rolldown_plugin_vite_asset_import_meta_url: support `@vite-ignore` comment (#7141) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement static URL processing (#7140) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: align `asset_resolver` logic (#7137) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: align `try_fs_resolve` logic (#7136) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: validate relative paths (#7120) by @shulaoda - export `viteAssetImportMetaUrlPlugin` and add dynamic URL tests (#7119) by @shulaoda ### 🐛 Bug Fixes - watch overwrite rename event on linux (#7201) by @sapphi-red - preserve name for parenthesized anonymous default exports and arrow functions with keepNames (#7159) by @Copilot - rolldown_plugin_vite_html: add missing async attribute for inlined entry scripts (#7202) by @shulaoda - respect target setting in DCE to prevent modern syntax generation (#7128) by @Copilot - rolldown_plugin_vite_html: add semicolon to import statement in CSS removal (#7200) by @shulaoda - rolldown_plugin_vite_html: use correct CSS asset filename in HTML injection (#7199) by @shulaoda - rolldown_plugin_vite_css_post: handle scoped package names in lib CSS filename (#7198) by @shulaoda - rolldown_plugin_vite_html: use patched `html5gum` with correct span tracking (#7193) by @shulaoda - rolldown_plugin_vite_html: handle HTML strings in script tags correctly (#7192) by @shulaoda - handle JSON import namespace property access correctly (#7190) by @IWANABETHATGUY - only include runtime helpers from included modules (#7183) by @IWANABETHATGUY - rolldown_plugin_vite_html: normalize paths to use forward slashes in `original_file_name` (#7175) by @shulaoda - rolldown_plugin_vite_css_post: use `filename` instead of `reference_id` for imported assets (#7174) by @shulaoda - rolldown_plugin_vite_css_post: correct regex escaping in pure CSS chunk pruning (#7173) by @shulaoda - rolldown_plugin_vite_html: use correct dependency path for modulepreload links (#7172) by @shulaoda - update cur_stmt_index when processing top level statements (#7157) by @IWANABETHATGUY - rolldown_plugin_utils: strip leading character from public asset URL (#7170) by @shulaoda - rolldown_plugin_vite_html: use correct `public_base` for `html_result_map` key (#7169) by @shulaoda - rolldown_plugin_utils: correct runtime handling and escape single quotes in asset paths (#7168) by @shulaoda - rolldown_plugin_utils: prevent data race in `file_to_url` cache (#7166) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: correct glob pattern and query string handling in dynamic URLs (#7162) by @shulaoda - rolldown_plugin_vite_css_post: use correct start position in magic string updates (#7158) by @shulaoda - data race in `FileEmitter::emit_file` causing duplicate asset emissions (#7164) by @shulaoda - dev: watch files even if the build failed (#7149) by @sapphi-red - rolldown_plugin_utils: always use base64 encoding for data URLs (#7148) by @shulaoda - preserve "default" name for anonymous default exports with keepNames (#7151) by @Copilot - correctly handle cjs json module as entry point (#7147) by @IWANABETHATGUY - rolldown_plugin_utils: correct `reference_id` parsing in `render_asset_url_in_js` (#7143) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: exclude quotes from URL span (#7142) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: use template literal for glob result indexing (#7134) by @shulaoda - tree shake unused dynamic entry when `inlineDynamicImports` is enabled (#7129) by @IWANABETHATGUY - correct return value of `parse` / `parseSync` functions (#7127) by @sapphi-red ### 🚜 Refactor - rolldown_plugin_vite_transform: use `oxc_resolver` for tsconfig discovery (#7220) by @shulaoda - rolldown_plugin_vite_resolve: use `resolve_file` for tsconfig discovery (#7216) by @shulaoda - rolldown_plugin_utils: remove redundant `ViteMetadata::get_or_insert_default()` (#7189) by @shulaoda - rolldown_plugin_utils: simplify `ViteMetadata::get()` to always return a value (#7188) by @shulaoda - rolldown_utils: add `guess_mime_skip_utf8_check` for binary assets (#7161) by @shulaoda - rolldown_plugin_utils: extract asset URL parsing into `AssetUrlIter` (#7144) by @shulaoda - store pattern name in FilenameTemplate (#7132) by @IWANABETHATGUY ### 📚 Documentation - tsconfig: document auto-discovery mode and improve structure (#7228) by @shulaoda - add plugin hook filter compatibility and fallback guide (#7138) by @Copilot - update top level navigation (#7092) by @mdong1909 ### 🧪 Testing - add tsconfig include/exclude/files matching test cases (#6899) by @shulaoda - vite-tests: run `playwright install` in case playwright binary is missing (#7226) by @sapphi-red - watch: close watcher when an error occured in the test cases (#7225) by @sapphi-red - watch: reject `waitBuildFinished` if `ERROR` event occurs (#7224) by @sapphi-red ### ⚙️ Miscellaneous Tasks - example: revert accidental changes to basic-typescript (#7227) by @shulaoda - deps: update oxc apps (#7212) by @renovate[bot] - deps: update rust crates (#7204) by @renovate[bot] - deps: update `oxc_resolver_napi` to 11.14.0 (#7217) by @shulaoda - deps: update oxc_resolver (#6909) by @shulaoda - deps: update dependency glob to v13 (#7208) by @renovate[bot] - deps: update actions/checkout action to v6 (#7207) by @renovate[bot] - deps: update npm packages (#7206) by @renovate[bot] - deps: update github-actions (#7205) by @renovate[bot] - add missing status code comment (#7185) by @iiio2 - deps: update dependency oxlint-tsgolint to v0.8.1 (#7197) by @renovate[bot] - rust: add more tracing log for hmr + dev logic (#7179) by @hyf0 - deps: update dependency oxlint-tsgolint to v0.8.0 (#7167) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.7.3 (#7133) by @renovate[bot] - merge similar inlineDynamicImports test case (#7131) by @IWANABETHATGUY - deps: update `rolldown-plugin-dts` to 0.18.0 (#7125) by @shulaoda Co-authored-by: shulaoda <[email protected]>

sapphi-red force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from 6e49c92 to 22ee9c1 Compare November 23, 2025 14:07

sapphi-red force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from 22ee9c1 to 8e423ff Compare November 23, 2025 15:03

sapphi-red mentioned this pull request Nov 23, 2025

chore(deps): update rust crate rolldown-notify to v9 #7209

Closed

1 task

sapphi-red force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from 8e423ff to d5293a5 Compare November 25, 2025 05:59

sapphi-red mentioned this pull request Nov 25, 2025

wip: debug CI failure for notify upgrade #7213

Closed

sapphi-red changed the base branch from main to graphite-base/7201 November 26, 2025 02:42

sapphi-red force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from d5293a5 to cd2c277 Compare November 26, 2025 02:42

sapphi-red changed the base branch from graphite-base/7201 to 11-26-test_watch_close_watcher_when_an_error_occured_in_the_test_cases November 26, 2025 02:42

This was referenced Nov 26, 2025

test(watch): reject waitBuildFinished if ERROR event occurs #7224

Merged

test(watch): close watcher when an error occured in the test cases #7225

Merged

sapphi-red force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from cd2c277 to 5442f4a Compare November 26, 2025 03:08

graphite-app bot changed the base branch from 11-26-test_watch_close_watcher_when_an_error_occured_in_the_test_cases to graphite-base/7201 November 26, 2025 03:31

sapphi-red requested a review from hyf0 November 26, 2025 03:34

sapphi-red self-assigned this Nov 26, 2025

sapphi-red marked this pull request as ready for review November 26, 2025 03:34

graphite-app bot force-pushed the graphite-base/7201 branch from f9405ef to 53ebdb0 Compare November 26, 2025 03:57

graphite-app bot force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from 5442f4a to 8cdf28b Compare November 26, 2025 03:57

graphite-app bot changed the base branch from graphite-base/7201 to main November 26, 2025 03:57

graphite-app bot force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from 8cdf28b to 4234da1 Compare November 26, 2025 03:58

Copilot AI review requested due to automatic review settings November 26, 2025 05:48

sapphi-red force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from 4234da1 to cb060ed Compare November 26, 2025 05:48

Copilot started reviewing on behalf of sapphi-red November 26, 2025 05:49 View session

Copilot finished reviewing on behalf of sapphi-red November 26, 2025 05:52

Copilot AI reviewed Nov 26, 2025

View reviewed changes

hyf0 approved these changes Nov 26, 2025

View reviewed changes

fix: watch overwrite rename event on linux (#7201)

b95575a

fixes #6846, fixes #2634 requires rolldown/notify#21, rolldown/notify#22

graphite-app bot force-pushed the 11-23-fix_watch_overwrite_rename_event_on_linux branch from cb060ed to b95575a Compare November 26, 2025 06:26

graphite-app bot merged commit b95575a into main Nov 26, 2025
29 checks passed

graphite-app bot deleted the 11-23-fix_watch_overwrite_rename_event_on_linux branch November 26, 2025 06:42

github-actions bot mentioned this pull request Nov 26, 2025

release: v1.0.0-beta.52 #7229

Merged

This was referenced Nov 26, 2025

[Bug]: Watch runs once on save on Linux #6846

Closed

fix(watch): correctly handle vim's write-via-rename #4869

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: watch overwrite rename event on linux #7201

fix: watch overwrite rename event on linux #7201

Uh oh!

sapphi-red commented Nov 23, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Nov 23, 2025 •

edited

Loading

Uh oh!

netlify bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 23, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Nov 23, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

graphite-app bot commented Nov 26, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: watch overwrite rename event on linux #7201

fix: watch overwrite rename event on linux #7201

Uh oh!

Conversation

sapphi-red commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sapphi-red commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

github-actions bot commented Nov 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

sapphi-red commented Nov 23, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

graphite-app bot commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sapphi-red commented Nov 23, 2025 •

edited

Loading

sapphi-red commented Nov 23, 2025 •

edited

Loading

netlify bot commented Nov 23, 2025 •

edited

Loading

github-actions bot commented Nov 23, 2025 •

edited

Loading

graphite-app bot commented Nov 26, 2025 •

edited

Loading