fix: handle JSON import namespace property access correctly #7190

IWANABETHATGUY · 2025-11-22T04:02:18Z

No description provided.

IWANABETHATGUY · 2025-11-22T04:02:35Z

fix: handle JSON import namespace property access correctly #7190 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-11-22T04:03:14Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`06bb95d`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69214669bb6f82000864350e

Copilot

Pull request overview

This PR fixes the handling of property access on JSON import namespaces when accessing undefined properties. Previously, when accessing a non-existent property on a JSON import (e.g., foo.flat() where foo is a JSON import), the bundler would incorrectly convert it to void 0 instead of preserving the reference to allow runtime property access on the JSON default export.

Key Changes

Introduced is_json_import_ns flag to detect JSON module default imports being accessed via member expressions
Modified property resolution logic to preserve the canonical reference for JSON imports even when accessing undefined properties
Ensured appropriate warnings are still generated for undefined property access on JSON imports

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/rolldown/src/stages/link_stage/bind_imports_and_exports.rs`	Core fix - adds special handling for JSON import namespace property access to preserve the default export reference instead of converting to `void 0`
`crates/rolldown/tests/rolldown/tree_shaking/json_undefined_property/main.js`	Test case demonstrating accessing undefined property (`.flat()`) on JSON array import
`crates/rolldown/tests/rolldown/tree_shaking/json_undefined_property/foo.json`	Test fixture - JSON array `[[1, 2]]`
`crates/rolldown/tests/rolldown/tree_shaking/json_undefined_property/artifacts.snap`	Expected output showing warning for undefined import and correct runtime behavior with `foo_default.flat()`
`crates/rolldown/tests/rolldown/tree_shaking/json_undefined_property/_config.json`	Test configuration
`crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap`	Updated snapshot including hash for new test

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown/src/stages/link_stage/bind_imports_and_exports.rs

github-actions · 2025-11-22T04:30:17Z

Benchmarks Rust

target: main(bfe60f1)
pr: 11-22-fix_7186(06bb95d)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.03     66.9±1.67ms        ? ?/sec    1.00     64.9±5.46ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     71.7±1.81ms        ? ?/sec    1.00     70.1±1.74ms        ? ?/sec
bundle/bundle@rome_ts                                        1.03    106.7±2.28ms        ? ?/sec    1.00    103.9±1.57ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.02    120.0±1.66ms        ? ?/sec    1.00    118.1±1.74ms        ? ?/sec
bundle/bundle@threejs                                        1.01     40.0±2.58ms        ? ?/sec    1.00     39.4±0.69ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.8±0.79ms        ? ?/sec    1.00     43.6±0.51ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    394.9±5.06ms        ? ?/sec    1.00    390.5±7.34ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    461.8±4.84ms        ? ?/sec    1.00    456.9±4.49ms        ? ?/sec
scan/scan@rome_ts                                            1.00     81.4±1.33ms        ? ?/sec    1.00     81.3±1.18ms        ? ?/sec
scan/scan@threejs                                            1.00     28.2±1.82ms        ? ?/sec    1.00     28.2±1.69ms        ? ?/sec
scan/scan@threejs10x                                         1.00    283.3±3.11ms        ? ?/sec    1.00    284.2±5.54ms        ? ?/sec

graphite-app · 2025-11-22T05:12:35Z

Merge activity

Nov 22, 5:12 AM UTC: IWANABETHATGUY added this pull request to the Graphite merge queue.
Nov 22, 5:26 AM UTC: Merged by the Graphite merge queue.

@shulaoda

## [1.0.0-beta.52] - 2025-11-26 💥 Breaking Change - Change `output.generatedCode.profilerNames` default to `false` 🔧 Vite-Style TypeScript Configuration - Rolldown now supports Vite-style automatic tsconfig resolution. Use `tsconfig: true` to enable auto-discovery mode where each module finds its nearest `tsconfig.json`. See more details [here](https://rolldown.rs/options/tsconfig) ⚙️ Upgraded to oxc v0.99.0 - Add `TSGlobalDeclaration` type - More details: https://github.com/oxc-project/oxc/releases/tag/crates_v0.99.0 ### 💥 BREAKING CHANGES - change `output.generatedCode.profilerNames` default to false (#7139) by @Copilot ### 🚀 Features - support vite-style tsconfig resolution (#6873) by @shulaoda - rolldown: oxc v0.99.0 (#7165) by @camc314 - browser: export `plugins` (#7210) by @sxzz - rolldown_plugin_vite_css_post: add `inline` parameter to `cssMinify` callback (#7191) by @shulaoda - rolldown_plugin_vite_build_import_analysis: implement `render_chunk` to replace `__VITE_IS_MODERN__` flag (#7178) by @shulaoda - rolldown_plugin_utils: optimize SVG data URL encoding (#7156) by @shulaoda - dev: replace `DevEngine::hasLatestBuildOutput` with `DevEngine::getBundleState` (#7145) by @sapphi-red - rolldown_plugin_vite_asset_import_meta_url: support `@vite-ignore` comment (#7141) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement static URL processing (#7140) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: align `asset_resolver` logic (#7137) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: align `try_fs_resolve` logic (#7136) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: validate relative paths (#7120) by @shulaoda - export `viteAssetImportMetaUrlPlugin` and add dynamic URL tests (#7119) by @shulaoda ### 🐛 Bug Fixes - watch overwrite rename event on linux (#7201) by @sapphi-red - preserve name for parenthesized anonymous default exports and arrow functions with keepNames (#7159) by @Copilot - rolldown_plugin_vite_html: add missing async attribute for inlined entry scripts (#7202) by @shulaoda - respect target setting in DCE to prevent modern syntax generation (#7128) by @Copilot - rolldown_plugin_vite_html: add semicolon to import statement in CSS removal (#7200) by @shulaoda - rolldown_plugin_vite_html: use correct CSS asset filename in HTML injection (#7199) by @shulaoda - rolldown_plugin_vite_css_post: handle scoped package names in lib CSS filename (#7198) by @shulaoda - rolldown_plugin_vite_html: use patched `html5gum` with correct span tracking (#7193) by @shulaoda - rolldown_plugin_vite_html: handle HTML strings in script tags correctly (#7192) by @shulaoda - handle JSON import namespace property access correctly (#7190) by @IWANABETHATGUY - only include runtime helpers from included modules (#7183) by @IWANABETHATGUY - rolldown_plugin_vite_html: normalize paths to use forward slashes in `original_file_name` (#7175) by @shulaoda - rolldown_plugin_vite_css_post: use `filename` instead of `reference_id` for imported assets (#7174) by @shulaoda - rolldown_plugin_vite_css_post: correct regex escaping in pure CSS chunk pruning (#7173) by @shulaoda - rolldown_plugin_vite_html: use correct dependency path for modulepreload links (#7172) by @shulaoda - update cur_stmt_index when processing top level statements (#7157) by @IWANABETHATGUY - rolldown_plugin_utils: strip leading character from public asset URL (#7170) by @shulaoda - rolldown_plugin_vite_html: use correct `public_base` for `html_result_map` key (#7169) by @shulaoda - rolldown_plugin_utils: correct runtime handling and escape single quotes in asset paths (#7168) by @shulaoda - rolldown_plugin_utils: prevent data race in `file_to_url` cache (#7166) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: correct glob pattern and query string handling in dynamic URLs (#7162) by @shulaoda - rolldown_plugin_vite_css_post: use correct start position in magic string updates (#7158) by @shulaoda - data race in `FileEmitter::emit_file` causing duplicate asset emissions (#7164) by @shulaoda - dev: watch files even if the build failed (#7149) by @sapphi-red - rolldown_plugin_utils: always use base64 encoding for data URLs (#7148) by @shulaoda - preserve "default" name for anonymous default exports with keepNames (#7151) by @Copilot - correctly handle cjs json module as entry point (#7147) by @IWANABETHATGUY - rolldown_plugin_utils: correct `reference_id` parsing in `render_asset_url_in_js` (#7143) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: exclude quotes from URL span (#7142) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: use template literal for glob result indexing (#7134) by @shulaoda - tree shake unused dynamic entry when `inlineDynamicImports` is enabled (#7129) by @IWANABETHATGUY - correct return value of `parse` / `parseSync` functions (#7127) by @sapphi-red ### 🚜 Refactor - rolldown_plugin_vite_transform: use `oxc_resolver` for tsconfig discovery (#7220) by @shulaoda - rolldown_plugin_vite_resolve: use `resolve_file` for tsconfig discovery (#7216) by @shulaoda - rolldown_plugin_utils: remove redundant `ViteMetadata::get_or_insert_default()` (#7189) by @shulaoda - rolldown_plugin_utils: simplify `ViteMetadata::get()` to always return a value (#7188) by @shulaoda - rolldown_utils: add `guess_mime_skip_utf8_check` for binary assets (#7161) by @shulaoda - rolldown_plugin_utils: extract asset URL parsing into `AssetUrlIter` (#7144) by @shulaoda - store pattern name in FilenameTemplate (#7132) by @IWANABETHATGUY ### 📚 Documentation - tsconfig: document auto-discovery mode and improve structure (#7228) by @shulaoda - add plugin hook filter compatibility and fallback guide (#7138) by @Copilot - update top level navigation (#7092) by @mdong1909 ### 🧪 Testing - add tsconfig include/exclude/files matching test cases (#6899) by @shulaoda - vite-tests: run `playwright install` in case playwright binary is missing (#7226) by @sapphi-red - watch: close watcher when an error occured in the test cases (#7225) by @sapphi-red - watch: reject `waitBuildFinished` if `ERROR` event occurs (#7224) by @sapphi-red ### ⚙️ Miscellaneous Tasks - example: revert accidental changes to basic-typescript (#7227) by @shulaoda - deps: update oxc apps (#7212) by @renovate[bot] - deps: update rust crates (#7204) by @renovate[bot] - deps: update `oxc_resolver_napi` to 11.14.0 (#7217) by @shulaoda - deps: update oxc_resolver (#6909) by @shulaoda - deps: update dependency glob to v13 (#7208) by @renovate[bot] - deps: update actions/checkout action to v6 (#7207) by @renovate[bot] - deps: update npm packages (#7206) by @renovate[bot] - deps: update github-actions (#7205) by @renovate[bot] - add missing status code comment (#7185) by @iiio2 - deps: update dependency oxlint-tsgolint to v0.8.1 (#7197) by @renovate[bot] - rust: add more tracing log for hmr + dev logic (#7179) by @hyf0 - deps: update dependency oxlint-tsgolint to v0.8.0 (#7167) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.7.3 (#7133) by @renovate[bot] - merge similar inlineDynamicImports test case (#7131) by @IWANABETHATGUY - deps: update `rolldown-plugin-dts` to 0.18.0 (#7125) by @shulaoda Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned IWANABETHATGUY Nov 22, 2025

IWANABETHATGUY changed the title ~~fix: 7186~~ fix: handle JSON import namespace property access correctly Nov 22, 2025

IWANABETHATGUY marked this pull request as ready for review November 22, 2025 04:02

Copilot AI review requested due to automatic review settings November 22, 2025 04:02

Copilot started reviewing on behalf of IWANABETHATGUY November 22, 2025 04:03 View session

Copilot finished reviewing on behalf of IWANABETHATGUY November 22, 2025 04:04

hyf0 approved these changes Nov 22, 2025

View reviewed changes

Copilot AI reviewed Nov 22, 2025

View reviewed changes

IWANABETHATGUY force-pushed the 11-22-fix_7186 branch from 88b3b57 to 8e751e7 Compare November 22, 2025 04:06

Copilot AI review requested due to automatic review settings November 22, 2025 04:14

IWANABETHATGUY force-pushed the 11-22-fix_7186 branch from 8e751e7 to 22b19cf Compare November 22, 2025 04:14

Copilot started reviewing on behalf of IWANABETHATGUY November 22, 2025 04:15 View session

Copilot finished reviewing on behalf of IWANABETHATGUY November 22, 2025 04:17

Copilot AI reviewed Nov 22, 2025

View reviewed changes

crates/rolldown/src/stages/link_stage/bind_imports_and_exports.rs Show resolved Hide resolved

fix: handle JSON import namespace property access correctly (#7190)

06bb95d

graphite-app bot force-pushed the 11-22-fix_7186 branch from 22b19cf to 06bb95d Compare November 22, 2025 05:13

graphite-app bot merged commit 06bb95d into main Nov 22, 2025
28 checks passed

graphite-app bot deleted the 11-22-fix_7186 branch November 22, 2025 05:26

IWANABETHATGUY mentioned this pull request Nov 22, 2025

[Bug]: Imported JSON Array methods incorrectly transformed to void 0 #7186

Closed

This was referenced Nov 26, 2025

release: v1.0.0-beta.52 #7223

Closed

release: v1.0.0-beta.52 #7229

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: handle JSON import namespace property access correctly #7190

fix: handle JSON import namespace property access correctly #7190

Uh oh!

IWANABETHATGUY commented Nov 22, 2025

Uh oh!

IWANABETHATGUY commented Nov 22, 2025

Uh oh!

netlify bot commented Nov 22, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

github-actions bot commented Nov 22, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix: handle JSON import namespace property access correctly #7190

fix: handle JSON import namespace property access correctly #7190

Uh oh!

Conversation

IWANABETHATGUY commented Nov 22, 2025

Uh oh!

IWANABETHATGUY commented Nov 22, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

github-actions bot commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Nov 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Nov 22, 2025 •

edited

Loading

github-actions bot commented Nov 22, 2025 •

edited

Loading

graphite-app bot commented Nov 22, 2025 •

edited

Loading