fix(rolldown_plugin_utils): always use base64 encoding for data URLs #7148

shulaoda · 2025-11-20T08:51:50Z

No description provided.

shulaoda · 2025-11-20T08:52:05Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-11-20T08:52:41Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`b050087`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/691f244b1318270008396eed

github-actions · 2025-11-20T09:05:27Z

Benchmarks Rust

target: main(6ca52aa)
pr: 11-20-fix_rolldown_plugin_vite_asset_import_meta_url_escape_generated_urls_with_json_escaping(b050087)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     62.1±2.13ms        ? ?/sec    1.00     62.1±1.65ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     68.2±1.83ms        ? ?/sec    1.01     68.8±1.78ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    102.8±2.09ms        ? ?/sec    1.00    103.0±1.46ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    116.8±2.20ms        ? ?/sec    1.00    116.3±1.35ms        ? ?/sec
bundle/bundle@threejs                                        1.01     38.5±1.17ms        ? ?/sec    1.00     38.2±0.66ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.2±0.55ms        ? ?/sec    1.02     42.8±0.78ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    382.7±5.70ms        ? ?/sec    1.00    379.1±4.06ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    450.1±4.03ms        ? ?/sec    1.00    447.0±4.02ms        ? ?/sec
scan/scan@rome_ts                                            1.00     79.4±1.39ms        ? ?/sec    1.00     79.3±1.34ms        ? ?/sec
scan/scan@threejs                                            1.01     27.2±0.47ms        ? ?/sec    1.00     26.9±0.42ms        ? ?/sec
scan/scan@threejs10x                                         1.00    279.2±3.42ms        ? ?/sec    1.00    279.2±3.99ms        ? ?/sec

graphite-app · 2025-11-20T13:23:24Z

Merge activity

Nov 20, 1:23 PM UTC: shulaoda added this pull request to the Graphite merge queue.
Nov 20, 1:34 PM UTC: The Graphite merge queue couldn't merge this PR because it was in draft mode.
Nov 20, 2:22 PM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 20, 2:22 PM UTC: shulaoda added this pull request to the Graphite merge queue.
Nov 20, 2:37 PM UTC: Merged by the Graphite merge queue.

…s with JSON escaping (#7148)

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

…s with JSON escaping (#7148)

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_plugin_utils/src/file_to_url.rs

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…7148)

@shulaoda

## [1.0.0-beta.52] - 2025-11-26 💥 Breaking Change - Change `output.generatedCode.profilerNames` default to `false` 🔧 Vite-Style TypeScript Configuration - Rolldown now supports Vite-style automatic tsconfig resolution. Use `tsconfig: true` to enable auto-discovery mode where each module finds its nearest `tsconfig.json`. See more details [here](https://rolldown.rs/options/tsconfig) ⚙️ Upgraded to oxc v0.99.0 - Add `TSGlobalDeclaration` type - More details: https://github.com/oxc-project/oxc/releases/tag/crates_v0.99.0 ### 💥 BREAKING CHANGES - change `output.generatedCode.profilerNames` default to false (#7139) by @Copilot ### 🚀 Features - support vite-style tsconfig resolution (#6873) by @shulaoda - rolldown: oxc v0.99.0 (#7165) by @camc314 - browser: export `plugins` (#7210) by @sxzz - rolldown_plugin_vite_css_post: add `inline` parameter to `cssMinify` callback (#7191) by @shulaoda - rolldown_plugin_vite_build_import_analysis: implement `render_chunk` to replace `__VITE_IS_MODERN__` flag (#7178) by @shulaoda - rolldown_plugin_utils: optimize SVG data URL encoding (#7156) by @shulaoda - dev: replace `DevEngine::hasLatestBuildOutput` with `DevEngine::getBundleState` (#7145) by @sapphi-red - rolldown_plugin_vite_asset_import_meta_url: support `@vite-ignore` comment (#7141) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement static URL processing (#7140) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: align `asset_resolver` logic (#7137) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: align `try_fs_resolve` logic (#7136) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: validate relative paths (#7120) by @shulaoda - export `viteAssetImportMetaUrlPlugin` and add dynamic URL tests (#7119) by @shulaoda ### 🐛 Bug Fixes - watch overwrite rename event on linux (#7201) by @sapphi-red - preserve name for parenthesized anonymous default exports and arrow functions with keepNames (#7159) by @Copilot - rolldown_plugin_vite_html: add missing async attribute for inlined entry scripts (#7202) by @shulaoda - respect target setting in DCE to prevent modern syntax generation (#7128) by @Copilot - rolldown_plugin_vite_html: add semicolon to import statement in CSS removal (#7200) by @shulaoda - rolldown_plugin_vite_html: use correct CSS asset filename in HTML injection (#7199) by @shulaoda - rolldown_plugin_vite_css_post: handle scoped package names in lib CSS filename (#7198) by @shulaoda - rolldown_plugin_vite_html: use patched `html5gum` with correct span tracking (#7193) by @shulaoda - rolldown_plugin_vite_html: handle HTML strings in script tags correctly (#7192) by @shulaoda - handle JSON import namespace property access correctly (#7190) by @IWANABETHATGUY - only include runtime helpers from included modules (#7183) by @IWANABETHATGUY - rolldown_plugin_vite_html: normalize paths to use forward slashes in `original_file_name` (#7175) by @shulaoda - rolldown_plugin_vite_css_post: use `filename` instead of `reference_id` for imported assets (#7174) by @shulaoda - rolldown_plugin_vite_css_post: correct regex escaping in pure CSS chunk pruning (#7173) by @shulaoda - rolldown_plugin_vite_html: use correct dependency path for modulepreload links (#7172) by @shulaoda - update cur_stmt_index when processing top level statements (#7157) by @IWANABETHATGUY - rolldown_plugin_utils: strip leading character from public asset URL (#7170) by @shulaoda - rolldown_plugin_vite_html: use correct `public_base` for `html_result_map` key (#7169) by @shulaoda - rolldown_plugin_utils: correct runtime handling and escape single quotes in asset paths (#7168) by @shulaoda - rolldown_plugin_utils: prevent data race in `file_to_url` cache (#7166) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: correct glob pattern and query string handling in dynamic URLs (#7162) by @shulaoda - rolldown_plugin_vite_css_post: use correct start position in magic string updates (#7158) by @shulaoda - data race in `FileEmitter::emit_file` causing duplicate asset emissions (#7164) by @shulaoda - dev: watch files even if the build failed (#7149) by @sapphi-red - rolldown_plugin_utils: always use base64 encoding for data URLs (#7148) by @shulaoda - preserve "default" name for anonymous default exports with keepNames (#7151) by @Copilot - correctly handle cjs json module as entry point (#7147) by @IWANABETHATGUY - rolldown_plugin_utils: correct `reference_id` parsing in `render_asset_url_in_js` (#7143) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: exclude quotes from URL span (#7142) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: use template literal for glob result indexing (#7134) by @shulaoda - tree shake unused dynamic entry when `inlineDynamicImports` is enabled (#7129) by @IWANABETHATGUY - correct return value of `parse` / `parseSync` functions (#7127) by @sapphi-red ### 🚜 Refactor - rolldown_plugin_vite_transform: use `oxc_resolver` for tsconfig discovery (#7220) by @shulaoda - rolldown_plugin_vite_resolve: use `resolve_file` for tsconfig discovery (#7216) by @shulaoda - rolldown_plugin_utils: remove redundant `ViteMetadata::get_or_insert_default()` (#7189) by @shulaoda - rolldown_plugin_utils: simplify `ViteMetadata::get()` to always return a value (#7188) by @shulaoda - rolldown_utils: add `guess_mime_skip_utf8_check` for binary assets (#7161) by @shulaoda - rolldown_plugin_utils: extract asset URL parsing into `AssetUrlIter` (#7144) by @shulaoda - store pattern name in FilenameTemplate (#7132) by @IWANABETHATGUY ### 📚 Documentation - tsconfig: document auto-discovery mode and improve structure (#7228) by @shulaoda - add plugin hook filter compatibility and fallback guide (#7138) by @Copilot - update top level navigation (#7092) by @mdong1909 ### 🧪 Testing - add tsconfig include/exclude/files matching test cases (#6899) by @shulaoda - vite-tests: run `playwright install` in case playwright binary is missing (#7226) by @sapphi-red - watch: close watcher when an error occured in the test cases (#7225) by @sapphi-red - watch: reject `waitBuildFinished` if `ERROR` event occurs (#7224) by @sapphi-red ### ⚙️ Miscellaneous Tasks - example: revert accidental changes to basic-typescript (#7227) by @shulaoda - deps: update oxc apps (#7212) by @renovate[bot] - deps: update rust crates (#7204) by @renovate[bot] - deps: update `oxc_resolver_napi` to 11.14.0 (#7217) by @shulaoda - deps: update oxc_resolver (#6909) by @shulaoda - deps: update dependency glob to v13 (#7208) by @renovate[bot] - deps: update actions/checkout action to v6 (#7207) by @renovate[bot] - deps: update npm packages (#7206) by @renovate[bot] - deps: update github-actions (#7205) by @renovate[bot] - add missing status code comment (#7185) by @iiio2 - deps: update dependency oxlint-tsgolint to v0.8.1 (#7197) by @renovate[bot] - rust: add more tracing log for hmr + dev logic (#7179) by @hyf0 - deps: update dependency oxlint-tsgolint to v0.8.0 (#7167) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.7.3 (#7133) by @renovate[bot] - merge similar inlineDynamicImports test case (#7131) by @IWANABETHATGUY - deps: update `rolldown-plugin-dts` to 0.18.0 (#7125) by @shulaoda Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Nov 20, 2025

shulaoda marked this pull request as ready for review November 20, 2025 08:52

shulaoda requested review from IWANABETHATGUY, Copilot and hyf0 and removed request for Copilot November 20, 2025 08:52

Copilot started reviewing on behalf of shulaoda November 20, 2025 08:52 View session

Copilot finished reviewing on behalf of shulaoda November 20, 2025 08:55

IWANABETHATGUY approved these changes Nov 20, 2025

View reviewed changes

graphite-app bot pushed a commit that referenced this pull request Nov 20, 2025

fix(rolldown_plugin_vite_asset_import_meta_url): escape generated URL…

bc1ba7b

…s with JSON escaping (#7148)

Copilot AI review requested due to automatic review settings November 20, 2025 13:24

graphite-app bot force-pushed the 11-20-fix_rolldown_plugin_vite_asset_import_meta_url_escape_generated_urls_with_json_escaping branch from 07d7dd5 to bc1ba7b Compare November 20, 2025 13:24

Copilot AI reviewed Nov 20, 2025

View reviewed changes

shulaoda marked this pull request as draft November 20, 2025 13:34

shulaoda added a commit that referenced this pull request Nov 20, 2025

fix(rolldown_plugin_vite_asset_import_meta_url): escape generated URL…

9f59adb

…s with JSON escaping (#7148)

shulaoda force-pushed the 11-20-fix_rolldown_plugin_vite_asset_import_meta_url_escape_generated_urls_with_json_escaping branch from bc1ba7b to 9f59adb Compare November 20, 2025 13:36

shulaoda changed the title ~~fix(rolldown_plugin_vite_asset_import_meta_url): escape generated URLs with JSON escaping~~ fix(rolldown_plugin_utils): always use base64 encoding for data URLs Nov 20, 2025

shulaoda marked this pull request as ready for review November 20, 2025 13:36

Copilot AI review requested due to automatic review settings November 20, 2025 13:36

Copilot started reviewing on behalf of shulaoda November 20, 2025 13:37 View session

Copilot finished reviewing on behalf of shulaoda November 20, 2025 13:38

Copilot AI reviewed Nov 20, 2025

View reviewed changes

crates/rolldown_plugin_utils/src/file_to_url.rs Outdated Show resolved Hide resolved

Copilot AI review requested due to automatic review settings November 20, 2025 13:42

Copilot started reviewing on behalf of shulaoda November 20, 2025 13:43 View session

Copilot finished reviewing on behalf of shulaoda November 20, 2025 13:44

Copilot AI reviewed Nov 20, 2025

View reviewed changes

shulaoda added the graphite: merge label Nov 20, 2025

shulaoda mentioned this pull request Nov 20, 2025

feat(rolldown_plugin_utils): optimize SVG data URL encoding #7156

Merged

fix(rolldown_plugin_utils): always use base64 encoding for data URLs (#…

b050087

…7148)

graphite-app bot force-pushed the 11-20-fix_rolldown_plugin_vite_asset_import_meta_url_escape_generated_urls_with_json_escaping branch from d9d1b8e to b050087 Compare November 20, 2025 14:23

graphite-app bot merged commit b050087 into main Nov 20, 2025
28 checks passed

graphite-app bot deleted the 11-20-fix_rolldown_plugin_vite_asset_import_meta_url_escape_generated_urls_with_json_escaping branch November 20, 2025 14:37

graphite-app bot removed the graphite: merge label Nov 20, 2025

shulaoda mentioned this pull request Nov 20, 2025

fix(rolldown_plugin_vite_css_post): use correct start position in magic string updates #7158

Merged

IWANABETHATGUY pushed a commit that referenced this pull request Nov 20, 2025

fix(rolldown_plugin_utils): always use base64 encoding for data URLs (#…

41dbd1f

…7148)

IWANABETHATGUY added a commit that referenced this pull request Nov 20, 2025

fix(rolldown_plugin_utils): always use base64 encoding for data URLs (#…

02a73b1

…7148)

This was referenced Nov 20, 2025

refactor(rolldown_utils): add guess_mime_skip_utf8_check for binary assets #7161

Merged

fix(rolldown_plugin_vite_asset_import_meta_url): correct glob pattern and query string handling in dynamic URLs #7162

Merged

This was referenced Nov 26, 2025

release: v1.0.0-beta.52 #7223

Closed

release: v1.0.0-beta.52 #7229

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(rolldown_plugin_utils): always use base64 encoding for data URLs #7148

fix(rolldown_plugin_utils): always use base64 encoding for data URLs #7148

Uh oh!

shulaoda commented Nov 20, 2025

Uh oh!

shulaoda commented Nov 20, 2025 •

edited

Loading

Uh oh!

netlify bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 20, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(rolldown_plugin_utils): always use base64 encoding for data URLs #7148

fix(rolldown_plugin_utils): always use base64 encoding for data URLs #7148

Uh oh!

Conversation

shulaoda commented Nov 20, 2025

Uh oh!

shulaoda commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shulaoda commented Nov 20, 2025 •

edited

Loading

netlify bot commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading

graphite-app bot commented Nov 20, 2025 •

edited

Loading