fix(rolldown_plugin_vite_css_post): always compute css asset dirname in build command #7054

shulaoda · 2025-11-15T15:41:57Z

No description provided.

shulaoda · 2025-11-15T15:42:15Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-11-15T15:55:26Z

Benchmarks Rust

target: main(90eb426)
pr: 11-15-fix_rolldown_plugin_vite_css_post_always_compute_css_asset_dirname_in_build_command(aff376c)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.3±1.67ms        ? ?/sec    1.02     66.6±2.62ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     71.4±1.68ms        ? ?/sec    1.02     72.5±1.44ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    108.9±3.11ms        ? ?/sec    1.01    109.6±1.72ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    121.9±2.28ms        ? ?/sec    1.01    123.3±2.11ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.4±2.24ms        ? ?/sec    1.00     39.3±0.66ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.6±0.61ms        ? ?/sec    1.01     43.1±0.63ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    390.5±4.23ms        ? ?/sec    1.01    394.4±5.08ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    448.5±3.98ms        ? ?/sec    1.01    452.9±4.46ms        ? ?/sec
scan/scan@rome_ts                                            1.00     84.0±1.46ms        ? ?/sec    1.00     84.3±1.70ms        ? ?/sec
scan/scan@threejs                                            1.00     28.2±0.42ms        ? ?/sec    1.00     28.2±0.36ms        ? ?/sec
scan/scan@threejs10x                                         1.00    291.6±4.63ms        ? ?/sec    1.00    290.4±3.42ms        ? ?/sec

netlify · 2025-11-15T20:37:47Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`aff376c`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/6918f21571ed800008d4ad55

Copilot

Pull Request Overview

This PR fixes a potential runtime panic in the CSS post-processing plugin by ensuring the CSS asset directory name is always computed during the build command, regardless of the url_base configuration. This eliminates unsafe unwrap() calls in closures that could panic if the conditional logic changes in the future.

Key changes:

Always compute css_asset_dirname instead of conditionally computing it based on url_base
Change type from Option<String> to String and update references from as_ref().unwrap() to as_str()
Remove extraneous blank line for code cleanliness

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_plugin_vite_css_post/src/utils.rs

graphite-app · 2025-11-15T21:34:44Z

Merge activity

Nov 15, 9:34 PM UTC: shulaoda added this pull request to the Graphite merge queue.

…in build command (#7054)

@shulaoda

## [1.0.0-beta.51] - 2025-11-19 ### 💥 BREAKING CHANGES - rolldown_plugin_vite_react_refresh_wrapper: add vite prefix (#7086) by @shulaoda - rolldown_plugin_vite_web_worker_post: add vite prefix (#7085) by @shulaoda - rolldown_plugin_vite_wasm_helper: add vite prefix (#7084) by @shulaoda - rolldown_plugin_vite_wasm_fallback: add vite prefix (#7083) by @shulaoda - rolldown_plugin_vite_transform: add vite prefix (#7082) by @shulaoda - rolldown_plugin_vite_reporter: add vite prefix (#7081) by @shulaoda - rolldown_plugin_vite_module_preload_polyfill: add vite prefix (#7080) by @shulaoda - rolldown_plugin_vite_manifest: add vite prefix (#7079) by @shulaoda - rolldown_plugin_vite_load_fallback: add vite prefix (#7072) by @shulaoda - rolldown_plugin_vite_json: add vite prefix (#7071) by @shulaoda - rolldown_plugin_vite_import_glob: add vite prefix (#7070) by @shulaoda - rolldown_plugin_vite_html_inline_proxy: add vite prefix (#7069) by @shulaoda - rolldown_plugin_vite_dynamic_import_vars: add vite prefix (#7068) by @shulaoda - rolldown_plugin_vite_build_import_analysis: add vite prefix (#7067) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: add vite prefix (#7066) by @shulaoda - rolldown_plugin_vite_alias: add vite prefix (#7065) by @shulaoda - rolldown_plugin_vite_asset_plugin: add vite prefix (#7064) by @shulaoda ### 🚀 Features - export sync APIs to experimental (#7122) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement template literal support for dynamic URLs (#7118) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement AST-based URL detection (#7113) by @shulaoda - add isPathFragment validation for filename patterns (rollup compat) (#7101) by @IWANABETHATGUY - rolldown_plugin_vite_asset_import_meta_url: align filter logic (#7103) by @shulaoda - rolldown: oxc v0.98.0 (#6961) by @camc314 - show error contexts for unhandleable errors (#7095) by @sapphi-red - rolldown_plugin_utils: extract `get_hash` utility function (#7059) by @shulaoda - rolldown_plugin_asset: initialize `CSSEntriesCache` (#7015) by @shulaoda - rolldown_plugin_vite_html: align `transformIndexHtml` logic (#7010) by @shulaoda - builtin-plugin: support `bindingifyViteHtmlPlugin` (#7008) by @shulaoda - impl `generatedCode.symbols` for reexport dynamic modules. (#6993) by @IWANABETHATGUY - rolldown_plugin_manifest: support v2 logic (#6979) by @shulaoda - support Node.js `module.exports` ESM export (#6967) by @Copilot - change "could not clean directory" from error to warning (#6955) by @Copilot - rolldown_binding: add context to errors thrown by plugin hooks (#6964) by @sapphi-red ### 🐛 Bug Fixes - content hash should be affected by the minify behavior (#7102) by @hyf0 - `canonical name not found for "__toESM"` error when only named imports are used from a CJS module (#7094) by @sapphi-red - preserve directory structure in chunk names with preserveModules (#6872) by @IWANABETHATGUY - rolldown_plugin_asset: correct bundle deletion index calculation (#7063) by @shulaoda - rolldown_plugin_utils: correct string slicing in `render_asset_url_in_js` (#7061) by @shulaoda - rolldown_plugin_vite_html: use transformed result in asset URL handling (#7060) by @shulaoda - rolldown_plugin_vite_html: skip redundant path resolution for processed URLs (#7058) by @shulaoda - rolldown_plugin_vite_css_post: data race in CSS URL processing (#7055) by @shulaoda - rolldown_plugin_vite_css_post: always compute css asset dirname in build command (#7054) by @shulaoda - rolldown_plugin_vite_css: ensure consistent url in import and export (#7053) by @shulaoda - rolldown_plugin_vite_css_post: use `get_or_insert_default` for `HTMLProxyResult` (#7052) by @shulaoda - rolldown_plugin_vite_css: skip `commonjs-proxy` CSS requests (#7050) by @shulaoda - rolldown_plugin_utils: correct `is_css_module` (#7049) by @shulaoda - rolldown_plugin_utils: correct `is_css_request` (#7048) by @shulaoda - rolldown_plugin_vite_html: use correct inline module index (#7046) by @shulaoda - rolldown_plugin_vite_html: correct scripts url update logic (#7045) by @shulaoda - rolldown_plugin_vite_html: fallback to original url on NotFound error (#7043) by @shulaoda - rolldown_plugin_vite_html: move src_tasks to correct branch (#7040) by @shulaoda - rolldown_plugin_vite_html: correct `handle_style_tag_or_attribute` (#7038) by @shulaoda - builtin-plugin: add `config` to `htmlInlineProxyPlugin` (#7036) by @shulaoda - missing CJS default export when SafelyMergeCjsNs optimization is enabled (#7006) by @Copilot - reserve global names before deconflicting external symbols (#7022) by @IWANABETHATGUY - rolldown_plugin_build_import_analysis: process all bundle outputs correctly (#7020) by @shulaoda - rolldown_plugin_vite_css_post: process all bundle outputs correctly (#7019) by @shulaoda - rolldown_plugin_vite_css_post: remove `/*$vite$:1*/` correctly (#7018) by @shulaoda - rolldown_plugin_vite_html: use correct span for `style_urls` (#7017) by @shulaoda - rolldown_plugin_vite_html: track full element span from start to end tag (#7016) by @shulaoda - builtin-plugin: correct `viteHtmlPlugin` related logic (#7013) by @shulaoda - remove unused module namespace object exporting (#7002) by @IWANABETHATGUY - rust/dev: allow to recover from hmr rebuild failure (#6991) by @hyf0 - rust/dev: `ensure_latest_bundle_output` shouldn't loop infinitely (#6974) by @hyf0 - rust/dev: `DevEngine#ensure_latest_bundle_output` should schedule a rebuild task if there're no queued tasks (#6968) by @hyf0 - add Symbol.toStringTag to module facades when generatedCode.symbols is enabled (#6784) by @Copilot ### 🚜 Refactor - extension checking to use constant array (#7057) by @Copilot - rust/devtools: tweak namings and introduction comments (#7028) by @hyf0 - rolldown_plugin_vite_html: use `root` instead of `cwd` (#7035) by @shulaoda - rolldown_plugin_vite_css_post: use `root` instead of `cwd` (#7034) by @shulaoda - rolldown_plugin_vite_css: use `root` instead of `cwd` (#7033) by @shulaoda - rolldown_plugin_transform: use `root` instead of `cwd` (#7032) by @shulaoda - rolldown_plugin_reporter: use `root` instead of `cwd` (#7031) by @shulaoda - rolldown_plugin_asset: use `root` instead of `cwd` (#7030) by @shulaoda - rolldown_plugin_html_inline_proxy: use `root` instead of `cwd` (#7029) by @shulaoda - rust/dev: remove dead code of `rolldown_dev` crate (#6997) by @hyf0 - rust: move dev related code into new `rolldown_dev` crate (#6996) by @hyf0 - rolldown_resolver: use consistent generic parameter name `Fs` (#6998) by @shulaoda - rolldown_resolver: improve resolve method clarity and documentation (#6986) by @shulaoda - rename `is_module_facade()` to `is_entry_point()` for clarity (#6994) by @IWANABETHATGUY - rust/dev: unwrap `Result<_>` from the return type of `BundleCoordinator::schedule_build_if_stale` (#6980) by @sapphi-red - rolldown_resolver: reorganize impl blocks (#6984) by @shulaoda - rolldown_resolver: extract configuration logic into separate module (#6983) by @shulaoda - rolldown_resolver: improve error messages (#6982) by @shulaoda - rust/dev: rename `CoordinatorStatus` to `CoordinatorStateSnapshot` (#6973) by @hyf0 - rust/dev: replace `InitialBuildState` with `CoordinatorState` (#6972) by @hyf0 - ast_scanner: derive `Debug`, `Clone`, `Copy` for `CjsGlobalAssignmentType` (#6971) by @camc314 - rust: filter out devtools specific events for normal tracing (#6965) by @hyf0 - rust/dev: replace `CoordinatorMsg::HasLatestBuildOutput` with `GetStatus` (#6960) by @hyf0 - rust/dev: `ensure_current_build_finish` shouldn't block the coordinator's event loop (#6959) by @hyf0 ### 📚 Documentation - in-depth/directives: remove TODOs and fix code (#7112) by @sapphi-red - clarify concepts of rolldown's test infra (#7047) by @hyf0 - contrib/style: add suggestions about choosing file names (#6989) by @hyf0 ### ⚡ Performance - rolldown_plugin_vite_css_post: cache CSS URL processing results (#7056) by @shulaoda - remove unnecessary `collect_vec` (#6999) by @IWANABETHATGUY ### 🧪 Testing - add testcase for #6880 and #6879 (#7107) by @IWANABETHATGUY - vite-tests: use integration branch for vite compatibility tests (#7091) by @shulaoda ### ⚙️ Miscellaneous Tasks - remove redundant chunk level linefeed (#7109) by @IWANABETHATGUY - pin oxc-minify to 0.97.0 (#7108) by @IWANABETHATGUY - deps: update oxc apps (#7104) by @renovate[bot] - deps: update glob for security (#7105) by @shulaoda - rolldown: add aliases for renamed vite plugins (#7087) by @shulaoda - automate weekly beta releases (#7089) by @Boshen - deps: update dependency oxlint-tsgolint to v0.7.0 (#7088) by @renovate[bot] - deps: update github-actions (#7075) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.6.0 (#7037) by @renovate[bot] - deps: update npm packages (#7076) by @renovate[bot] - deps: update rust crates (#7077) by @renovate[bot] - add retry to flaky tests (#7041) by @sapphi-red - rust: rename `rolldown_debug` to `rolldown_devtools` (#7026) by @hyf0 - deps: update crate-ci/typos action to v1.39.2 (#7001) by @renovate[bot] - ai/github: make copilot review check rust api style (#6988) by @hyf0 - move test `recover_from_initial_build_error` to `error_recovery/from_initial_build_syntax_error` (#6990) by @hyf0 - oxlint: enable `typescript/consistent-type-imports` rule (#6987) by @shulaoda - deps: update crate-ci/typos action to v1.39.1 (#6975) by @renovate[bot] - build.ts: separate import type (#6921) by @iiio2 - format rolldown runtime (#6966) by @IWANABETHATGUY Co-authored-by: shulaoda <[email protected]>

shulaoda mentioned this pull request Nov 15, 2025

fix(rolldown_plugin_vite_css): ensure consistent url in import and export #7053

Merged

github-actions bot assigned shulaoda Nov 15, 2025

shulaoda mentioned this pull request Nov 15, 2025

fix(rolldown_plugin_vite_css_post): use get_or_insert_default for HTMLProxyResult #7052

Merged

shulaoda requested review from IWANABETHATGUY and hyf0 November 15, 2025 15:42

shulaoda marked this pull request as ready for review November 15, 2025 15:42

shulaoda force-pushed the 11-15-fix_rolldown_plugin_vite_css_ensure_consistent_url_in_import_and_export branch from 2b9cdfb to ceac9ed Compare November 15, 2025 16:14

shulaoda force-pushed the 11-15-fix_rolldown_plugin_vite_css_post_always_compute_css_asset_dirname_in_build_command branch from 471cfcd to eeb2593 Compare November 15, 2025 16:14

This was referenced Nov 15, 2025

fix(rolldown_plugin_vite_css_post): data race in CSS URL processing #7055

Merged

perf(rolldown_plugin_vite_css_post): cache CSS URL processing results #7056

Merged

Base automatically changed from 11-15-fix_rolldown_plugin_vite_css_ensure_consistent_url_in_import_and_export to main November 15, 2025 16:45

hyf0 approved these changes Nov 15, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 15, 2025 20:37

shulaoda force-pushed the 11-15-fix_rolldown_plugin_vite_css_post_always_compute_css_asset_dirname_in_build_command branch from eeb2593 to 43bf109 Compare November 15, 2025 20:37

Copilot started reviewing on behalf of shulaoda November 15, 2025 20:37 View session

Copilot finished reviewing on behalf of shulaoda November 15, 2025 20:38

Copilot AI reviewed Nov 15, 2025

View reviewed changes

crates/rolldown_plugin_vite_css_post/src/utils.rs Show resolved Hide resolved

shulaoda mentioned this pull request Nov 15, 2025

fix(rolldown_plugin_vite_html): skip redundant path resolution for processed URLs #7058

Merged

hyf0 approved these changes Nov 15, 2025

View reviewed changes

shulaoda mentioned this pull request Nov 15, 2025

feat(rolldown_plugin_utils): extract get_hash utility function #7059

Merged

fix(rolldown_plugin_vite_css_post): always compute css asset dirname …

aff376c

…in build command (#7054)

graphite-app bot force-pushed the 11-15-fix_rolldown_plugin_vite_css_post_always_compute_css_asset_dirname_in_build_command branch from 43bf109 to aff376c Compare November 15, 2025 21:35

shulaoda mentioned this pull request Nov 15, 2025

fix(rolldown_plugin_vite_html): use transformed result in asset URL handling #7060

Merged

shulaoda merged commit d52652e into main Nov 15, 2025
28 checks passed

shulaoda deleted the 11-15-fix_rolldown_plugin_vite_css_post_always_compute_css_asset_dirname_in_build_command branch November 15, 2025 21:47

shulaoda mentioned this pull request Nov 15, 2025

fix(rolldown_plugin_utils): correct string slicing in render_asset_url_in_js #7061

Merged

This was referenced Nov 18, 2025

release: v1.0.0-beta.51 #7106

Closed

release: v1.0.0-beta.51 #7121

Closed

release: v1.0.0-beta.51 #7124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(rolldown_plugin_vite_css_post): always compute css asset dirname in build command #7054

fix(rolldown_plugin_vite_css_post): always compute css asset dirname in build command #7054

Uh oh!

shulaoda commented Nov 15, 2025

Uh oh!

shulaoda commented Nov 15, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

netlify bot commented Nov 15, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

graphite-app bot commented Nov 15, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(rolldown_plugin_vite_css_post): always compute css asset dirname in build command #7054

fix(rolldown_plugin_vite_css_post): always compute css asset dirname in build command #7054

Uh oh!

Conversation

shulaoda commented Nov 15, 2025

Uh oh!

shulaoda commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

netlify bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

graphite-app bot commented Nov 15, 2025

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

shulaoda commented Nov 15, 2025 •

edited

Loading

github-actions bot commented Nov 15, 2025 •

edited

Loading

netlify bot commented Nov 15, 2025 •

edited

Loading