refactor(rolldown_plugin_html_inline_proxy): use `root` instead of `cwd` #7029

shulaoda · 2025-11-15T11:16:52Z

Related to #7027

shulaoda · 2025-11-15T11:17:06Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

netlify · 2025-11-15T11:18:48Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`b98abcd`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69186e4a199f4a00081c163f
😎 Deploy Preview	https://deploy-preview-7029--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copilot

Pull Request Overview

This PR refactors the HtmlInlineProxyPlugin to accept a root configuration parameter instead of relying on ctx.cwd(). This change improves the plugin's flexibility by allowing the root path to be explicitly specified rather than depending on the current working directory.

Key changes:

Converted HtmlInlineProxyPlugin from a zero-field struct to one that stores a PathBuf root field
Added BindingHtmlInlineProxyPluginConfig for TypeScript-to-Rust configuration binding
Replaced normalize_path utility with sugar_path's to_slash_lossy() method
Made plugin options required in the binding layer

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
`packages/rolldown/src/binding.d.cts`	Added TypeScript interface for the new plugin configuration
`crates/rolldown_plugin_html_inline_proxy/src/lib.rs`	Refactored plugin to accept and use `root` parameter instead of `ctx.cwd()`
`crates/rolldown_plugin_html_inline_proxy/Cargo.toml`	Added `sugar_path` dependency for path normalization
`crates/rolldown_binding/src/options/plugin/config/mod.rs`	Registered new binding configuration module
`crates/rolldown_binding/src/options/plugin/config/binding_html_inline_proxy_plugin_config.rs`	Created binding configuration struct with conversion logic
`crates/rolldown_binding/src/options/plugin/binding_builtin_plugin.rs`	Updated plugin instantiation to require and use configuration options
`Cargo.lock`	Reflected dependency changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_binding/src/options/plugin/binding_builtin_plugin.rs

crates/rolldown_binding/src/options/plugin/config/binding_html_inline_proxy_plugin_config.rs

crates/rolldown_plugin_html_inline_proxy/src/lib.rs

crates/rolldown_binding/src/options/plugin/config/binding_html_inline_proxy_plugin_config.rs

packages/rolldown/src/binding.d.cts

socket-security · 2025-11-15T11:22:07Z

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Copilot

Pull Request Overview

Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

crates/rolldown_binding/src/options/plugin/binding_builtin_plugin.rs

crates/rolldown_plugin_html_inline_proxy/src/lib.rs

crates/rolldown_binding/src/options/plugin/config/binding_html_inline_proxy_plugin_config.rs

crates/rolldown_binding/src/options/plugin/binding_builtin_plugin.rs

github-actions · 2025-11-15T11:42:29Z

Benchmarks Rust

target: main(e1a3d9d)
pr: 11-15-refactor_rolldown_plugin_html_inline_proxy_use_root_instead_of_cwd(b98abcd)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     64.3±2.40ms        ? ?/sec    1.09     70.4±1.61ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     70.0±1.43ms        ? ?/sec    1.10     76.6±1.88ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    106.8±2.61ms        ? ?/sec    1.05    112.5±2.05ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    118.7±2.47ms        ? ?/sec    1.05    125.1±1.64ms        ? ?/sec
bundle/bundle@threejs                                        1.01     39.3±1.42ms        ? ?/sec    1.00     39.0±0.85ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     42.2±0.53ms        ? ?/sec    1.07     45.0±0.76ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    386.9±4.94ms        ? ?/sec    1.05    405.2±5.50ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    446.8±5.90ms        ? ?/sec    1.04    463.9±5.74ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.0±1.68ms        ? ?/sec    1.01     87.0±1.61ms        ? ?/sec
scan/scan@threejs                                            1.00     28.4±0.50ms        ? ?/sec    1.03     29.1±0.46ms        ? ?/sec
scan/scan@threejs10x                                         1.00    296.5±4.46ms        ? ?/sec    1.02    301.1±5.64ms        ? ?/sec

graphite-app · 2025-11-15T12:00:57Z

Merge activity

Nov 15, 12:00 PM UTC: shulaoda added this pull request to the Graphite merge queue.

…wd` (#7029) Related to #7027

@shulaoda

## [1.0.0-beta.51] - 2025-11-19 ### 💥 BREAKING CHANGES - rolldown_plugin_vite_react_refresh_wrapper: add vite prefix (#7086) by @shulaoda - rolldown_plugin_vite_web_worker_post: add vite prefix (#7085) by @shulaoda - rolldown_plugin_vite_wasm_helper: add vite prefix (#7084) by @shulaoda - rolldown_plugin_vite_wasm_fallback: add vite prefix (#7083) by @shulaoda - rolldown_plugin_vite_transform: add vite prefix (#7082) by @shulaoda - rolldown_plugin_vite_reporter: add vite prefix (#7081) by @shulaoda - rolldown_plugin_vite_module_preload_polyfill: add vite prefix (#7080) by @shulaoda - rolldown_plugin_vite_manifest: add vite prefix (#7079) by @shulaoda - rolldown_plugin_vite_load_fallback: add vite prefix (#7072) by @shulaoda - rolldown_plugin_vite_json: add vite prefix (#7071) by @shulaoda - rolldown_plugin_vite_import_glob: add vite prefix (#7070) by @shulaoda - rolldown_plugin_vite_html_inline_proxy: add vite prefix (#7069) by @shulaoda - rolldown_plugin_vite_dynamic_import_vars: add vite prefix (#7068) by @shulaoda - rolldown_plugin_vite_build_import_analysis: add vite prefix (#7067) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: add vite prefix (#7066) by @shulaoda - rolldown_plugin_vite_alias: add vite prefix (#7065) by @shulaoda - rolldown_plugin_vite_asset_plugin: add vite prefix (#7064) by @shulaoda ### 🚀 Features - export sync APIs to experimental (#7122) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement template literal support for dynamic URLs (#7118) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement AST-based URL detection (#7113) by @shulaoda - add isPathFragment validation for filename patterns (rollup compat) (#7101) by @IWANABETHATGUY - rolldown_plugin_vite_asset_import_meta_url: align filter logic (#7103) by @shulaoda - rolldown: oxc v0.98.0 (#6961) by @camc314 - show error contexts for unhandleable errors (#7095) by @sapphi-red - rolldown_plugin_utils: extract `get_hash` utility function (#7059) by @shulaoda - rolldown_plugin_asset: initialize `CSSEntriesCache` (#7015) by @shulaoda - rolldown_plugin_vite_html: align `transformIndexHtml` logic (#7010) by @shulaoda - builtin-plugin: support `bindingifyViteHtmlPlugin` (#7008) by @shulaoda - impl `generatedCode.symbols` for reexport dynamic modules. (#6993) by @IWANABETHATGUY - rolldown_plugin_manifest: support v2 logic (#6979) by @shulaoda - support Node.js `module.exports` ESM export (#6967) by @Copilot - change "could not clean directory" from error to warning (#6955) by @Copilot - rolldown_binding: add context to errors thrown by plugin hooks (#6964) by @sapphi-red ### 🐛 Bug Fixes - content hash should be affected by the minify behavior (#7102) by @hyf0 - `canonical name not found for "__toESM"` error when only named imports are used from a CJS module (#7094) by @sapphi-red - preserve directory structure in chunk names with preserveModules (#6872) by @IWANABETHATGUY - rolldown_plugin_asset: correct bundle deletion index calculation (#7063) by @shulaoda - rolldown_plugin_utils: correct string slicing in `render_asset_url_in_js` (#7061) by @shulaoda - rolldown_plugin_vite_html: use transformed result in asset URL handling (#7060) by @shulaoda - rolldown_plugin_vite_html: skip redundant path resolution for processed URLs (#7058) by @shulaoda - rolldown_plugin_vite_css_post: data race in CSS URL processing (#7055) by @shulaoda - rolldown_plugin_vite_css_post: always compute css asset dirname in build command (#7054) by @shulaoda - rolldown_plugin_vite_css: ensure consistent url in import and export (#7053) by @shulaoda - rolldown_plugin_vite_css_post: use `get_or_insert_default` for `HTMLProxyResult` (#7052) by @shulaoda - rolldown_plugin_vite_css: skip `commonjs-proxy` CSS requests (#7050) by @shulaoda - rolldown_plugin_utils: correct `is_css_module` (#7049) by @shulaoda - rolldown_plugin_utils: correct `is_css_request` (#7048) by @shulaoda - rolldown_plugin_vite_html: use correct inline module index (#7046) by @shulaoda - rolldown_plugin_vite_html: correct scripts url update logic (#7045) by @shulaoda - rolldown_plugin_vite_html: fallback to original url on NotFound error (#7043) by @shulaoda - rolldown_plugin_vite_html: move src_tasks to correct branch (#7040) by @shulaoda - rolldown_plugin_vite_html: correct `handle_style_tag_or_attribute` (#7038) by @shulaoda - builtin-plugin: add `config` to `htmlInlineProxyPlugin` (#7036) by @shulaoda - missing CJS default export when SafelyMergeCjsNs optimization is enabled (#7006) by @Copilot - reserve global names before deconflicting external symbols (#7022) by @IWANABETHATGUY - rolldown_plugin_build_import_analysis: process all bundle outputs correctly (#7020) by @shulaoda - rolldown_plugin_vite_css_post: process all bundle outputs correctly (#7019) by @shulaoda - rolldown_plugin_vite_css_post: remove `/*$vite$:1*/` correctly (#7018) by @shulaoda - rolldown_plugin_vite_html: use correct span for `style_urls` (#7017) by @shulaoda - rolldown_plugin_vite_html: track full element span from start to end tag (#7016) by @shulaoda - builtin-plugin: correct `viteHtmlPlugin` related logic (#7013) by @shulaoda - remove unused module namespace object exporting (#7002) by @IWANABETHATGUY - rust/dev: allow to recover from hmr rebuild failure (#6991) by @hyf0 - rust/dev: `ensure_latest_bundle_output` shouldn't loop infinitely (#6974) by @hyf0 - rust/dev: `DevEngine#ensure_latest_bundle_output` should schedule a rebuild task if there're no queued tasks (#6968) by @hyf0 - add Symbol.toStringTag to module facades when generatedCode.symbols is enabled (#6784) by @Copilot ### 🚜 Refactor - extension checking to use constant array (#7057) by @Copilot - rust/devtools: tweak namings and introduction comments (#7028) by @hyf0 - rolldown_plugin_vite_html: use `root` instead of `cwd` (#7035) by @shulaoda - rolldown_plugin_vite_css_post: use `root` instead of `cwd` (#7034) by @shulaoda - rolldown_plugin_vite_css: use `root` instead of `cwd` (#7033) by @shulaoda - rolldown_plugin_transform: use `root` instead of `cwd` (#7032) by @shulaoda - rolldown_plugin_reporter: use `root` instead of `cwd` (#7031) by @shulaoda - rolldown_plugin_asset: use `root` instead of `cwd` (#7030) by @shulaoda - rolldown_plugin_html_inline_proxy: use `root` instead of `cwd` (#7029) by @shulaoda - rust/dev: remove dead code of `rolldown_dev` crate (#6997) by @hyf0 - rust: move dev related code into new `rolldown_dev` crate (#6996) by @hyf0 - rolldown_resolver: use consistent generic parameter name `Fs` (#6998) by @shulaoda - rolldown_resolver: improve resolve method clarity and documentation (#6986) by @shulaoda - rename `is_module_facade()` to `is_entry_point()` for clarity (#6994) by @IWANABETHATGUY - rust/dev: unwrap `Result<_>` from the return type of `BundleCoordinator::schedule_build_if_stale` (#6980) by @sapphi-red - rolldown_resolver: reorganize impl blocks (#6984) by @shulaoda - rolldown_resolver: extract configuration logic into separate module (#6983) by @shulaoda - rolldown_resolver: improve error messages (#6982) by @shulaoda - rust/dev: rename `CoordinatorStatus` to `CoordinatorStateSnapshot` (#6973) by @hyf0 - rust/dev: replace `InitialBuildState` with `CoordinatorState` (#6972) by @hyf0 - ast_scanner: derive `Debug`, `Clone`, `Copy` for `CjsGlobalAssignmentType` (#6971) by @camc314 - rust: filter out devtools specific events for normal tracing (#6965) by @hyf0 - rust/dev: replace `CoordinatorMsg::HasLatestBuildOutput` with `GetStatus` (#6960) by @hyf0 - rust/dev: `ensure_current_build_finish` shouldn't block the coordinator's event loop (#6959) by @hyf0 ### 📚 Documentation - in-depth/directives: remove TODOs and fix code (#7112) by @sapphi-red - clarify concepts of rolldown's test infra (#7047) by @hyf0 - contrib/style: add suggestions about choosing file names (#6989) by @hyf0 ### ⚡ Performance - rolldown_plugin_vite_css_post: cache CSS URL processing results (#7056) by @shulaoda - remove unnecessary `collect_vec` (#6999) by @IWANABETHATGUY ### 🧪 Testing - add testcase for #6880 and #6879 (#7107) by @IWANABETHATGUY - vite-tests: use integration branch for vite compatibility tests (#7091) by @shulaoda ### ⚙️ Miscellaneous Tasks - remove redundant chunk level linefeed (#7109) by @IWANABETHATGUY - pin oxc-minify to 0.97.0 (#7108) by @IWANABETHATGUY - deps: update oxc apps (#7104) by @renovate[bot] - deps: update glob for security (#7105) by @shulaoda - rolldown: add aliases for renamed vite plugins (#7087) by @shulaoda - automate weekly beta releases (#7089) by @Boshen - deps: update dependency oxlint-tsgolint to v0.7.0 (#7088) by @renovate[bot] - deps: update github-actions (#7075) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.6.0 (#7037) by @renovate[bot] - deps: update npm packages (#7076) by @renovate[bot] - deps: update rust crates (#7077) by @renovate[bot] - add retry to flaky tests (#7041) by @sapphi-red - rust: rename `rolldown_debug` to `rolldown_devtools` (#7026) by @hyf0 - deps: update crate-ci/typos action to v1.39.2 (#7001) by @renovate[bot] - ai/github: make copilot review check rust api style (#6988) by @hyf0 - move test `recover_from_initial_build_error` to `error_recovery/from_initial_build_syntax_error` (#6990) by @hyf0 - oxlint: enable `typescript/consistent-type-imports` rule (#6987) by @shulaoda - deps: update crate-ci/typos action to v1.39.1 (#6975) by @renovate[bot] - build.ts: separate import type (#6921) by @iiio2 - format rolldown runtime (#6966) by @IWANABETHATGUY Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned shulaoda Nov 15, 2025

shulaoda changed the title ~~refactor(rolldown_plugin_html_inline_proxy): use root instead of cwd~~ refactor(rolldown_plugin_html_inline_proxy): use ` instead of cwd Nov 15, 2025

shulaoda changed the title ~~refactor(rolldown_plugin_html_inline_proxy): use ` instead of cwd~~ refactor(rolldown_plugin_html_inline_proxy): use root instead of cwd Nov 15, 2025

shulaoda requested review from IWANABETHATGUY and hyf0 November 15, 2025 11:17

shulaoda marked this pull request as ready for review November 15, 2025 11:17

Copilot AI review requested due to automatic review settings November 15, 2025 11:17

Copilot started reviewing on behalf of shulaoda November 15, 2025 11:17 View session

Copilot finished reviewing on behalf of shulaoda November 15, 2025 11:21

shulaoda mentioned this pull request Nov 15, 2025

refactor(rolldown_plugin_asset): use root instead of cwd #7030

Merged

Copilot AI reviewed Nov 15, 2025

View reviewed changes

hyf0 approved these changes Nov 15, 2025

View reviewed changes

Copilot AI review requested due to automatic review settings November 15, 2025 11:29

shulaoda mentioned this pull request Nov 15, 2025

refactor(rolldown_plugin_reporter): use root instead of cwd #7031

Merged

Copilot started reviewing on behalf of shulaoda November 15, 2025 11:29 View session

Copilot finished reviewing on behalf of shulaoda November 15, 2025 11:31

Copilot AI reviewed Nov 15, 2025

View reviewed changes

shulaoda mentioned this pull request Nov 15, 2025

refactor(rolldown_plugin_transform): use root instead of cwd #7032

Merged

This was referenced Nov 15, 2025

refactor(rolldown_plugin_vite_css): use root instead of cwd #7033

Merged

refactor(rolldown_plugin_vite_css_post): use root instead of cwd #7034

Merged

refactor(rolldown_plugin_vite_html): use root instead of cwd #7035

Merged

refactor(rolldown_plugin_html_inline_proxy): use root instead of `c…

b98abcd

…wd` (#7029) Related to #7027

graphite-app bot force-pushed the 11-15-refactor_rolldown_plugin_html_inline_proxy_use_root_instead_of_cwd branch from 95a63a0 to b98abcd Compare November 15, 2025 12:12

shulaoda merged commit 04c6127 into main Nov 15, 2025
27 of 29 checks passed

shulaoda deleted the 11-15-refactor_rolldown_plugin_html_inline_proxy_use_root_instead_of_cwd branch November 15, 2025 12:23

This was referenced Nov 18, 2025

release: v1.0.0-beta.51 #7106

Closed

release: v1.0.0-beta.51 #7121

Closed

release: v1.0.0-beta.51 #7124

Merged

refactor(rolldown_plugin_html_inline_proxy): use root instead of cwd #7029

refactor(rolldown_plugin_html_inline_proxy): use root instead of cwd #7029

Uh oh!

Conversation

shulaoda commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

shulaoda commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

socket-security bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Nov 15, 2025

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor(rolldown_plugin_html_inline_proxy): use `root` instead of `cwd` #7029

refactor(rolldown_plugin_html_inline_proxy): use `root` instead of `cwd` #7029

shulaoda commented Nov 15, 2025 •

edited

Loading

shulaoda commented Nov 15, 2025 •

edited

Loading

netlify bot commented Nov 15, 2025 •

edited

Loading

socket-security bot commented Nov 15, 2025 •

edited

Loading

github-actions bot commented Nov 15, 2025 •

edited

Loading