feat: support Node.js `module.exports` ESM export #6967

Copilot · 2025-11-12T12:52:55Z

Plan for module.exports export support ✅

Understanding the issue:

Node.js introduced a new module.exports ESM export (module: support 'module.exports' interop export name in require(esm) nodejs/node#54563)
When an ESM module exports module.exports, it should be prioritized over the default ESM-to-CJS conversion
Need to check if module has module.exports property and use it directly

Tasks:

Implementation Summary

Changes Made

Runtime Code Changes: Updated __toCommonJS with improved comment and implementation
Test Structure: Reorganized into subdirectories under crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/:
- basic/ - Basic module.exports behavior
- fallback/ - Backward compatibility without module.exports
- priority/ - Priority over other exports
- with_default/ - Works alongside default exports
Test Format: Tests output ESM format while testing CJS interop via wrapper files
- esm.js - ESM module with or without module.exports export
- cjs.js - CJS wrapper that requires the ESM module (triggers __toCommonJS)
- main.js - ESM entry point that imports from CJS wrapper and asserts behavior
Merge Conflict Resolution: Updated __export function in runtime-base.js to accept new symbols parameter

Test Results

All 616 tests pass ✅
All 4 module.exports tests pass with ESM output ✅
Snapshots updated correctly ✅
Merge conflict resolved ✅

Fixes #4997

Original prompt

This section details on the original issue you should resolve

<issue_title>[Feature Request]: module.exports export support</issue_title>
<issue_description>### What problem does this feature solve?

Node.js introduced module.exports export (nodejs/node#54563). This feature will be required to bundle some packages properly.

REPL (input code shows { foo: 'foo' }, while output code shows { default: [Getter], 'module.exports': [Getter] })

It's not yet used by many packages. But I guess it'll be used in more places once the require(ESM) gets adopted.

refs #3640

What does the proposed API look like?

No API change.</issue_description>

<agent_instructions>Change export var __toCommonJS = mod => __copyProps(__defProp({}, '__esModule', { value: true }), mod) to export var __toCommonJS = mod => __hasOwnProp.call(mod, 'module.exports') ? mod['module.exports'] : __copyProps(__defProp({}, '__esModule', { value: true }), mod).
Add extensive tests based on nodejs/node#54563 under crates/rolldown/tests/rolldown/cjs_compat/module.exports_export
</agent_instructions>

Comments on the Issue (you are @copilot in this section)
@hyf0 Looks like `__toCommonJS` needs to have `node mode`.

Fixes [Feature Request]: module.exports export support #4997

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

graphite-app · 2025-11-12T12:53:01Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

netlify · 2025-11-12T12:54:32Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`79a9118`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69158aff4dc189000871ce72

crates/rolldown/src/runtime/index.js

crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/_config.json

crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/fallback/artifacts.snap

crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/main.js

crates/rolldown/src/runtime/index.js

sapphi-red · 2025-11-12T17:15:46Z

@copilot resolve the conflict by rerunning the tests

Copilot · 2025-11-12T17:22:25Z

@copilot resolve the conflict by rerunning the tests

Tests have been rerun successfully. All 616 tests pass with no conflicts.

sapphi-red · 2025-11-12T17:34:39Z

@copilot please resolve the conflict

Copilot · 2025-11-12T17:41:11Z

@copilot please resolve the conflict

Conflict resolved. Updated __export function signature to accept symbols parameter and regenerated all affected snapshots. All 616 tests pass. (768f27f)

crates/rolldown/src/runtime/index.js

Copilot

Pull Request Overview

This PR adds support for Node.js's new module.exports ESM export feature (introduced in Node.js PR #54563). When an ESM module exports a module.exports property, the __toCommonJS runtime helper now prioritizes it over the traditional ESM-to-CJS conversion, ensuring proper bundling compatibility with packages using this feature.

Updated __toCommonJS to check for module.exports property and use it directly when present
Added comprehensive test coverage with 4 test scenarios (basic, fallback, priority, with_default)
Updated runtime comments to accurately describe the new behavior

Reviewed Changes

Copilot reviewed 23 out of 23 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
`crates/rolldown/src/runtime/runtime-base.js`	Updated `__toCommonJS` to check for and prioritize `module.exports` property
`crates/rolldown/src/runtime/index.js`	Updated `__toCommonJS` implementation and improved documentation comment
`crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/basic/*`	Test basic `module.exports` export behavior
`crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/fallback/*`	Test backward compatibility when `module.exports` is not present
`crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/priority/*`	Test that `module.exports` takes priority over other exports
`crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/with_default/*`	Test `module.exports` works alongside default exports
`crates/rolldown/tests/snapshots/integration_rolldown__filename_with_hash.snap`	Updated hash values reflecting runtime code changes

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hyf0 · 2025-11-13T07:37:17Z

Merge activity

Nov 13, 7:37 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Nov 13, 7:37 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Nov 13, 7:56 AM UTC: Merged by the Graphite merge queue.

@hyf0

## Plan for module.exports export support ✅ Understanding the issue: - Node.js introduced a new `module.exports` ESM export (nodejs/node#54563) - When an ESM module exports `module.exports`, it should be prioritized over the default ESM-to-CJS conversion - Need to check if module has `module.exports` property and use it directly Tasks: - [x] Explore repository structure and understand the codebase - [x] Build the project and verify all tests pass - [x] Update `__toCommonJS` implementation in runtime files - [x] Create comprehensive tests for `module.exports` export feature - [x] Run tests to verify the changes work correctly - [x] Code review and security check - [x] Address PR feedback: - [x] Updated comment above `__toCommonJS` in index.js - [x] Removed `"config": { "treeshake": false }` from all `_config.json` - [x] Reorganized tests under subdirectories (basic, fallback, priority, with_default) - [x] Removed `format: "cjs"` config to output tests as ESM - [x] Added CJS wrapper files to test `__toCommonJS` behavior - [x] Used `assert.deepStrictEqual` for all tests - [x] Resolved merge conflict with main branch ## Implementation Summary ### Changes Made 1. **Runtime Code Changes**: Updated `__toCommonJS` with improved comment and implementation 2. **Test Structure**: Reorganized into subdirectories under `crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/`: - `basic/` - Basic module.exports behavior - `fallback/` - Backward compatibility without module.exports - `priority/` - Priority over other exports - `with_default/` - Works alongside default exports 3. **Test Format**: Tests output ESM format while testing CJS interop via wrapper files - `esm.js` - ESM module with or without `module.exports` export - `cjs.js` - CJS wrapper that requires the ESM module (triggers `__toCommonJS`) - `main.js` - ESM entry point that imports from CJS wrapper and asserts behavior 4. **Merge Conflict Resolution**: Updated `__export` function in runtime-base.js to accept new `symbols` parameter ### Test Results - All 616 tests pass ✅ - All 4 module.exports tests pass with ESM output ✅ - Snapshots updated correctly ✅ - Merge conflict resolved ✅ Fixes #4997  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[Feature Request]: `module.exports` export support</issue_title> > <issue_description>### What problem does this feature solve? > > Node.js introduced `module.exports` export (nodejs/node#54563). This feature will be required to bundle some packages properly. > > [REPL](https://repl.rolldown.rs/#eNpVjt0KwjAMhV+l5KYTZtyuhIKXvsVu5paJo2u1P6KMvrvZH8yLNpyTnHwZoQM1Apngvtj0fhIG1M7IoWHdWOODGGwbNV0/T+uCFxfh6BUfjjKJp85aHHovD5WpzDRtNaG29+wvw11eSKCCi5RyWFMbdZN7JntMGqeqhORfilQ5pvCjeatoqaujnkd37hwRtRdyOQEX3695SMx/M6bEAovjjUKN5RnSDzGYXOs=) (input code shows `{ foo: 'foo' }`, while output code shows `{ default: [Getter], 'module.exports': [Getter] }`) > > It's not yet used by many packages. But I guess it'll be used in more places once the `require(ESM)` gets adopted. > > refs #3640 > > > ### What does the proposed API look like? > > No API change.</issue_description> > > <agent_instructions>Change `export var __toCommonJS = mod => __copyProps(__defProp({}, '__esModule', { value: true }), mod)` to `export var __toCommonJS = mod => __hasOwnProp.call(mod, 'module.exports') ? mod['module.exports'] : __copyProps(__defProp({}, '__esModule', { value: true }), mod)`. > Add extensive tests based on nodejs/node#54563 under `crates/rolldown/tests/rolldown/cjs_compat/module.exports_export` > </agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@hyf0</author><body> > Looks like `__toCommonJS` needs to have `node mode`.</body></comment_new> > </comments> > </details> - Fixes #4997  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

@hyf0

## Plan for module.exports export support ✅ Understanding the issue: - Node.js introduced a new `module.exports` ESM export (nodejs/node#54563) - When an ESM module exports `module.exports`, it should be prioritized over the default ESM-to-CJS conversion - Need to check if module has `module.exports` property and use it directly Tasks: - [x] Explore repository structure and understand the codebase - [x] Build the project and verify all tests pass - [x] Update `__toCommonJS` implementation in runtime files - [x] Create comprehensive tests for `module.exports` export feature - [x] Run tests to verify the changes work correctly - [x] Code review and security check - [x] Address PR feedback: - [x] Updated comment above `__toCommonJS` in index.js - [x] Removed `"config": { "treeshake": false }` from all `_config.json` - [x] Reorganized tests under subdirectories (basic, fallback, priority, with_default) - [x] Removed `format: "cjs"` config to output tests as ESM - [x] Added CJS wrapper files to test `__toCommonJS` behavior - [x] Used `assert.deepStrictEqual` for all tests - [x] Resolved merge conflict with main branch ## Implementation Summary ### Changes Made 1. **Runtime Code Changes**: Updated `__toCommonJS` with improved comment and implementation 2. **Test Structure**: Reorganized into subdirectories under `crates/rolldown/tests/rolldown/cjs_compat/module.exports_export/`: - `basic/` - Basic module.exports behavior - `fallback/` - Backward compatibility without module.exports - `priority/` - Priority over other exports - `with_default/` - Works alongside default exports 3. **Test Format**: Tests output ESM format while testing CJS interop via wrapper files - `esm.js` - ESM module with or without `module.exports` export - `cjs.js` - CJS wrapper that requires the ESM module (triggers `__toCommonJS`) - `main.js` - ESM entry point that imports from CJS wrapper and asserts behavior 4. **Merge Conflict Resolution**: Updated `__export` function in runtime-base.js to accept new `symbols` parameter ### Test Results - All 616 tests pass ✅ - All 4 module.exports tests pass with ESM output ✅ - Snapshots updated correctly ✅ - Merge conflict resolved ✅ Fixes #4997  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>[Feature Request]: `module.exports` export support</issue_title> > <issue_description>### What problem does this feature solve? > > Node.js introduced `module.exports` export (nodejs/node#54563). This feature will be required to bundle some packages properly. > > [REPL](https://repl.rolldown.rs/#eNpVjt0KwjAMhV+l5KYTZtyuhIKXvsVu5paJo2u1P6KMvrvZH8yLNpyTnHwZoQM1Apngvtj0fhIG1M7IoWHdWOODGGwbNV0/T+uCFxfh6BUfjjKJp85aHHovD5WpzDRtNaG29+wvw11eSKCCi5RyWFMbdZN7JntMGqeqhORfilQ5pvCjeatoqaujnkd37hwRtRdyOQEX3695SMx/M6bEAovjjUKN5RnSDzGYXOs=) (input code shows `{ foo: 'foo' }`, while output code shows `{ default: [Getter], 'module.exports': [Getter] }`) > > It's not yet used by many packages. But I guess it'll be used in more places once the `require(ESM)` gets adopted. > > refs #3640 > > > ### What does the proposed API look like? > > No API change.</issue_description> > > <agent_instructions>Change `export var __toCommonJS = mod => __copyProps(__defProp({}, '__esModule', { value: true }), mod)` to `export var __toCommonJS = mod => __hasOwnProp.call(mod, 'module.exports') ? mod['module.exports'] : __copyProps(__defProp({}, '__esModule', { value: true }), mod)`. > Add extensive tests based on nodejs/node#54563 under `crates/rolldown/tests/rolldown/cjs_compat/module.exports_export` > </agent_instructions> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > <comment_new><author>@hyf0</author><body> > Looks like `__toCommonJS` needs to have `node mode`.</body></comment_new> > </comments> > </details> - Fixes #4997  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

@shulaoda

## [1.0.0-beta.51] - 2025-11-19 ### 💥 BREAKING CHANGES - rolldown_plugin_vite_react_refresh_wrapper: add vite prefix (#7086) by @shulaoda - rolldown_plugin_vite_web_worker_post: add vite prefix (#7085) by @shulaoda - rolldown_plugin_vite_wasm_helper: add vite prefix (#7084) by @shulaoda - rolldown_plugin_vite_wasm_fallback: add vite prefix (#7083) by @shulaoda - rolldown_plugin_vite_transform: add vite prefix (#7082) by @shulaoda - rolldown_plugin_vite_reporter: add vite prefix (#7081) by @shulaoda - rolldown_plugin_vite_module_preload_polyfill: add vite prefix (#7080) by @shulaoda - rolldown_plugin_vite_manifest: add vite prefix (#7079) by @shulaoda - rolldown_plugin_vite_load_fallback: add vite prefix (#7072) by @shulaoda - rolldown_plugin_vite_json: add vite prefix (#7071) by @shulaoda - rolldown_plugin_vite_import_glob: add vite prefix (#7070) by @shulaoda - rolldown_plugin_vite_html_inline_proxy: add vite prefix (#7069) by @shulaoda - rolldown_plugin_vite_dynamic_import_vars: add vite prefix (#7068) by @shulaoda - rolldown_plugin_vite_build_import_analysis: add vite prefix (#7067) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: add vite prefix (#7066) by @shulaoda - rolldown_plugin_vite_alias: add vite prefix (#7065) by @shulaoda - rolldown_plugin_vite_asset_plugin: add vite prefix (#7064) by @shulaoda ### 🚀 Features - export sync APIs to experimental (#7122) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement template literal support for dynamic URLs (#7118) by @shulaoda - rolldown_plugin_vite_asset_import_meta_url: implement AST-based URL detection (#7113) by @shulaoda - add isPathFragment validation for filename patterns (rollup compat) (#7101) by @IWANABETHATGUY - rolldown_plugin_vite_asset_import_meta_url: align filter logic (#7103) by @shulaoda - rolldown: oxc v0.98.0 (#6961) by @camc314 - show error contexts for unhandleable errors (#7095) by @sapphi-red - rolldown_plugin_utils: extract `get_hash` utility function (#7059) by @shulaoda - rolldown_plugin_asset: initialize `CSSEntriesCache` (#7015) by @shulaoda - rolldown_plugin_vite_html: align `transformIndexHtml` logic (#7010) by @shulaoda - builtin-plugin: support `bindingifyViteHtmlPlugin` (#7008) by @shulaoda - impl `generatedCode.symbols` for reexport dynamic modules. (#6993) by @IWANABETHATGUY - rolldown_plugin_manifest: support v2 logic (#6979) by @shulaoda - support Node.js `module.exports` ESM export (#6967) by @Copilot - change "could not clean directory" from error to warning (#6955) by @Copilot - rolldown_binding: add context to errors thrown by plugin hooks (#6964) by @sapphi-red ### 🐛 Bug Fixes - content hash should be affected by the minify behavior (#7102) by @hyf0 - `canonical name not found for "__toESM"` error when only named imports are used from a CJS module (#7094) by @sapphi-red - preserve directory structure in chunk names with preserveModules (#6872) by @IWANABETHATGUY - rolldown_plugin_asset: correct bundle deletion index calculation (#7063) by @shulaoda - rolldown_plugin_utils: correct string slicing in `render_asset_url_in_js` (#7061) by @shulaoda - rolldown_plugin_vite_html: use transformed result in asset URL handling (#7060) by @shulaoda - rolldown_plugin_vite_html: skip redundant path resolution for processed URLs (#7058) by @shulaoda - rolldown_plugin_vite_css_post: data race in CSS URL processing (#7055) by @shulaoda - rolldown_plugin_vite_css_post: always compute css asset dirname in build command (#7054) by @shulaoda - rolldown_plugin_vite_css: ensure consistent url in import and export (#7053) by @shulaoda - rolldown_plugin_vite_css_post: use `get_or_insert_default` for `HTMLProxyResult` (#7052) by @shulaoda - rolldown_plugin_vite_css: skip `commonjs-proxy` CSS requests (#7050) by @shulaoda - rolldown_plugin_utils: correct `is_css_module` (#7049) by @shulaoda - rolldown_plugin_utils: correct `is_css_request` (#7048) by @shulaoda - rolldown_plugin_vite_html: use correct inline module index (#7046) by @shulaoda - rolldown_plugin_vite_html: correct scripts url update logic (#7045) by @shulaoda - rolldown_plugin_vite_html: fallback to original url on NotFound error (#7043) by @shulaoda - rolldown_plugin_vite_html: move src_tasks to correct branch (#7040) by @shulaoda - rolldown_plugin_vite_html: correct `handle_style_tag_or_attribute` (#7038) by @shulaoda - builtin-plugin: add `config` to `htmlInlineProxyPlugin` (#7036) by @shulaoda - missing CJS default export when SafelyMergeCjsNs optimization is enabled (#7006) by @Copilot - reserve global names before deconflicting external symbols (#7022) by @IWANABETHATGUY - rolldown_plugin_build_import_analysis: process all bundle outputs correctly (#7020) by @shulaoda - rolldown_plugin_vite_css_post: process all bundle outputs correctly (#7019) by @shulaoda - rolldown_plugin_vite_css_post: remove `/*$vite$:1*/` correctly (#7018) by @shulaoda - rolldown_plugin_vite_html: use correct span for `style_urls` (#7017) by @shulaoda - rolldown_plugin_vite_html: track full element span from start to end tag (#7016) by @shulaoda - builtin-plugin: correct `viteHtmlPlugin` related logic (#7013) by @shulaoda - remove unused module namespace object exporting (#7002) by @IWANABETHATGUY - rust/dev: allow to recover from hmr rebuild failure (#6991) by @hyf0 - rust/dev: `ensure_latest_bundle_output` shouldn't loop infinitely (#6974) by @hyf0 - rust/dev: `DevEngine#ensure_latest_bundle_output` should schedule a rebuild task if there're no queued tasks (#6968) by @hyf0 - add Symbol.toStringTag to module facades when generatedCode.symbols is enabled (#6784) by @Copilot ### 🚜 Refactor - extension checking to use constant array (#7057) by @Copilot - rust/devtools: tweak namings and introduction comments (#7028) by @hyf0 - rolldown_plugin_vite_html: use `root` instead of `cwd` (#7035) by @shulaoda - rolldown_plugin_vite_css_post: use `root` instead of `cwd` (#7034) by @shulaoda - rolldown_plugin_vite_css: use `root` instead of `cwd` (#7033) by @shulaoda - rolldown_plugin_transform: use `root` instead of `cwd` (#7032) by @shulaoda - rolldown_plugin_reporter: use `root` instead of `cwd` (#7031) by @shulaoda - rolldown_plugin_asset: use `root` instead of `cwd` (#7030) by @shulaoda - rolldown_plugin_html_inline_proxy: use `root` instead of `cwd` (#7029) by @shulaoda - rust/dev: remove dead code of `rolldown_dev` crate (#6997) by @hyf0 - rust: move dev related code into new `rolldown_dev` crate (#6996) by @hyf0 - rolldown_resolver: use consistent generic parameter name `Fs` (#6998) by @shulaoda - rolldown_resolver: improve resolve method clarity and documentation (#6986) by @shulaoda - rename `is_module_facade()` to `is_entry_point()` for clarity (#6994) by @IWANABETHATGUY - rust/dev: unwrap `Result<_>` from the return type of `BundleCoordinator::schedule_build_if_stale` (#6980) by @sapphi-red - rolldown_resolver: reorganize impl blocks (#6984) by @shulaoda - rolldown_resolver: extract configuration logic into separate module (#6983) by @shulaoda - rolldown_resolver: improve error messages (#6982) by @shulaoda - rust/dev: rename `CoordinatorStatus` to `CoordinatorStateSnapshot` (#6973) by @hyf0 - rust/dev: replace `InitialBuildState` with `CoordinatorState` (#6972) by @hyf0 - ast_scanner: derive `Debug`, `Clone`, `Copy` for `CjsGlobalAssignmentType` (#6971) by @camc314 - rust: filter out devtools specific events for normal tracing (#6965) by @hyf0 - rust/dev: replace `CoordinatorMsg::HasLatestBuildOutput` with `GetStatus` (#6960) by @hyf0 - rust/dev: `ensure_current_build_finish` shouldn't block the coordinator's event loop (#6959) by @hyf0 ### 📚 Documentation - in-depth/directives: remove TODOs and fix code (#7112) by @sapphi-red - clarify concepts of rolldown's test infra (#7047) by @hyf0 - contrib/style: add suggestions about choosing file names (#6989) by @hyf0 ### ⚡ Performance - rolldown_plugin_vite_css_post: cache CSS URL processing results (#7056) by @shulaoda - remove unnecessary `collect_vec` (#6999) by @IWANABETHATGUY ### 🧪 Testing - add testcase for #6880 and #6879 (#7107) by @IWANABETHATGUY - vite-tests: use integration branch for vite compatibility tests (#7091) by @shulaoda ### ⚙️ Miscellaneous Tasks - remove redundant chunk level linefeed (#7109) by @IWANABETHATGUY - pin oxc-minify to 0.97.0 (#7108) by @IWANABETHATGUY - deps: update oxc apps (#7104) by @renovate[bot] - deps: update glob for security (#7105) by @shulaoda - rolldown: add aliases for renamed vite plugins (#7087) by @shulaoda - automate weekly beta releases (#7089) by @Boshen - deps: update dependency oxlint-tsgolint to v0.7.0 (#7088) by @renovate[bot] - deps: update github-actions (#7075) by @renovate[bot] - deps: update dependency oxlint-tsgolint to v0.6.0 (#7037) by @renovate[bot] - deps: update npm packages (#7076) by @renovate[bot] - deps: update rust crates (#7077) by @renovate[bot] - add retry to flaky tests (#7041) by @sapphi-red - rust: rename `rolldown_debug` to `rolldown_devtools` (#7026) by @hyf0 - deps: update crate-ci/typos action to v1.39.2 (#7001) by @renovate[bot] - ai/github: make copilot review check rust api style (#6988) by @hyf0 - move test `recover_from_initial_build_error` to `error_recovery/from_initial_build_syntax_error` (#6990) by @hyf0 - oxlint: enable `typescript/consistent-type-imports` rule (#6987) by @shulaoda - deps: update crate-ci/typos action to v1.39.1 (#6975) by @renovate[bot] - build.ts: separate import type (#6921) by @iiio2 - format rolldown runtime (#6966) by @IWANABETHATGUY Co-authored-by: shulaoda <[email protected]>

Copilot AI assigned Copilot and sapphi-red Nov 12, 2025

Copilot started work on behalf of sapphi-red November 12, 2025 12:53 View session

Copilot AI changed the title ~~[WIP] Add support for module.exports export in bundling~~ feat: support Node.js module.exports ESM export Nov 12, 2025

Copilot AI requested a review from sapphi-red November 12, 2025 13:20

Copilot finished work on behalf of sapphi-red November 12, 2025 13:20

sapphi-red reviewed Nov 12, 2025

View reviewed changes

Copilot started work on behalf of sapphi-red November 12, 2025 13:30 View session

Copilot AI requested a review from sapphi-red November 12, 2025 13:46

Copilot finished work on behalf of sapphi-red November 12, 2025 13:46

Copilot started work on behalf of sapphi-red November 12, 2025 13:49 View session

Copilot finished work on behalf of sapphi-red November 12, 2025 14:03

sapphi-red reviewed Nov 12, 2025

View reviewed changes

crates/rolldown/src/runtime/index.js Outdated Show resolved Hide resolved

sapphi-red approved these changes Nov 12, 2025

View reviewed changes

Copilot started work on behalf of sapphi-red November 12, 2025 17:16 View session

Copilot AI requested a review from sapphi-red November 12, 2025 17:24

Copilot finished work on behalf of sapphi-red November 12, 2025 17:24

Copilot started work on behalf of sapphi-red November 12, 2025 17:35 View session

Copilot finished work on behalf of sapphi-red November 12, 2025 17:42

sapphi-red reviewed Nov 12, 2025

View reviewed changes

crates/rolldown/src/runtime/index.js Show resolved Hide resolved

sapphi-red requested a review from IWANABETHATGUY November 12, 2025 17:51

sapphi-red marked this pull request as ready for review November 12, 2025 17:51

hyf0 requested a review from Copilot November 13, 2025 07:34

Copilot started reviewing on behalf of hyf0 November 13, 2025 07:34 View session

Copilot finished reviewing on behalf of hyf0 November 13, 2025 07:35

hyf0 approved these changes Nov 13, 2025

View reviewed changes

Copilot AI reviewed Nov 13, 2025

View reviewed changes

hyf0 added the graphite: merge label Nov 13, 2025

graphite-app bot force-pushed the copilot/add-module-exports-support branch from 42e1a40 to 53fced9 Compare November 13, 2025 07:37

graphite-app bot force-pushed the copilot/add-module-exports-support branch from 53fced9 to 79a9118 Compare November 13, 2025 07:38

IWANABETHATGUY approved these changes Nov 13, 2025

View reviewed changes

graphite-app bot merged commit 79a9118 into main Nov 13, 2025
25 checks passed

graphite-app bot deleted the copilot/add-module-exports-support branch November 13, 2025 07:56

graphite-app bot removed the graphite: merge label Nov 13, 2025

sapphi-red mentioned this pull request Nov 13, 2025

[Feature Request]: module.exports export support #4997

Closed

This was referenced Nov 18, 2025

release: v1.0.0-beta.51 #7106

Closed

release: v1.0.0-beta.51 #7121

Closed

release: v1.0.0-beta.51 #7124

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: support Node.js `module.exports` ESM export #6967

feat: support Node.js `module.exports` ESM export #6967

Copilot AI commented Nov 12, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 12, 2025

Uh oh!

netlify bot commented Nov 12, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sapphi-red commented Nov 12, 2025

Uh oh!

Copilot AI commented Nov 12, 2025

Uh oh!

sapphi-red commented Nov 12, 2025

Uh oh!

Copilot AI commented Nov 12, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

hyf0 commented Nov 13, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: support Node.js module.exports ESM export #6967

feat: support Node.js module.exports ESM export #6967

Conversation

Copilot AI commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Plan for module.exports export support ✅

Implementation Summary

Changes Made

Test Results

What does the proposed API look like?

Comments on the Issue (you are @copilot in this section)

Uh oh!

graphite-app bot commented Nov 12, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sapphi-red commented Nov 12, 2025

Uh oh!

Copilot AI commented Nov 12, 2025

Uh oh!

sapphi-red commented Nov 12, 2025

Uh oh!

Copilot AI commented Nov 12, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

hyf0 commented Nov 13, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

feat: support Node.js `module.exports` ESM export #6967

feat: support Node.js `module.exports` ESM export #6967

Copilot AI commented Nov 12, 2025 •

edited

Loading

netlify bot commented Nov 12, 2025 •

edited

Loading

hyf0 commented Nov 13, 2025 •

edited by graphite-app bot

Loading