chore: rename rolldown_watcher to rolldown_fs_watcher
#6958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
✅ Deploy Preview for rolldown-rs canceled.
|
Contributor
Benchmarks Rust |
sapphi-red
approved these changes
Nov 12, 2025
Contributor
Merge activity
|
- `rolldown_watcher` is confusing due to the `watch mode` in Rolldown. We have a `Watcher` struct that's for `watch mode`. - Just for the clarity, `rolldown_watcher`is renamed to`rolldown_fs_watcher` to emphasize its' responsibility and scope. - `rolldown_watcher` might be used in the future to carry the implementation of the `watch mode`. But let's wait for #6482 to do it.
graphite-app
bot
force-pushed
the
11-12-chore_rename_rolldown_watcher_to_rolldown_fs_watcher_
branch
from
d58d572 to
4c83693
Compare
shulaoda
approved these changes
Nov 12, 2025
graphite-app
bot
deleted the
11-12-chore_rename_rolldown_watcher_to_rolldown_fs_watcher_
branch
shulaoda
pushed a commit
that referenced
this pull request
Nov 12, 2025
## [1.0.0-beta.50] - 2025-11-12 ### 🚀 Features - rolldown: oxc_resolver v11.13.2 (#6956) by @Boshen - rolldown: oxc v0.97.0 (#6940) by @Boshen ### 🐛 Bug Fixes - handle error when creating output chunk directories (#6953) by @sapphi-red - throw error if `experimental.hmr` is set for APIs other than `dev` (#6860) by @Copilot - apply output.paths transformation to chunk.imports and generated code (#6923) by @Copilot ### 🚜 Refactor - use `anyhow::Context::context` where applicable (#6952) by @sapphi-red - dev: use actor design pattern and allow to recover from intial build error (#6936) by @hyf0 ### 📚 Documentation - add sitemap (#6929) by @mdong1909 ### 🧪 Testing - validate publishConfig.exports matches exports field (#6950) by @Copilot - re-enable output/paths/function test (#6934) by @Copilot ### ⚙️ Miscellaneous Tasks - rename `rolldown_watcher` to `rolldown_fs_watcher` (#6958) by @hyf0 - enable trust policy (#6948) by @iiio2 - deps: update napi (#6951) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.17.6 (#6947) by @renovate[bot] - deps: update npm packages (#6937) by @renovate[bot] - deps: update dependency tsdown to v0.16.2 (#6933) by @renovate[bot] ### ❤️ New Contributors * @mdong1909 made their first contribution in [#6929](#6929) Co-authored-by: sapphi-red <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rolldown_watcheris confusing due to thewatch modein Rolldown. We have aWatcherstruct that's forwatch mode.rolldown_watcheris renamed torolldown_fs_watcherto emphasize its' responsibility and scope.rolldown_watchermight be used in the future to carry the implementation of thewatch mode. But let's wait for Watch mode issue collection #6482 to do it.