test: re-enable output/paths/function test #6934

Copilot · 2025-11-11T08:32:33Z

Re-enables the previously skipped fixture.test.ts > output/paths/function test by removing the skip: true flag.

Changes Made

Test Re-enabled: Removed skip: true from packages/rolldown/tests/fixtures/output/paths/function/_config.ts
Dependency Reverted: Kept tsdown at version 0.16.1 (did not upgrade to 0.16.2 from main branch rebase)

Background

The test was previously disabled due to flaky timeout issues (timing out at 60 seconds). The test has been re-enabled without implementing a timeout fix in the Rust code, as the timeout changes to crates/rolldown_binding/src/types/js_callback.rs were reverted per review feedback.

Note: The test may still be susceptible to the original flaky timeout issue since no timeout protection was added to the invoke_sync method's cvar.wait() call.

Testing

✅ Build process completes successfully
✅ Test output/paths/generate-bundle-imports-function passes (similar paths function test)
Relates to Flaky test fixture.test.ts > output/paths/function #6737

Original prompt

This section details on the original issue you should resolve

<issue_title>Flaky test fixture.test.ts > output/paths/function</issue_title>
<issue_description>Not sure why, but it keeps showing up recently

https://github.com/rolldown/rolldown/runs/53880575830</issue_description>

Comments on the Issue (you are @copilot in this section)
@sapphi-red I wonder if this is related to https://github.com//pull/6474. `cvar.wait` is possibly hanging for some reason. @IWANABETHATGUY > I wonder if this is related to [#6474](https://github.com//pull/6474). `cvar.wait` is possibly hanging for some reason.
Probably, but I never reproduce it locally.</comment_new>

Fixes Flaky test fixture.test.ts > output/paths/function #6737

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

graphite-app · 2025-11-11T08:32:38Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

IWANABETHATGUY · 2025-11-11T08:33:07Z

@copilot just rebase the main branch and reenable the test

netlify · 2025-11-11T08:33:39Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`c691295`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/691307d27234ca00097a847c

Copilot · 2025-11-11T09:06:16Z

@copilot just rebase the main branch and reenable the test

Done. Rebased on main and re-enabled the test in commit 25d2be9. The test now passes successfully - verified with the full test suite (338 tests passed).

pnpm-workspace.yaml

crates/rolldown_binding/src/types/js_callback.rs

Co-authored-by: IWANABETHATGUY <[email protected]>

github-actions · 2025-11-11T09:34:14Z

Benchmarks Rust

target: main(1add1a2)
pr: copilot/fix-flaky-test-issue(bf89948)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.02     69.7±3.08ms        ? ?/sec    1.00     68.6±2.67ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     76.1±3.56ms        ? ?/sec    1.00     74.6±2.84ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    112.5±3.05ms        ? ?/sec    1.00    112.5±2.83ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    126.1±3.25ms        ? ?/sec    1.01    127.0±3.20ms        ? ?/sec
bundle/bundle@threejs                                        1.00     42.8±2.79ms        ? ?/sec    1.02     43.8±1.38ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.02     45.6±1.45ms        ? ?/sec    1.00     44.6±1.36ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    407.2±6.64ms        ? ?/sec    1.00    406.4±7.15ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    467.6±5.78ms        ? ?/sec    1.00    465.0±5.21ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.0±2.19ms        ? ?/sec    1.01     88.2±3.95ms        ? ?/sec
scan/scan@threejs                                            1.01     29.6±1.92ms        ? ?/sec    1.00     29.2±0.59ms        ? ?/sec
scan/scan@threejs10x                                         1.00    302.9±4.98ms        ? ?/sec    1.01    304.8±4.31ms        ? ?/sec

@Boshen

## [1.0.0-beta.50] - 2025-11-12 ### 🚀 Features - rolldown: oxc_resolver v11.13.2 (#6956) by @Boshen - rolldown: oxc v0.97.0 (#6940) by @Boshen ### 🐛 Bug Fixes - handle error when creating output chunk directories (#6953) by @sapphi-red - throw error if `experimental.hmr` is set for APIs other than `dev` (#6860) by @Copilot - apply output.paths transformation to chunk.imports and generated code (#6923) by @Copilot ### 🚜 Refactor - use `anyhow::Context::context` where applicable (#6952) by @sapphi-red - dev: use actor design pattern and allow to recover from intial build error (#6936) by @hyf0 ### 📚 Documentation - add sitemap (#6929) by @mdong1909 ### 🧪 Testing - validate publishConfig.exports matches exports field (#6950) by @Copilot - re-enable output/paths/function test (#6934) by @Copilot ### ⚙️ Miscellaneous Tasks - rename `rolldown_watcher` to `rolldown_fs_watcher` (#6958) by @hyf0 - enable trust policy (#6948) by @iiio2 - deps: update napi (#6951) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.17.6 (#6947) by @renovate[bot] - deps: update npm packages (#6937) by @renovate[bot] - deps: update dependency tsdown to v0.16.2 (#6933) by @renovate[bot] ### ❤️ New Contributors * @mdong1909 made their first contribution in [#6929](#6929) Co-authored-by: sapphi-red <[email protected]>

Copilot AI assigned Copilot and IWANABETHATGUY Nov 11, 2025

Copilot started work on behalf of IWANABETHATGUY November 11, 2025 08:33 View session

Copilot AI changed the title ~~[WIP] Fix flaky test in fixture.test.ts~~ fix: add timeout to invoke_sync to prevent indefinite hangs Nov 11, 2025

Copilot AI requested a review from IWANABETHATGUY November 11, 2025 09:00

Copilot finished work on behalf of IWANABETHATGUY November 11, 2025 09:00

Copilot started work on behalf of IWANABETHATGUY November 11, 2025 09:00 View session

Copilot finished work on behalf of IWANABETHATGUY November 11, 2025 09:08

IWANABETHATGUY reviewed Nov 11, 2025

View reviewed changes

pnpm-workspace.yaml Show resolved Hide resolved

IWANABETHATGUY requested changes Nov 11, 2025

View reviewed changes

crates/rolldown_binding/src/types/js_callback.rs Show resolved Hide resolved

Copilot AI and others added 3 commits November 11, 2025 17:21

Add timeout to invoke_sync to prevent indefinite hangs

6a9779b

Co-authored-by: IWANABETHATGUY <[email protected]>

Run cargo fmt to fix formatting

e4520ad

Co-authored-by: IWANABETHATGUY <[email protected]>

Rebase on main and re-enable output/paths/function test

bf89948

Co-authored-by: IWANABETHATGUY <[email protected]>

IWANABETHATGUY force-pushed the copilot/fix-flaky-test-issue branch from 25d2be9 to bf89948 Compare November 11, 2025 09:21

Copilot started work on behalf of IWANABETHATGUY November 11, 2025 09:21 View session

Copilot AI and others added 3 commits November 11, 2025 09:26

Initial plan

167349d

Initial plan

f15132e

Revert tsdown version from 0.16.2 to 0.16.1

042b9f4

Co-authored-by: IWANABETHATGUY <[email protected]>

Copilot finished work on behalf of IWANABETHATGUY November 11, 2025 09:28

Copilot AI requested a review from IWANABETHATGUY November 11, 2025 09:28

Copilot started work on behalf of IWANABETHATGUY November 11, 2025 09:28 View session

Revert js_callback.rs timeout changes

f3bc7cd

Co-authored-by: IWANABETHATGUY <[email protected]>

Copilot AI changed the title ~~fix: add timeout to invoke_sync to prevent indefinite hangs~~ test: re-enable output/paths/function test Nov 11, 2025

Copilot finished work on behalf of IWANABETHATGUY November 11, 2025 09:35

chore: 🤖 update

c691295

IWANABETHATGUY marked this pull request as ready for review November 11, 2025 09:54

IWANABETHATGUY requested review from hyf0 and sapphi-red November 11, 2025 09:54

hyf0 approved these changes Nov 11, 2025

View reviewed changes

IWANABETHATGUY enabled auto-merge (squash) November 11, 2025 10:12

IWANABETHATGUY approved these changes Nov 11, 2025

View reviewed changes

IWANABETHATGUY merged commit 5832107 into main Nov 11, 2025
25 checks passed

IWANABETHATGUY deleted the copilot/fix-flaky-test-issue branch November 11, 2025 10:14

github-actions bot mentioned this pull request Nov 12, 2025

release: v1.0.0-beta.50 #6962

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test: re-enable output/paths/function test #6934

test: re-enable output/paths/function test #6934

Uh oh!

Copilot AI commented Nov 11, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Nov 11, 2025

Uh oh!

IWANABETHATGUY commented Nov 11, 2025

Uh oh!

netlify bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

Copilot AI commented Nov 11, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

test: re-enable output/paths/function test #6934

test: re-enable output/paths/function test #6934

Uh oh!

Conversation

Copilot AI commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes Made

Background

Testing

Comments on the Issue (you are @copilot in this section)

Uh oh!

graphite-app bot commented Nov 11, 2025

How to use the Graphite Merge Queue

Uh oh!

IWANABETHATGUY commented Nov 11, 2025

Uh oh!

netlify bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

Copilot AI commented Nov 11, 2025

Uh oh!

Uh oh!

Uh oh!

github-actions bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Nov 11, 2025 •

edited

Loading

netlify bot commented Nov 11, 2025 •

edited

Loading

github-actions bot commented Nov 11, 2025 •

edited

Loading