Skip to content

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Nov 7, 2025

I noticed this while I was working around the code. Rollup has the concept of build​ stage/phase. Rolldown followed this abstraction subconsciously.

The previous lifecycle of Build​ includes build​ + generate​ stages, which is improper, so we use bundle​ as the concept of finishing the process that starts from build​ and end with generate​.

@hyf0 hyf0 marked this pull request as ready for review November 7, 2025 19:01
Copy link
Member Author

hyf0 commented Nov 7, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 changed the title refactor(rust): rename BuildFactor/Build to BundleFacory/Bundle refactor(rust): rename BuildFactor/Build to BundleFactory/Bundle Nov 7, 2025
@hyf0 hyf0 changed the title refactor(rust): rename BuildFactor/Build to BundleFactory/Bundle refactor(rust): rename BuildFactory/Build to BundleFactory/Bundle Nov 7, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2025

Benchmarks Rust

  • target: main(94026e8)
  • pr: 11-08-refactor_rust_rename_buildfactor_build_to_bundlefacory_bundle_(82854e4)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     64.9±1.89ms        ? ?/sec    1.03     66.6±2.03ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     71.2±1.93ms        ? ?/sec    1.02     72.9±1.74ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    108.3±1.80ms        ? ?/sec    1.01    109.0±1.94ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    120.8±2.82ms        ? ?/sec    1.01    121.8±1.98ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.2±2.40ms        ? ?/sec    1.00     40.3±2.30ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.1±0.77ms        ? ?/sec    1.01     43.4±0.70ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    393.8±6.12ms        ? ?/sec    1.01    397.3±6.18ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    452.1±4.93ms        ? ?/sec    1.01    454.4±4.85ms        ? ?/sec
scan/scan@rome_ts                                            1.01     89.1±1.91ms        ? ?/sec    1.00     87.8±1.90ms        ? ?/sec
scan/scan@threejs                                            1.00     29.3±0.50ms        ? ?/sec    1.02     30.0±2.04ms        ? ?/sec
scan/scan@threejs10x                                         1.01    306.2±4.36ms        ? ?/sec    1.00    304.3±5.00ms        ? ?/sec

@graphite-app graphite-app bot changed the base branch from 11-08-refactor_rust_tweak_incremental_build_related_methods_of_bundler_ to graphite-base/6886 November 7, 2025 19:48
@graphite-app graphite-app bot force-pushed the graphite-base/6886 branch from 7f475b9 to 94026e8 Compare November 7, 2025 20:03
@graphite-app graphite-app bot force-pushed the 11-08-refactor_rust_rename_buildfactor_build_to_bundlefacory_bundle_ branch from 039631c to 67d1cfb Compare November 7, 2025 20:03
@graphite-app graphite-app bot changed the base branch from graphite-base/6886 to main November 7, 2025 20:04
@graphite-app graphite-app bot force-pushed the 11-08-refactor_rust_rename_buildfactor_build_to_bundlefacory_bundle_ branch from 67d1cfb to a365f88 Compare November 7, 2025 20:04
@netlify
Copy link

netlify bot commented Nov 7, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 82854e4
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/690ed49508b035000881b28f

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 8, 2025

Merge activity

…#6886)

I noticed this while I was working around the code. Rollup has the concept of `build`​ stage/phase. Rolldown followed this abstraction subconsciously.

The previous lifecycle of `Build`​ includes `build`​ + `generate`​ stages, which is improper, so we use `bundle`​ as the concept of finishing the process that starts from `build`​ and end with `generate`​.
@graphite-app graphite-app bot force-pushed the 11-08-refactor_rust_rename_buildfactor_build_to_bundlefacory_bundle_ branch from a365f88 to 82854e4 Compare November 8, 2025 05:26
@graphite-app graphite-app bot merged commit 82854e4 into main Nov 8, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 11-08-refactor_rust_rename_buildfactor_build_to_bundlefacory_bundle_ branch November 8, 2025 05:40
graphite-app bot pushed a commit that referenced this pull request Nov 9, 2025
shulaoda added a commit that referenced this pull request Nov 10, 2025
## [1.0.0-beta.48] - 2025-11-10

:boom: Breaking Changes

- `this.emitFile` now respects `chunkFileNames` for chunk type
```js
// rolldown.config.js
export default {
  output: {
    chunkFileNames: 'chunks/[name]-[hash].js'
  }
}

// In plugin
this.emitFile({
  type: 'chunk',
  id: './my-module.js'
});

// Before: Output might not follow chunkFileNames pattern
// After: Output follows 'chunks/[name]-[hash].js' pattern
```

- Deprecated top-level options removed
  - `define` → `transform.define`
  - `inject` → `transform.inject`
  - `dropLabels` → `transform.dropLabels`
  - `keepNames` → `output.keepNames`
  - `profilerNames` → `output.generatedCode.profilerNames`

- Stable plugins moved from experimental
```js
// Before
import { replacePlugin, esmExternalRequirePlugin } from 'rolldown/experimental';

// After
import { replacePlugin, esmExternalRequirePlugin } from 'rolldown/plugins';
```

- `RolldownBuild#scan` is removed, now only available from `rolldown/experimental`
```js
// Before: scan was a method on RolldownBuild
const build = await rolldown(config);
await build.scan();

// After: import scan from rolldown/experimental
import { scan } from 'rolldown/experimental';
await scan(config);
```

### 💥 BREAKING CHANGES

- `this.emitFile` does not respect `chunkFileNames` (#6868) by @Copilot
- remove deprecated top-level `dropLabels` option (#6915) by @sapphi-red
- remove deprecated top-level `keepNames` option (#6914) by @sapphi-red
- remove deprecated top-level `profilerNames` option (#6913) by @sapphi-red
- remove deprecated top-level `define` and `inject` options (#6912) by @sapphi-red
- move stable plugins from experimental to `rolldown/plugins` (#6303) by @shulaoda
- node: remove experimental `RolldownBuild#scan`, only expose it from `rolldown/experimental` (#6889) by @hyf0

### 🚀 Features

- add side-effect detection for global constructors with primitive arguments (#6898) by @IWANABETHATGUY
- rust: use `BundleMode` to handle incremental build exhaustively (#6894) by @hyf0
- detect side-effect-free global function calls (#6897) by @IWANABETHATGUY
- expose `parseSync` / `parseAsync` function (#6866) by @sapphi-red
- skip `__toESM` helper when only named imports are used from CJS modules (#6850) by @Copilot
- rolldown_binding: expose `htmlInlineProxyPlugin` (#6856) by @shulaoda
- rolldown_plugin_html_inline_proxy: align `load` hook logic (#6855) by @shulaoda
- rolldown_plugin_html_inline_proxy: align `resolveId` hook logic (#6854) by @shulaoda
- rolldown_plugin_html_inline_proxy: initialize (#6853) by @shulaoda

### 🐛 Bug Fixes

- cli: support nested options in CLI properly (#6911) by @sapphi-red
- debug: ensure injecting `hook_resolve_id_trigger` correctly (#6908) by @hyf0
- use chunk-specific exports for entry module export detection (#6904) by @IWANABETHATGUY
- debug: ensure build get injected and add tests (#6896) by @hyf0
- error: return friendly error for bundler already closed scenario (#6878) by @hyf0
- improve dynamic entry processing with iterative approach (#6869) by @IWANABETHATGUY
- handle tsconfig option resolve error (#6871) by @sapphi-red
- handle error when creating output chunk directories (#6870) by @sapphi-red
- node: `NormalizedOutputOptionsImpl` and `NormalizedInputOptionsImpl` enumerable (#6861) by @hyf0
- node: keys of `RolldownOutput` should be enumerable (#6852) by @Copilot

### 🚜 Refactor

- rust: rename `BundleContext` to `BundleHandle` (#6893) by @hyf0
- rust: rename `build_span` to `bundle_span` (#6892) by @hyf0
- rust: introduce `PluginDriverFactory` to manage creation of `PluginDriver` (#6891) by @hyf0
- crates/rolldown_binding: remove useless `BindingBundlerImpl` (#6888) by @hyf0
- crates/rolldown_binding: rename `Bundler` to `ClassicBundler` and clarify the purpose (#6887) by @hyf0
- rust: rename `BuildFactory/Build` to `BundleFactory/Bundle` (#6886) by @hyf0
- rust: tweak incremental build related methods of `Bundler` (#6884) by @hyf0
- rust: manage build via `BuildFactory` for `Bundler` (#6883) by @hyf0
- node: implement a new `Bundler` that satisfy the usage of `RolldownBuild` (#6877) by @hyf0
- node: remove useless `nonEnumerable` decorator (#6862) by @hyf0

### 📚 Documentation

- add documentation for native replace plugin (#6315) by @shulaoda
- in-depth/directives: expand description of how directives are handled (#6882) by @sapphi-red
- in-depth/bundling-cjs: clarify the condition of `default` export interop (#6875) by @sapphi-red
- add troubleshooting section for `this` in exported functions (#6865) by @sapphi-red
- update prebuilt binaries list based on Node 24 platform support tier (#6864) by @sapphi-red
- remove unsupported [ext] placeholder from entryFileNames and chunkFileNames (#6859) by @Copilot

### ⚡ Performance

- rolldown: improve sourcemap chain processing (#6858) by @Brooooooklyn

### 🧪 Testing

- add test case for issue #6881 with scientific notation (#6906) by @IWANABETHATGUY

### ⚙️ Miscellaneous Tasks

- deps: update npm packages (#6918) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.17.5 (#6917) by @renovate[bot]
- deps: lock file maintenance (#6907) by @renovate[bot]
- deps: update rust crates (#6905) by @renovate[bot]
- deps: update npm packages (#6903) by @renovate[bot]
- deps: update github-actions (#6902) by @renovate[bot]
- deps: update `oxc_resolver` and `oxc_resolver_napi` (#6901) by @shulaoda
- deps: update dependency rolldown-plugin-dts to v0.17.4 (#6895) by @renovate[bot]
- deps: update dependency tsdown to v0.16.1 (#6885) by @renovate[bot]
- deps: upgrade napi to remove linker args that skip missing symbols (#6867) by @Boshen

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants