fix(rolldown_binding): resolveDependencies shouldn't return Promise #6844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2025
Member
Author
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
hyf0
approved these changes
Nov 4, 2025
Contributor
Benchmarks Rust
|
graphite-app
bot
force-pushed
the
11-04-refactor_rolldown_plugin_vite_html_use_module_preload_instead
branch
2 times, most recently
from
7349bad to
129b7b9
Compare
graphite-app
bot
force-pushed
the
11-04-fix_rolldown_binding_resolvedependencies_shouldn_t_return_promise
branch
from
b2f5447 to
c7a6e14
Compare
graphite-app
bot
changed the base branch from
11-04-refactor_rolldown_plugin_vite_html_use_module_preload_instead
to
graphite-base/6844
Contributor
Merge activity
|
shulaoda
force-pushed
the
11-04-fix_rolldown_binding_resolvedependencies_shouldn_t_return_promise
branch
from
c7a6e14 to
9dfe37d
Compare
shulaoda
force-pushed
the
graphite-base/6844
branch
from
129b7b9 to
ceb0c00
Compare
shulaoda
changed the base branch from
graphite-base/6844
to
11-04-refactor_rolldown_plugin_vite_html_use_module_preload_instead
Base automatically changed from
11-04-refactor_rolldown_plugin_vite_html_use_module_preload_instead
to
main
November 4, 2025 14:50
graphite-app
bot
force-pushed
the
11-04-fix_rolldown_binding_resolvedependencies_shouldn_t_return_promise
branch
from
9dfe37d to
bb5391a
Compare
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shulaoda
deleted the
11-04-fix_rolldown_binding_resolvedependencies_shouldn_t_return_promise
branch
shulaoda
added a commit
that referenced
this pull request
Nov 5, 2025
## [1.0.0-beta.47] - 2025-11-05 ### 💥 BREAKING CHANGES - `meta.magicString` and `meta.ast` now only initialized once (#6828) by @IWANABETHATGUY ### 🚀 Features - rolldown_plugin_utils: support common module preload config (#6839) by @shulaoda - expose `minify` function (#6836) by @sapphi-red - rolldown_plugin_build_import_analysis: remove all `__VITE_PRELOAD__` (#6833) by @shulaoda - rolldown_plugin_build_import_analysis: inject __vite__mapDeps (#6832) by @shulaoda - rolldown_plugin_build_import_analysis: align partial logic (#6831) by @shulaoda - expose more magic string method in js binding (#6819) by @IWANABETHATGUY - rolldown_plugin_build_import_analysis: align renderBuiltUrl logic (#6808) by @shulaoda - rolldown_plugin_build_import_analysis: align resolve dependencies logic (#6803) by @shulaoda - rolldown_plugin_build_import_analysis: align partial logic (#6802) by @shulaoda ### 🐛 Bug Fixes - rolldown_plugin_build_import_analysis: correct unaligned code (#6845) by @shulaoda - rolldown_binding: resolveDependencies shouldn't return Promise (#6844) by @shulaoda - browser: correct binding file (#6830) by @sxzz ### 🚜 Refactor - rolldown_plugin_vite_html: use module preload instead (#6843) by @shulaoda - rolldown_plugin_build_import_analysis: use module preload config instead (#6841) by @shulaoda - rolldown_binding: correct `renderBuiltUrl` (#6835) by @shulaoda - rolldown_plugin_build_import_analysis: remove unnecessary is_module_preload (#6834) by @shulaoda - rolldown_plugin_build_import_analysis: remove unnecessary `IS_MODERN_FLAG` (#6823) by @shulaoda - rolldown_plugin_build_import_analysis: tweak v2 config (#6804) by @shulaoda ### 📚 Documentation - add link to Native MagicString In-Depth Guide and fix broken markdown syntax (#6827) by @IWANABETHATGUY - update current status of native magic string (#6820) by @IWANABETHATGUY - add specific use cases (#6822) by @shulaoda - add minification preservation instructions for banner/footer options (#6786) by @ZiuChen ### ⚙️ Miscellaneous Tasks - deps: bump oxc-resolver to v11.13.1 (#6847) by @renovate[bot] - deps: update dependency tsdown to v0.16.0 (#6840) by @renovate[bot] - README.md: fix broken documentation link to getting started guide (#6837) by @Cheng-fung ### ❤️ New Contributors * @Cheng-fung made their first contribution in [#6837](#6837) * @ZiuChen made their first contribution in [#6786](#6786) Co-authored-by: shulaoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.