fix(transform/inject): escape special characters in import source #6778

Copilot · 2025-10-30T11:39:28Z

Import specifiers in the inject option containing special characters (quotes, backslashes, control characters) generate invalid JavaScript. Example:

// Config
transform: {
  inject: { 'a': 'foo"' }
}

// Before: invalid syntax
import a from "foo"";

// After: properly escaped
import a from "foo\"";

Changes

Added escape_inject_import_specifier in rolldown_utils/src/ecmascript.rs
- Escapes \, ", \n, \r before passing to oxc's InjectGlobalVariables
- Uses double-escaping (\\n instead of \n) as workaround for oxc codegen limitation
- Cannot use serde_json::to_string as it produces single-escaped format incompatible with the workaround
Updated prepare_build_context.rs
- Applies escaping to both named and namespace inject imports
Added test case inject_escape_special_chars
- Verifies escaping for all special characters
- Includes snapshot for regression testing

Original prompt

This section details on the original issue you should resolve

<issue_title>When using inject option, import specifier is not escaped even when needed</issue_title>
<issue_description>REPL
// rolldown.config.ts
import { defineConfig } from 'rolldown' 
export default defineConfig({
  transform: {
    inject: {
      'a': 'foo"',
    },
  }
})
Input
console.log(a)
Actual
import a from "foo"";

console.log(a);
Expected
import a from "foo\"";

console.log(a);
</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes When using inject option, import specifier is not escaped even when needed #6777

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

graphite-app · 2025-10-30T11:39:33Z

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

netlify · 2025-10-30T11:40:17Z

✅ Deploy Preview for rolldown-rs canceled.

Name	Link
🔨 Latest commit	`10b5b1a`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69039350cb62760008e6011c

sapphi-red · 2025-10-30T16:04:13Z

fix(transform/inject): escape special characters in import source #6778 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

wrote myself

crates/rolldown/src/ecmascript/format/esm.rs

github-actions · 2025-10-30T16:24:02Z

Benchmarks Rust

target: main(88ef3e7)
pr: copilot/fix-import-specifier-escaping(10b5b1a)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.01     66.6±1.48ms        ? ?/sec    1.00     65.6±1.43ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.02     73.0±1.24ms        ? ?/sec    1.00     71.9±1.41ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    109.4±2.82ms        ? ?/sec    1.00    108.8±1.56ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    122.3±2.28ms        ? ?/sec    1.00    121.8±1.72ms        ? ?/sec
bundle/bundle@threejs                                        1.00     40.3±3.05ms        ? ?/sec    1.00     40.4±2.18ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     43.2±0.54ms        ? ?/sec    1.00     43.2±0.61ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    395.3±5.09ms        ? ?/sec    1.00    396.8±6.27ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    455.1±5.41ms        ? ?/sec    1.00    454.1±3.64ms        ? ?/sec
scan/scan@rome_ts                                            1.01     86.5±1.48ms        ? ?/sec    1.00     85.7±1.73ms        ? ?/sec
scan/scan@threejs                                            1.01     29.1±0.34ms        ? ?/sec    1.00     29.0±0.46ms        ? ?/sec
scan/scan@threejs10x                                         1.01    302.1±4.34ms        ? ?/sec    1.00    300.2±4.36ms        ? ?/sec

graphite-app · 2025-10-30T16:32:43Z

Merge activity

Oct 30, 4:32 PM UTC: sapphi-red added this pull request to the Graphite merge queue.
Oct 30, 4:47 PM UTC: Merged by the Graphite merge queue.

) Import specifiers in the `inject` option containing special characters (quotes, backslashes, control characters) generate invalid JavaScript. Example: ```typescript // Config transform: { inject: { 'a': 'foo"' } } // Before: invalid syntax import a from "foo""; // After: properly escaped import a from "foo\""; ``` ## Changes - **Added `escape_inject_import_specifier` in `rolldown_utils/src/ecmascript.rs`** - Escapes `\`, `"`, `\n`, `\r` before passing to oxc's `InjectGlobalVariables` - Uses double-escaping (`\\n` instead of `\n`) as workaround for oxc codegen limitation - Cannot use `serde_json::to_string` as it produces single-escaped format incompatible with the workaround - **Updated `prepare_build_context.rs`** - Applies escaping to both named and namespace inject imports - **Added test case `inject_escape_special_chars`** - Verifies escaping for all special characters - Includes snapshot for regression testing  <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>When using inject option, import specifier is not escaped even when needed</issue_title> > <issue_description>[REPL](https://repl.rolldown.rs/#eNptT0kKwzAM/IrQxS2EPMDQNxR69sUkcnFxpOCoG8F/r9t0gxYE0mgZzcwY0M4YuadLq9O9ZrQf3GBXYSc8SaI2yX7l1y47rgNCq/lIpcEsKfVy5rbuhbj/4vkzWRjjMEpW0OtIMMPuubYdNdZXUCBkGcC8zg04dnxXobAw2Z+bDcyOATR7noLkwS4YIPKBOn1DAOONBRNEHJpmaZZHLo5rOKbLQ1xPwR/T62P1XKrXUxWfvNKkWG6v0GtR) > > ```ts > // rolldown.config.ts > import { defineConfig } from 'rolldown' > export default defineConfig({ > transform: { > inject: { > 'a': 'foo"', > }, > } > }) > ``` > > ### Input > ```js > console.log(a) > ``` > > ### Actual > ```js > import a from "foo""; > > console.log(a); > ``` > > ### Expected > ```js > import a from "foo\""; > > console.log(a); > ``` > </issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes #6777  --- 💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more [Copilot coding agent tips](https://gh.io/copilot-coding-agent-tips) in the docs.

@sapphi-red

## [1.0.0-beta.46] - 2025-11-03 ### 💥 BREAKING CHANGES - default `preserveEntrySignatures` to `'exports-only'` to align with Rollup (#6723) by @Copilot ### 🚀 Features - link to docs for commonjs prefer_builtin_feature diagnostic (#6793) by @sapphi-red - rolldown_plugin_build_import_analysis: align partial logic (#6789) by @shulaoda - improve `EVAL` warning message (#6776) by @sapphi-red - rolldown: oxc v0.96.0 (#6774) by @Boshen - rolldown_plugin_build_import_analysis: align partial logic (#6773) by @shulaoda - skip `__toESM` when not needed to reduce output size (#6751) by @Copilot - improve `EMPTY_IMPORT_META` warning message (#6761) by @sapphi-red - rolldown_plugin_build_import_analysis: align no preload logic (#6762) by @shulaoda - rolldown_plugin_vite_css_post: align `RemovedPureCSSFilesCache` logic (#6745) by @shulaoda - rolldown_plugin_build_import_analysis: initialize `generateBundle` logic (#6744) by @shulaoda - experimental: introduce `freeExternalMemory` to free external memory immediately (#6721) by @hyf0 ### 🐛 Bug Fixes - plugins: wrap replacePlugin with makeBuiltinPluginCallable (#6782) by @huang-julien - debug: make sure `this.resolve` is also tracked under corresponding session (#6798) by @hyf0 - legal comments above directives are not preserved (#6787) by @shulaoda - panic when rendering exports to other chunks (#6765) by @Copilot - transform/inject: escape special characters in import source (#6778) by @Copilot - handle default exports from CJS modules correctly (#6767) by @IWANABETHATGUY - rolldown_plugin_build_import_analysis: correct aligned logic (#6768) by @shulaoda - duplicate default export when using both import and require (#6764) by @Copilot - handle arbitrary module namespace identifiers in `preserveEntrySignatures: 'allow-extension'` (#6753) by @Copilot - TypeError when loading CJS files after bundling mixed CJS+TS project (#6743) by @IWANABETHATGUY - add warnings for import.meta.dirname/filename/url in UMD and IIFE formats (#6747) by @Copilot - rolldown_plugin_manifest: should keep `names` field (#6742) by @shulaoda - legal comments above import statements are not preserved (#6717) by @shulaoda - remove redundant node check in dynamic entry graph construction (#6730) by @IWANABETHATGUY ### 🚜 Refactor - remove unnecessary `#[napi(gettter)]`, use function call directly (#6694) by @hyf0 - explain the reason if memory doesn't get dropped by `freeExternalMemory` (#6781) by @hyf0 - pre compute exports (#6755) by @IWANABETHATGUY - dev: receive an interface for DevRuntime rather than WebSocket directly (#6734) by @sapphi-red - dev: fix types for the runtime file and expose it properly (#6731) by @sapphi-red ### 📚 Documentation - fix magicstring credit (#6812) by @TheAlexLichter - in-depth/bundling-cjs: wrap some sections with caveats section (#6796) by @sapphi-red - in-depth/bundling-cjs: add "Ambiguous `default` import from CJS modules" section (#6795) by @sapphi-red - in-depth/bundling-cjs: make `esmExternalRequirePlugin` link more prominent (#6792) by @sapphi-red - add explanation about direct eval (#6775) by @sapphi-red - add "Non-ESM Output Formats" page (#6760) by @sapphi-red - use oxc for benchmark comparison in native magic string doc (#6740) by @sapphi-red - polish `cleanDir` option (#6741) by @hyf0 - fix image in native magic string doc (#6739) by @sapphi-red - update description about `attachDebugInfo: 'none'` (#6738) by @IWANABETHATGUY - add warning about cleanDir behavior with multiple configs (#6735) by @Copilot ### 🧪 Testing - skip paths function test (#6771) by @IWANABETHATGUY - rust/dev: add test about recover from initial build error (#6567) by @hyf0 ### ⚙️ Miscellaneous Tasks - correct prepare release binding file (#6817) by @shulaoda - deps: update github-actions (#6806) by @renovate[bot] - deps: lock file maintenance npm packages (#6814) by @renovate[bot] - use correct node version (#6809) by @shulaoda - deps: lock file maintenance rust crates (#6815) by @renovate[bot] - deps: update npm packages (major) (#6813) by @renovate[bot] - deps: update dependency dprint-typescript to v0.95.12 (#6805) by @renovate[bot] - fix typo (#6801) by @iiio2 - fix typo in is_import_expr_ignored_by_comment method name (#6797) by @sapphi-red - deps: update crate-ci/typos action to v1.39.0 (#6794) by @renovate[bot] - deps: upgrade Rust to v1.91.0 and fix new clippy lints (#6785) by @Copilot - allow dprint to format `packages/rolldown/tests` except diagnostics directory (#6772) by @Copilot - deps: update dependency tsdown to v0.15.12 (#6759) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.17.3 (#6758) by @renovate[bot] - test/dev: collect multiple build outputs for each step (#6736) by @hyf0 - rolldown: change the NAPI-RS binding file to the cjs (#6688) by @Brooooooklyn - test: automatically run extra test with `preserve_entry_signatures: 'allow-extension'` (#6727) by @Copilot - deps: update dependency rolldown-plugin-dts to v0.17.2 (#6732) by @renovate[bot] - fix node validation (#6728) by @shulaoda - deps: lock file maintenance rust crates (#6636) by @renovate[bot] - deps: update dependency tsdown to v0.15.11 (#6725) by @renovate[bot] ### ❤️ New Contributors * @huang-julien made their first contribution in [#6782](#6782) Co-authored-by: shulaoda <[email protected]>

Copilot AI assigned Copilot and sapphi-red Oct 30, 2025

Copilot started work on behalf of sapphi-red October 30, 2025 11:39 View session

Copilot AI changed the title ~~[WIP] Fix import specifier escaping for inject option~~ Fix inject option: escape special characters in import specifiers Oct 30, 2025

Copilot AI requested a review from sapphi-red October 30, 2025 12:15

Copilot finished work on behalf of sapphi-red October 30, 2025 12:15

sapphi-red changed the title ~~Fix inject option: escape special characters in import specifiers~~ fix(transform/inject): escape special characters in import source Oct 30, 2025

sapphi-red force-pushed the copilot/fix-import-specifier-escaping branch from 214718a to 4ea67fd Compare October 30, 2025 16:03

sapphi-red force-pushed the copilot/fix-import-specifier-escaping branch from 4ea67fd to 6ff0cb4 Compare October 30, 2025 16:06

sapphi-red previously approved these changes Oct 30, 2025

View reviewed changes

sapphi-red marked this pull request as ready for review October 30, 2025 16:07

sapphi-red requested a review from IWANABETHATGUY October 30, 2025 16:07

hyf0 reviewed Oct 30, 2025

View reviewed changes

crates/rolldown/src/ecmascript/format/esm.rs Show resolved Hide resolved

hyf0 approved these changes Oct 30, 2025

View reviewed changes

graphite-app bot force-pushed the copilot/fix-import-specifier-escaping branch from 6ff0cb4 to 10b5b1a Compare October 30, 2025 16:33

graphite-app bot merged commit 10b5b1a into main Oct 30, 2025
27 checks passed

graphite-app bot deleted the copilot/fix-import-specifier-escaping branch October 30, 2025 16:47

sapphi-red mentioned this pull request Oct 31, 2025

When using inject option, import specifier is not escaped even when needed #6777

Closed

github-actions bot mentioned this pull request Nov 3, 2025

release: v1.0.0-beta.46 #6818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(transform/inject): escape special characters in import source #6778

fix(transform/inject): escape special characters in import source #6778

Copilot AI commented Oct 30, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 30, 2025

Uh oh!

netlify bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

sapphi-red commented Oct 30, 2025

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented Oct 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

fix(transform/inject): escape special characters in import source #6778

fix(transform/inject): escape special characters in import source #6778

Conversation

Copilot AI commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Input

Actual

Expected

Comments on the Issue (you are @copilot in this section)

Uh oh!

graphite-app bot commented Oct 30, 2025

How to use the Graphite Merge Queue

Uh oh!

netlify bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs canceled.

Uh oh!

sapphi-red commented Oct 30, 2025

How to use the Graphite Merge Queue

Uh oh!

Uh oh!

github-actions bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

graphite-app bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Oct 30, 2025 •

edited

Loading

netlify bot commented Oct 30, 2025 •

edited

Loading

github-actions bot commented Oct 30, 2025 •

edited

Loading

graphite-app bot commented Oct 30, 2025 •

edited

Loading