feat!: default preserveEntrySignatures to 'exports-only' to align with Rollup
#6723
+161
−304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
How to use the Graphite Merge QueueAdd the label graphite: merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
✅ Deploy Preview for rolldown-rs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Copilot
AI
changed the title
[WIP] Align preserveEntrySignatures default value to Rollup
Align Oct 27, 2025
preserveEntrySignatures default to Rollup
Contributor
Benchmarks Rust |
Member
|
@copilot add code to |
Contributor
Author
Added the extended test variant in commit 5cc8f9a. The test framework will now automatically run an additional variant with |
sapphi-red
changed the title
preserveEntrySignatures default to RolluppreserveEntrySignatures default to Rollup
sapphi-red
changed the title
preserveEntrySignatures default to RolluppreserveEntrySignatures to 'exports-only' to align with Rollup
sapphi-red
approved these changes
Oct 27, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aligns Rolldown's default preserveEntrySignatures behavior with Rollup by changing it from 'strict' to 'exports-only'. This allows entry points without exports to be merged with shared chunks, enabling more flexible chunking and reducing output size.
Key Changes
- Changed the default
PreserveEntrySignaturesenum variant fromStricttoExportsOnly - Added automatic test variant generation with
preserveEntrySignatures: 'strict'to validate backward compatibility - Updated test snapshots to reflect new chunking patterns where entry points without exports can be merged with shared chunks
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
crates/rolldown_common/src/inner_bundler_options/types/output_option/preserve_entry_signatures.rs |
Changed the #[default] attribute from Strict to ExportsOnly variant |
crates/rolldown_testing_config/src/extended_tests.rs |
Added preserve_entry_signatures_strict field to enable automatic testing with strict mode |
crates/rolldown_testing/src/fixture.rs |
Implemented logic to automatically generate test variant with PreserveEntrySignatures::Strict |
crates/rolldown_testing/_config.schema.json |
Added schema definition for preserveEntrySignaturesStrict field |
| Multiple snapshot files | Updated to reflect new chunking behavior where fewer intermediate chunk files are generated |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
|
LGTM. FYI @IWANABETHATGUY cc |
hyf0
approved these changes
Oct 27, 2025
Member
Merge activity
|
… with Rollup (#6723) Rolldown defaulted to `strict` while Rollup defaults to `exports-only`. ## Changes - Changed default from `PreserveEntrySignatures::Strict` to `PreserveEntrySignatures::ExportsOnly` in the Rust enum - Updated test snapshots reflecting the new chunking behavior - Added extended test variant to automatically test with `preserveEntrySignatures: 'strict'` for backward compatibility validation ## Behavior With `exports-only`: - Entry points **with exports**: preserve signature (behaves like `strict`) - Entry points **without exports**: use `allow-extension` mode, enabling more flexible chunking Example: an entry with no exports can now be merged with shared chunks rather than maintaining a strict facade, reducing output size. ## Testing The extended test framework will now automatically run an additional variant with `preserveEntrySignatures: 'strict'` for all tests that don't explicitly set this option. This ensures that both the new default behavior and the previous behavior are tested, validating backward compatibility. - Fixes #6722 <!-- START COPILOT CODING AGENT SUFFIX --> <details> <summary>Original prompt</summary> > > ---- > > *This section details on the original issue you should resolve* > > <issue_title>Align `preserveEntrySignatures` default value to Rollup</issue_title> > <issue_description>It is currently `strict` by default. > https://github.com/rolldown/rolldown/blob/fecc8ee07749b742d0d86e8f4160acc6849fc1a0/crates/rolldown_common/src/inner_bundler_options/types/output_option/preserve_entry_signatures.rs#L16-L17 > Rollup defaults to `export-only`. > https://rollupjs.org/configuration-options/#preserveentrysignatures > </issue_description> > > ## Comments on the Issue (you are @copilot in this section) > > <comments> > </comments> > </details> - Fixes #6722 <!-- START COPILOT CODING AGENT TIPS --> --- 💬 We'd love your input! Share your thoughts on Copilot coding agent in our [2 minute survey](https://gh.io/copilot-coding-agent-survey).
graphite-app
bot
force-pushed
the
copilot/align-preserve-entry-signatures
branch
from
5cc8f9a to
07d9994
Compare
shulaoda
added a commit
that referenced
this pull request
Nov 3, 2025
## [1.0.0-beta.46] - 2025-11-03 ### 💥 BREAKING CHANGES - default `preserveEntrySignatures` to `'exports-only'` to align with Rollup (#6723) by @Copilot ### 🚀 Features - link to docs for commonjs prefer_builtin_feature diagnostic (#6793) by @sapphi-red - rolldown_plugin_build_import_analysis: align partial logic (#6789) by @shulaoda - improve `EVAL` warning message (#6776) by @sapphi-red - rolldown: oxc v0.96.0 (#6774) by @Boshen - rolldown_plugin_build_import_analysis: align partial logic (#6773) by @shulaoda - skip `__toESM` when not needed to reduce output size (#6751) by @Copilot - improve `EMPTY_IMPORT_META` warning message (#6761) by @sapphi-red - rolldown_plugin_build_import_analysis: align no preload logic (#6762) by @shulaoda - rolldown_plugin_vite_css_post: align `RemovedPureCSSFilesCache` logic (#6745) by @shulaoda - rolldown_plugin_build_import_analysis: initialize `generateBundle` logic (#6744) by @shulaoda - experimental: introduce `freeExternalMemory` to free external memory immediately (#6721) by @hyf0 ### 🐛 Bug Fixes - plugins: wrap replacePlugin with makeBuiltinPluginCallable (#6782) by @huang-julien - debug: make sure `this.resolve` is also tracked under corresponding session (#6798) by @hyf0 - legal comments above directives are not preserved (#6787) by @shulaoda - panic when rendering exports to other chunks (#6765) by @Copilot - transform/inject: escape special characters in import source (#6778) by @Copilot - handle default exports from CJS modules correctly (#6767) by @IWANABETHATGUY - rolldown_plugin_build_import_analysis: correct aligned logic (#6768) by @shulaoda - duplicate default export when using both import and require (#6764) by @Copilot - handle arbitrary module namespace identifiers in `preserveEntrySignatures: 'allow-extension'` (#6753) by @Copilot - TypeError when loading CJS files after bundling mixed CJS+TS project (#6743) by @IWANABETHATGUY - add warnings for import.meta.dirname/filename/url in UMD and IIFE formats (#6747) by @Copilot - rolldown_plugin_manifest: should keep `names` field (#6742) by @shulaoda - legal comments above import statements are not preserved (#6717) by @shulaoda - remove redundant node check in dynamic entry graph construction (#6730) by @IWANABETHATGUY ### 🚜 Refactor - remove unnecessary `#[napi(gettter)]`, use function call directly (#6694) by @hyf0 - explain the reason if memory doesn't get dropped by `freeExternalMemory` (#6781) by @hyf0 - pre compute exports (#6755) by @IWANABETHATGUY - dev: receive an interface for DevRuntime rather than WebSocket directly (#6734) by @sapphi-red - dev: fix types for the runtime file and expose it properly (#6731) by @sapphi-red ### 📚 Documentation - fix magicstring credit (#6812) by @TheAlexLichter - in-depth/bundling-cjs: wrap some sections with caveats section (#6796) by @sapphi-red - in-depth/bundling-cjs: add "Ambiguous `default` import from CJS modules" section (#6795) by @sapphi-red - in-depth/bundling-cjs: make `esmExternalRequirePlugin` link more prominent (#6792) by @sapphi-red - add explanation about direct eval (#6775) by @sapphi-red - add "Non-ESM Output Formats" page (#6760) by @sapphi-red - use oxc for benchmark comparison in native magic string doc (#6740) by @sapphi-red - polish `cleanDir` option (#6741) by @hyf0 - fix image in native magic string doc (#6739) by @sapphi-red - update description about `attachDebugInfo: 'none'` (#6738) by @IWANABETHATGUY - add warning about cleanDir behavior with multiple configs (#6735) by @Copilot ### 🧪 Testing - skip paths function test (#6771) by @IWANABETHATGUY - rust/dev: add test about recover from initial build error (#6567) by @hyf0 ### ⚙️ Miscellaneous Tasks - correct prepare release binding file (#6817) by @shulaoda - deps: update github-actions (#6806) by @renovate[bot] - deps: lock file maintenance npm packages (#6814) by @renovate[bot] - use correct node version (#6809) by @shulaoda - deps: lock file maintenance rust crates (#6815) by @renovate[bot] - deps: update npm packages (major) (#6813) by @renovate[bot] - deps: update dependency dprint-typescript to v0.95.12 (#6805) by @renovate[bot] - fix typo (#6801) by @iiio2 - fix typo in is_import_expr_ignored_by_comment method name (#6797) by @sapphi-red - deps: update crate-ci/typos action to v1.39.0 (#6794) by @renovate[bot] - deps: upgrade Rust to v1.91.0 and fix new clippy lints (#6785) by @Copilot - allow dprint to format `packages/rolldown/tests` except diagnostics directory (#6772) by @Copilot - deps: update dependency tsdown to v0.15.12 (#6759) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.17.3 (#6758) by @renovate[bot] - test/dev: collect multiple build outputs for each step (#6736) by @hyf0 - rolldown: change the NAPI-RS binding file to the cjs (#6688) by @Brooooooklyn - test: automatically run extra test with `preserve_entry_signatures: 'allow-extension'` (#6727) by @Copilot - deps: update dependency rolldown-plugin-dts to v0.17.2 (#6732) by @renovate[bot] - fix node validation (#6728) by @shulaoda - deps: lock file maintenance rust crates (#6636) by @renovate[bot] - deps: update dependency tsdown to v0.15.11 (#6725) by @renovate[bot] ### ❤️ New Contributors * @huang-julien made their first contribution in [#6782](#6782) Co-authored-by: shulaoda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolldown defaulted to
strictwhile Rollup defaults toexports-only.Changes
PreserveEntrySignatures::StricttoPreserveEntrySignatures::ExportsOnlyin the Rust enumpreserveEntrySignatures: 'strict'for backward compatibility validationBehavior
With
exports-only:strict)allow-extensionmode, enabling more flexible chunkingExample: an entry with no exports can now be merged with shared chunks rather than maintaining a strict facade, reducing output size.
Testing
The extended test framework will now automatically run an additional variant with
preserveEntrySignatures: 'strict'for all tests that don't explicitly set this option. This ensures that both the new default behavior and the previous behavior are tested, validating backward compatibility.preserveEntrySignaturesdefault value to Rollup #6722Original prompt
preserveEntrySignaturesdefault value to Rollup #6722💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.