refactor: remove unnecessary `#[napi(gettter)]`, use function call directly #6694

hyf0 · 2025-10-25T16:41:19Z

No description provided.

hyf0 · 2025-10-25T16:41:32Z

refactor: remove unnecessary #[napi(gettter)], use function call directly #6694 👈 (View in Graphite)
refactor(node): split transformToRollupOutput into mutable and immutable versions #6693 : 1 other dependent PR (#6695 )
main

How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

github-actions · 2025-10-25T16:55:09Z

Benchmarks Rust

target: main(ea72de1)
pr: 10-25-refactor_rename_bindingoutputchunk_asset_to_lazybindingoutputchunk_asset_(cdfcbb4)

group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     67.3±1.70ms        ? ?/sec    1.02     68.6±1.62ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     74.0±1.75ms        ? ?/sec    1.01     74.7±2.54ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    110.1±2.09ms        ? ?/sec    1.02    112.5±1.96ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    121.9±2.19ms        ? ?/sec    1.02    124.0±2.36ms        ? ?/sec
bundle/bundle@threejs                                        1.00     41.0±1.41ms        ? ?/sec    1.01     41.3±0.61ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.00     44.5±1.46ms        ? ?/sec    1.01     45.0±1.26ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    400.2±5.68ms        ? ?/sec    1.00    401.9±4.71ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.01    465.3±3.74ms        ? ?/sec    1.00    462.4±4.07ms        ? ?/sec
scan/scan@rome_ts                                            1.00     88.3±1.76ms        ? ?/sec    1.00     88.3±3.98ms        ? ?/sec
scan/scan@threejs                                            1.01     29.9±0.45ms        ? ?/sec    1.00     29.7±0.38ms        ? ?/sec
scan/scan@threejs10x                                         1.01    307.8±3.66ms        ? ?/sec    1.00    306.1±4.58ms        ? ?/sec

hyf0 · 2025-10-25T17:12:14Z

@Brooooooklyn The CI keeps failing. It works on local. I guess it's because rolldown-plugin-dts loaded the old version of rolldown binary while build.ts uses the latest javascript code of rolldown.

I'm not sure how to solve this, it seems that the most intuitive way is just swtiching to use tsc to compile the code.

netlify · 2025-10-25T18:14:23Z

✅ Deploy Preview for rolldown-rs ready!

Name	Link
🔨 Latest commit	`cdfcbb4`
🔍 Latest deploy log	https://app.netlify.com/projects/rolldown-rs/deploys/69044c62516b330008bac23e
😎 Deploy Preview	https://deploy-preview-6694--rolldown-rs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…icting binary (#6708) Solves CI problems that #6707 and #6694 encountered. Refs: - #6694 (comment)

hyf0 · 2025-10-27T07:14:14Z

#6708 solves part of the issue. Still blocked by #6718.

hyf0 · 2025-10-31T05:29:54Z

Merge activity

Oct 31, 5:29 AM UTC: The merge label 'graphite: merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Oct 31, 5:42 AM UTC: hyf0 added this pull request to the Graphite merge queue.
Oct 31, 5:56 AM UTC: Merged by the Graphite merge queue.

…rectly (#6694)

@sapphi-red

## [1.0.0-beta.46] - 2025-11-03 ### 💥 BREAKING CHANGES - default `preserveEntrySignatures` to `'exports-only'` to align with Rollup (#6723) by @Copilot ### 🚀 Features - link to docs for commonjs prefer_builtin_feature diagnostic (#6793) by @sapphi-red - rolldown_plugin_build_import_analysis: align partial logic (#6789) by @shulaoda - improve `EVAL` warning message (#6776) by @sapphi-red - rolldown: oxc v0.96.0 (#6774) by @Boshen - rolldown_plugin_build_import_analysis: align partial logic (#6773) by @shulaoda - skip `__toESM` when not needed to reduce output size (#6751) by @Copilot - improve `EMPTY_IMPORT_META` warning message (#6761) by @sapphi-red - rolldown_plugin_build_import_analysis: align no preload logic (#6762) by @shulaoda - rolldown_plugin_vite_css_post: align `RemovedPureCSSFilesCache` logic (#6745) by @shulaoda - rolldown_plugin_build_import_analysis: initialize `generateBundle` logic (#6744) by @shulaoda - experimental: introduce `freeExternalMemory` to free external memory immediately (#6721) by @hyf0 ### 🐛 Bug Fixes - plugins: wrap replacePlugin with makeBuiltinPluginCallable (#6782) by @huang-julien - debug: make sure `this.resolve` is also tracked under corresponding session (#6798) by @hyf0 - legal comments above directives are not preserved (#6787) by @shulaoda - panic when rendering exports to other chunks (#6765) by @Copilot - transform/inject: escape special characters in import source (#6778) by @Copilot - handle default exports from CJS modules correctly (#6767) by @IWANABETHATGUY - rolldown_plugin_build_import_analysis: correct aligned logic (#6768) by @shulaoda - duplicate default export when using both import and require (#6764) by @Copilot - handle arbitrary module namespace identifiers in `preserveEntrySignatures: 'allow-extension'` (#6753) by @Copilot - TypeError when loading CJS files after bundling mixed CJS+TS project (#6743) by @IWANABETHATGUY - add warnings for import.meta.dirname/filename/url in UMD and IIFE formats (#6747) by @Copilot - rolldown_plugin_manifest: should keep `names` field (#6742) by @shulaoda - legal comments above import statements are not preserved (#6717) by @shulaoda - remove redundant node check in dynamic entry graph construction (#6730) by @IWANABETHATGUY ### 🚜 Refactor - remove unnecessary `#[napi(gettter)]`, use function call directly (#6694) by @hyf0 - explain the reason if memory doesn't get dropped by `freeExternalMemory` (#6781) by @hyf0 - pre compute exports (#6755) by @IWANABETHATGUY - dev: receive an interface for DevRuntime rather than WebSocket directly (#6734) by @sapphi-red - dev: fix types for the runtime file and expose it properly (#6731) by @sapphi-red ### 📚 Documentation - fix magicstring credit (#6812) by @TheAlexLichter - in-depth/bundling-cjs: wrap some sections with caveats section (#6796) by @sapphi-red - in-depth/bundling-cjs: add "Ambiguous `default` import from CJS modules" section (#6795) by @sapphi-red - in-depth/bundling-cjs: make `esmExternalRequirePlugin` link more prominent (#6792) by @sapphi-red - add explanation about direct eval (#6775) by @sapphi-red - add "Non-ESM Output Formats" page (#6760) by @sapphi-red - use oxc for benchmark comparison in native magic string doc (#6740) by @sapphi-red - polish `cleanDir` option (#6741) by @hyf0 - fix image in native magic string doc (#6739) by @sapphi-red - update description about `attachDebugInfo: 'none'` (#6738) by @IWANABETHATGUY - add warning about cleanDir behavior with multiple configs (#6735) by @Copilot ### 🧪 Testing - skip paths function test (#6771) by @IWANABETHATGUY - rust/dev: add test about recover from initial build error (#6567) by @hyf0 ### ⚙️ Miscellaneous Tasks - correct prepare release binding file (#6817) by @shulaoda - deps: update github-actions (#6806) by @renovate[bot] - deps: lock file maintenance npm packages (#6814) by @renovate[bot] - use correct node version (#6809) by @shulaoda - deps: lock file maintenance rust crates (#6815) by @renovate[bot] - deps: update npm packages (major) (#6813) by @renovate[bot] - deps: update dependency dprint-typescript to v0.95.12 (#6805) by @renovate[bot] - fix typo (#6801) by @iiio2 - fix typo in is_import_expr_ignored_by_comment method name (#6797) by @sapphi-red - deps: update crate-ci/typos action to v1.39.0 (#6794) by @renovate[bot] - deps: upgrade Rust to v1.91.0 and fix new clippy lints (#6785) by @Copilot - allow dprint to format `packages/rolldown/tests` except diagnostics directory (#6772) by @Copilot - deps: update dependency tsdown to v0.15.12 (#6759) by @renovate[bot] - deps: update dependency rolldown-plugin-dts to v0.17.3 (#6758) by @renovate[bot] - test/dev: collect multiple build outputs for each step (#6736) by @hyf0 - rolldown: change the NAPI-RS binding file to the cjs (#6688) by @Brooooooklyn - test: automatically run extra test with `preserve_entry_signatures: 'allow-extension'` (#6727) by @Copilot - deps: update dependency rolldown-plugin-dts to v0.17.2 (#6732) by @renovate[bot] - fix node validation (#6728) by @shulaoda - deps: lock file maintenance rust crates (#6636) by @renovate[bot] - deps: update dependency tsdown to v0.15.11 (#6725) by @renovate[bot] ### ❤️ New Contributors * @huang-julien made their first contribution in [#6782](#6782) Co-authored-by: shulaoda <[email protected]>

github-actions bot assigned hyf0 Oct 25, 2025

This was referenced Oct 25, 2025

refactor(node): split transformToRollupOutput into mutable and immutable versions #6693

Merged

refactor(node): only call transformToRollupOutput when needed #6695

Merged

hyf0 changed the title ~~refactor: rename BindingOutputChunk/Asset to LazyBindingOutputChunk/Asset~~ refactor: remove unnecessary #[napi(gettter)], use function call directly Oct 25, 2025

hyf0 marked this pull request as ready for review October 25, 2025 16:43

IWANABETHATGUY approved these changes Oct 25, 2025

View reviewed changes

hyf0 mentioned this pull request Oct 25, 2025

feat(experimental): introduce freeExternalMemory to free external memory immediately #6696

Closed

graphite-app bot changed the base branch from 10-25-refactor_node_split_transformtorollupoutput_into_mutable_and_immutable_versions to graphite-base/6694 October 25, 2025 17:56

graphite-app bot force-pushed the 10-25-refactor_rename_bindingoutputchunk_asset_to_lazybindingoutputchunk_asset_ branch from 972232a to a6955af Compare October 25, 2025 18:12

graphite-app bot force-pushed the graphite-base/6694 branch from edee6df to 058627d Compare October 25, 2025 18:12

graphite-app bot changed the base branch from graphite-base/6694 to main October 25, 2025 18:12

graphite-app bot force-pushed the 10-25-refactor_rename_bindingoutputchunk_asset_to_lazybindingoutputchunk_asset_ branch from a6955af to 3384858 Compare October 25, 2025 18:12

This was referenced Oct 26, 2025

feat(node): automatically clean up external memory when calling close #6707

Closed

build(pluginutils): switch to tsc to solve the issue of loading conflicting binary #6708

Merged

graphite-app bot pushed a commit that referenced this pull request Oct 27, 2025

build(pluginutils): switch to tsc to solve the issue of loading confl…

6bbc170

…icting binary (#6708) Solves CI problems that #6707 and #6694 encountered. Refs: - #6694 (comment)

hyf0 force-pushed the 10-25-refactor_rename_bindingoutputchunk_asset_to_lazybindingoutputchunk_asset_ branch 2 times, most recently from 0110483 to 4730c9a Compare October 31, 2025 05:28

hyf0 added the graphite: merge label Oct 31, 2025

refactor: remove unnecessary #[napi(gettter)], use function call di…

cdfcbb4

…rectly (#6694)

graphite-app bot force-pushed the 10-25-refactor_rename_bindingoutputchunk_asset_to_lazybindingoutputchunk_asset_ branch from 4730c9a to cdfcbb4 Compare October 31, 2025 05:42

graphite-app bot merged commit cdfcbb4 into main Oct 31, 2025
27 checks passed

graphite-app bot deleted the 10-25-refactor_rename_bindingoutputchunk_asset_to_lazybindingoutputchunk_asset_ branch October 31, 2025 05:56

graphite-app bot removed the graphite: merge label Oct 31, 2025

github-actions bot mentioned this pull request Nov 3, 2025

release: v1.0.0-beta.46 #6818

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

refactor: remove unnecessary `#[napi(gettter)]`, use function call directly #6694

refactor: remove unnecessary `#[napi(gettter)]`, use function call directly #6694

Uh oh!

hyf0 commented Oct 25, 2025

Uh oh!

hyf0 commented Oct 25, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 25, 2025 •

edited

Loading

Uh oh!

hyf0 commented Oct 25, 2025 •

edited

Loading

Uh oh!

netlify bot commented Oct 25, 2025 •

edited

Loading

Uh oh!

hyf0 commented Oct 27, 2025

Uh oh!

hyf0 commented Oct 31, 2025 •

edited by graphite-app bot

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor: remove unnecessary #[napi(gettter)], use function call directly #6694

refactor: remove unnecessary #[napi(gettter)], use function call directly #6694

Uh oh!

Conversation

hyf0 commented Oct 25, 2025

Uh oh!

hyf0 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

How to use the Graphite Merge Queue

Uh oh!

github-actions bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks Rust

Uh oh!

hyf0 commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Oct 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rolldown-rs ready!

Uh oh!

hyf0 commented Oct 27, 2025

Uh oh!

hyf0 commented Oct 31, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

refactor: remove unnecessary `#[napi(gettter)]`, use function call directly #6694

refactor: remove unnecessary `#[napi(gettter)]`, use function call directly #6694

hyf0 commented Oct 25, 2025 •

edited

Loading

github-actions bot commented Oct 25, 2025 •

edited

Loading

hyf0 commented Oct 25, 2025 •

edited

Loading

netlify bot commented Oct 25, 2025 •

edited

Loading

hyf0 commented Oct 31, 2025 •

edited by graphite-app bot

Loading