Skip to content

Conversation

@sapphi-red
Copy link
Member

@sapphi-red sapphi-red commented Oct 21, 2025

Follow-up to #6615

It broke the output slightly.
image.png
(/ and | gzip: is not dimmed)
This PR fixes that.

Copy link
Member Author


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit ebc9d4c
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68f73c8c68a68e00087bd52b

@sapphi-red sapphi-red force-pushed the 10-21-fix_rolldown_plugin_reporter_color_dimmed_text_correctly branch from eb21b8b to ce660aa Compare October 21, 2025 05:34
@sapphi-red sapphi-red requested a review from shulaoda October 21, 2025 05:35
@sapphi-red sapphi-red self-assigned this Oct 21, 2025
@sapphi-red sapphi-red marked this pull request as ready for review October 21, 2025 05:35
@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

Benchmarks Rust

  • target: main(9807f18)
  • pr: 10-21-fix_rolldown_plugin_reporter_color_dimmed_text_correctly(ebc9d4c)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.07     73.5±3.17ms        ? ?/sec    1.00     69.0±1.96ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     76.1±2.71ms        ? ?/sec    1.00     75.9±2.21ms        ? ?/sec
bundle/bundle@rome_ts                                        1.01    110.2±2.89ms        ? ?/sec    1.00    109.6±1.77ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    122.3±1.79ms        ? ?/sec    1.02    124.2±2.32ms        ? ?/sec
bundle/bundle@threejs                                        1.04     42.0±2.78ms        ? ?/sec    1.00     40.4±0.68ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     44.8±1.67ms        ? ?/sec    1.00     44.4±1.03ms        ? ?/sec
bundle/bundle@threejs10x                                     1.01    404.5±6.38ms        ? ?/sec    1.00    402.1±5.13ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    463.3±5.15ms        ? ?/sec    1.00    461.6±4.97ms        ? ?/sec
scan/scan@rome_ts                                            1.00     87.2±2.08ms        ? ?/sec    1.01     87.9±5.20ms        ? ?/sec
scan/scan@threejs                                            1.02     29.8±1.89ms        ? ?/sec    1.00     29.2±0.42ms        ? ?/sec
scan/scan@threejs10x                                         1.01    303.1±4.49ms        ? ?/sec    1.00    301.2±3.95ms        ? ?/sec

@graphite-app
Copy link
Contributor

graphite-app bot commented Oct 21, 2025

Merge activity

  • Oct 21, 5:48 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Oct 21, 5:58 AM UTC: The Graphite merge queue couldn't merge this PR because it was not satisfying all requirements (Failed CI: 'node-test (ubuntu-latest) / Node Test', 'node-test (windows-latest) / Node Test').
  • Oct 21, 7:55 AM UTC: sapphi-red added this pull request to the Graphite merge queue.
  • Oct 21, 8:11 AM UTC: Merged by the Graphite merge queue.

graphite-app bot pushed a commit that referenced this pull request Oct 21, 2025
Follow-up to #6615

It broke the output slightly.
![image.png](https://app.graphite.dev/user-attachments/assets/c9226630-0cd2-404c-9de8-1f89b2f3e133.png)
(`/` and `| gzip:` is not dimmed)
This PR fixes that.
@graphite-app graphite-app bot force-pushed the 10-21-fix_rolldown_plugin_reporter_color_dimmed_text_correctly branch from ce660aa to 58e67f8 Compare October 21, 2025 05:49
Follow-up to #6615

It broke the output slightly.
![image.png](https://app.graphite.dev/user-attachments/assets/c9226630-0cd2-404c-9de8-1f89b2f3e133.png)
(`/` and `| gzip:` is not dimmed)
This PR fixes that.
@graphite-app graphite-app bot force-pushed the 10-21-fix_rolldown_plugin_reporter_color_dimmed_text_correctly branch from 58e67f8 to ebc9d4c Compare October 21, 2025 07:55
@graphite-app graphite-app bot merged commit ebc9d4c into main Oct 21, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 10-21-fix_rolldown_plugin_reporter_color_dimmed_text_correctly branch October 21, 2025 08:11
shulaoda added a commit that referenced this pull request Oct 27, 2025
## [1.0.0-beta.45] - 2025-10-27

### 🚀 Features

- plugin/vite-resolve: add `legacyInconsistentCjsInterop` option (#6687) by @sapphi-red
- rolldown_plugin_vite_css_post: initialize `CSSStyles` (#6691) by @shulaoda
- rolldown_plugin_manifest: align with `vitejs/vite#20585` (#6684) by @shulaoda
- enabling mangle private class members (#6679) by @IWANABETHATGUY
- rolldown_resolver: auto tsconfig discovery (#6602) by @Boshen
- support named imports + CJS by optimization.inlineConst (#6644) by @IWANABETHATGUY

### 🐛 Bug Fixes

- rolldown_binding: use Record instead of Map (#6715) by @shulaoda
- validate valibot schema against existing type (#6703) by @ocavue
- rolldown_plugin_vite_css_post: align some logic (#6697) by @shulaoda
- node/options: should validate `transform.jsx` correctly (#6698) by @ocavue
- inherit runtime helpers from eliminated dependencies (#6689) by @IWANABETHATGUY
- clean-dir: advance clean outdir to allow `generateBundle` outputs (#6647) by @aprosail
- rename variable to better reflect its purpose and fix CJS imports (#6663) by @IWANABETHATGUY
- bailout tree shake commonjs export when it is defined multiple time (#6659) by @IWANABETHATGUY
- rolldown_plugin_reporter: color dimmed text correctly (#6649) by @sapphi-red
- don't inline json module when used as a namespace reference (#6652) by @IWANABETHATGUY
- avoid `define` deprecation warning when loading a config file (#6641) by @sapphi-red

### 💼 Other

- pluginutils: switch to tsc to solve the issue of loading conflicting binary (#6708) by @hyf0

### 🚜 Refactor

- node: only call `transformToRollupOutput` when needed (#6695) by @hyf0
- node: split `transformToRollupOutput` into mutable and immutable versions (#6693) by @hyf0
- remove unnecessaey lazy data passing for `BindingOutputs` (#6692) by @hyf0
- rolldown_plugin_utils: tweak `CSSEntriesCache` (#6685) by @shulaoda
- rolldown_binding: use unified `BindingRenderBuiltUrl` (#6653) by @shulaoda

### 📚 Documentation

- in-depth about `experimental.nativeMagicString` (#6713) by @IWANABETHATGUY
- polish `optimization` (#6719) by @IWANABETHATGUY
- clarify `output.cleanDir` timing behavior for plugin compatibility (#6682) by @Copilot
- add Kevin Deng, 翠 (sapphi-red), and Alexander Lichter to team page with Bluesky links (#6664) by @Copilot
- polish `preserveEntrySignature` doc (#6661) by @IWANABETHATGUY
- set up redirects via netlify (#6654) by @TheAlexLichter
- polish doc about `treeshake` (#6650) by @IWANABETHATGUY
- rework options documentation first round (#6542) by @hyf0

### ⚡ Performance

- rolldown: upgrade sugar_path (#6646) by @Brooooooklyn

### 🧪 Testing

- add live bindings test for default export snapshot semantics (#6538) by @Copilot

### ⚙️ Miscellaneous Tasks

- deps: lock file maintenance npm packages (#6714) by @renovate[bot]
- deps: update github-actions (#6710) by @renovate[bot]
- deps: update dependency @vueuse/core to v14 (#6711) by @renovate[bot]
- deps: update github-actions (major) (#6712) by @renovate[bot]
- deps: update dependency tsdown to v0.15.10 (#6706) by @renovate[bot]
- remove `typedoc` dependency and cleanup unused documentation generation (#6686) by @Copilot
- deps: update dependency rolldown-plugin-dts to v0.17.1 (#6690) by @renovate[bot]
- lint: `oxlint --type-aware` (#5660) by @Boshen
- rolldown: update napi and js binding (#6676) by @Brooooooklyn
- deps: update vitest to v4 (#6673) by @sapphi-red
- test: support `DevTestMeta#dev` (#6672) by @hyf0
- deps: update dependency rolldown-plugin-dts to ^0.17.0 (#6671) by @renovate[bot]
- test: move dev related options to rolldown_dev_common (#6667) by @hyf0
- test: add `DevTestMeta` under `TestMeta#dev` to control dev related behaviors (#6666) by @hyf0
- deps: update dependency vite to v7.1.11 [security] (#6645) by @renovate[bot]
- pluginutils: use rolldown to build plugutils (#6642) by @Brooooooklyn
- deps: update dependency tsdown to v0.15.9 (#6643) by @renovate[bot]

### ❤️ New Contributors

* @ocavue made their first contribution in [#6703](#6703)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants