Skip to content

Conversation

@hyf0
Copy link
Member

@hyf0 hyf0 commented Oct 16, 2025

The test is not passed. Just need to add the test first.

Copy link
Member Author

hyf0 commented Oct 16, 2025


How to use the Graphite Merge Queue

Add the label graphite: merge to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@hyf0 hyf0 marked this pull request as ready for review October 16, 2025 05:29
@hyf0 hyf0 marked this pull request as draft October 16, 2025 05:29
@graphite-app graphite-app bot changed the base branch from 10-16-refactor_rust_dev_use_client_id_to_check_if_module_is_executed_for_test_environment to graphite-base/6567 October 16, 2025 06:22
@graphite-app graphite-app bot force-pushed the 10-16-fix_rust_dev_should_handle_initial_build_error_correctly branch from 9ab0089 to 993f2ca Compare October 16, 2025 06:36
@graphite-app graphite-app bot force-pushed the graphite-base/6567 branch from ac98283 to 5986358 Compare October 16, 2025 06:36
@graphite-app graphite-app bot changed the base branch from graphite-base/6567 to main October 16, 2025 06:37
@graphite-app graphite-app bot force-pushed the 10-16-fix_rust_dev_should_handle_initial_build_error_correctly branch from 993f2ca to 1a73657 Compare October 16, 2025 06:37
@netlify
Copy link

netlify bot commented Oct 16, 2025

Deploy Preview for rolldown-rs canceled.

Name Link
🔨 Latest commit 1a73657
🔍 Latest deploy log https://app.netlify.com/projects/rolldown-rs/deploys/68f092ae097551000862a4fc

graphite-app bot pushed a commit that referenced this pull request Oct 17, 2025
- `build_artifacts_snapshot.rs`​clearly shows how it renders the snapshot
- I didn't put much attention on `dev_artifacts_snapshot.rs `​, becuase it needs be refactored to satisfy more scenarios (#6567) later.
- Another reason for splitting the logic is that `dev`​ test gonna more complex logic than normal build. I feel the disadvantages it brings are beyond advatanges for unifying them.
graphite-app bot pushed a commit that referenced this pull request Oct 17, 2025
- `build_artifacts_snapshot.rs`​clearly shows how it renders the snapshot
- I didn't put much attention on `dev_artifacts_snapshot.rs `​, becuase it needs be refactored to satisfy more scenarios (#6567) later.
- Another reason for splitting the logic is that `dev`​ test gonna more complex logic than normal build. I feel the disadvantages it brings are beyond advatanges for unifying them.
@hyf0 hyf0 changed the base branch from main to graphite-base/6567 October 28, 2025 15:26
@hyf0 hyf0 force-pushed the 10-16-fix_rust_dev_should_handle_initial_build_error_correctly branch from 1a73657 to c948295 Compare October 28, 2025 15:26
@hyf0 hyf0 changed the base branch from graphite-base/6567 to 10-28-chore_test_dev_collect_multiple_build_outputs_for_each_step October 28, 2025 15:27
@hyf0 hyf0 marked this pull request as ready for review October 28, 2025 15:27
@hyf0 hyf0 changed the title fix(rust/dev): should handle initial build error correctly test(rust/dev): add test about recover from initial build error Oct 28, 2025
@hyf0 hyf0 requested review from sapphi-red and shulaoda October 28, 2025 15:29
@hyf0 hyf0 force-pushed the 10-16-fix_rust_dev_should_handle_initial_build_error_correctly branch 2 times, most recently from f10e4e0 to a78e1f8 Compare October 28, 2025 15:40
@github-actions
Copy link
Contributor

github-actions bot commented Oct 28, 2025

Benchmarks Rust

  • target: 10-28-chore_test_dev_collect_multiple_build_outputs_for_each_step(ecd9546)
  • pr: 10-16-fix_rust_dev_should_handle_initial_build_error_correctly(ec0fc08)
group                                                        pr                                     target
-----                                                        --                                     ------
bundle/bundle@multi-duplicated-top-level-symbol              1.00     65.8±2.26ms        ? ?/sec    1.09     72.1±3.87ms        ? ?/sec
bundle/bundle@multi-duplicated-top-level-symbol-sourcemap    1.00     72.2±1.74ms        ? ?/sec    1.07     77.3±3.90ms        ? ?/sec
bundle/bundle@rome_ts                                        1.00    109.6±2.87ms        ? ?/sec    1.02    112.0±2.54ms        ? ?/sec
bundle/bundle@rome_ts-sourcemap                              1.00    122.9±2.30ms        ? ?/sec    1.01    124.4±2.97ms        ? ?/sec
bundle/bundle@threejs                                        1.00     39.5±1.02ms        ? ?/sec    1.04     41.1±2.60ms        ? ?/sec
bundle/bundle@threejs-sourcemap                              1.01     44.2±1.06ms        ? ?/sec    1.00     43.9±1.21ms        ? ?/sec
bundle/bundle@threejs10x                                     1.00    401.9±8.16ms        ? ?/sec    1.01   407.1±10.69ms        ? ?/sec
bundle/bundle@threejs10x-sourcemap                           1.00    461.5±7.69ms        ? ?/sec    1.00    461.4±6.69ms        ? ?/sec
scan/scan@rome_ts                                            1.00     86.2±1.59ms        ? ?/sec    1.01     86.8±1.87ms        ? ?/sec
scan/scan@threejs                                            1.00     29.1±0.52ms        ? ?/sec    1.03     29.9±2.13ms        ? ?/sec
scan/scan@threejs10x                                         1.01    306.0±5.97ms        ? ?/sec    1.00    304.4±4.67ms        ? ?/sec

Copy link
Member Author

hyf0 commented Oct 28, 2025

Merge activity

The test is not passed. Just need to add the test first.
graphite-app bot pushed a commit that referenced this pull request Oct 28, 2025
- For #6567, `dev`​ mode need to test all possible situations, so we try collect all output from each step.
- `DevTestMeta#ensureLatestBuildOutputForEachStep`​ is also supported for testing related situations.
@graphite-app graphite-app bot force-pushed the 10-28-chore_test_dev_collect_multiple_build_outputs_for_each_step branch from 0c15738 to ecd9546 Compare October 28, 2025 16:20
@graphite-app graphite-app bot force-pushed the 10-16-fix_rust_dev_should_handle_initial_build_error_correctly branch from a78e1f8 to ec0fc08 Compare October 28, 2025 16:20
Base automatically changed from 10-28-chore_test_dev_collect_multiple_build_outputs_for_each_step to main October 28, 2025 16:36
@graphite-app graphite-app bot merged commit ec0fc08 into main Oct 28, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 10-16-fix_rust_dev_should_handle_initial_build_error_correctly branch October 28, 2025 16:36
@github-actions github-actions bot mentioned this pull request Nov 3, 2025
shulaoda added a commit that referenced this pull request Nov 3, 2025
## [1.0.0-beta.46] - 2025-11-03

### 💥 BREAKING CHANGES

- default `preserveEntrySignatures` to `'exports-only'` to align with
Rollup (#6723) by @Copilot

### 🚀 Features

- link to docs for commonjs prefer_builtin_feature diagnostic (#6793) by
@sapphi-red
- rolldown_plugin_build_import_analysis: align partial logic (#6789) by
@shulaoda
- improve `EVAL` warning message (#6776) by @sapphi-red
- rolldown: oxc v0.96.0 (#6774) by @Boshen
- rolldown_plugin_build_import_analysis: align partial logic (#6773) by
@shulaoda
- skip `__toESM` when not needed to reduce output size (#6751) by
@Copilot
- improve `EMPTY_IMPORT_META` warning message (#6761) by @sapphi-red
- rolldown_plugin_build_import_analysis: align no preload logic (#6762)
by @shulaoda
- rolldown_plugin_vite_css_post: align `RemovedPureCSSFilesCache` logic
(#6745) by @shulaoda
- rolldown_plugin_build_import_analysis: initialize `generateBundle`
logic (#6744) by @shulaoda
- experimental: introduce `freeExternalMemory` to free external memory
immediately (#6721) by @hyf0

### 🐛 Bug Fixes

- plugins: wrap replacePlugin with makeBuiltinPluginCallable (#6782) by
@huang-julien
- debug: make sure `this.resolve` is also tracked under corresponding
session (#6798) by @hyf0
- legal comments above directives are not preserved (#6787) by @shulaoda
- panic when rendering exports to other chunks (#6765) by @Copilot
- transform/inject: escape special characters in import source (#6778)
by @Copilot
- handle default exports from CJS modules correctly (#6767) by
@IWANABETHATGUY
- rolldown_plugin_build_import_analysis: correct aligned logic (#6768)
by @shulaoda
- duplicate default export when using both import and require (#6764) by
@Copilot
- handle arbitrary module namespace identifiers in
`preserveEntrySignatures: 'allow-extension'` (#6753) by @Copilot
- TypeError when loading CJS files after bundling mixed CJS+TS project
(#6743) by @IWANABETHATGUY
- add warnings for import.meta.dirname/filename/url in UMD and IIFE
formats (#6747) by @Copilot
- rolldown_plugin_manifest: should keep `names` field (#6742) by
@shulaoda
- legal comments above import statements are not preserved (#6717) by
@shulaoda
- remove redundant node check in dynamic entry graph construction
(#6730) by @IWANABETHATGUY

### 🚜 Refactor

- remove unnecessary `#[napi(gettter)]`, use function call directly
(#6694) by @hyf0
- explain the reason if memory doesn't get dropped by
`freeExternalMemory` (#6781) by @hyf0
- pre compute exports (#6755) by @IWANABETHATGUY
- dev: receive an interface for DevRuntime rather than WebSocket
directly (#6734) by @sapphi-red
- dev: fix types for the runtime file and expose it properly (#6731) by
@sapphi-red

### 📚 Documentation

- fix magicstring credit (#6812) by @TheAlexLichter
- in-depth/bundling-cjs: wrap some sections with caveats section (#6796)
by @sapphi-red
- in-depth/bundling-cjs: add "Ambiguous `default` import from CJS
modules" section (#6795) by @sapphi-red
- in-depth/bundling-cjs: make `esmExternalRequirePlugin` link more
prominent (#6792) by @sapphi-red
- add explanation about direct eval (#6775) by @sapphi-red
- add "Non-ESM Output Formats" page (#6760) by @sapphi-red
- use oxc for benchmark comparison in native magic string doc (#6740) by
@sapphi-red
- polish `cleanDir` option (#6741) by @hyf0
- fix image in native magic string doc (#6739) by @sapphi-red
- update description about `attachDebugInfo: 'none'` (#6738) by
@IWANABETHATGUY
- add warning about cleanDir behavior with multiple configs (#6735) by
@Copilot

### 🧪 Testing

- skip paths function test (#6771) by @IWANABETHATGUY
- rust/dev: add test about recover from initial build error (#6567) by
@hyf0

### ⚙️ Miscellaneous Tasks

- correct prepare release binding file (#6817) by @shulaoda
- deps: update github-actions (#6806) by @renovate[bot]
- deps: lock file maintenance npm packages (#6814) by @renovate[bot]
- use correct node version (#6809) by @shulaoda
- deps: lock file maintenance rust crates (#6815) by @renovate[bot]
- deps: update npm packages (major) (#6813) by @renovate[bot]
- deps: update dependency dprint-typescript to v0.95.12 (#6805) by
@renovate[bot]
- fix typo (#6801) by @iiio2
- fix typo in is_import_expr_ignored_by_comment method name (#6797) by
@sapphi-red
- deps: update crate-ci/typos action to v1.39.0 (#6794) by
@renovate[bot]
- deps: upgrade Rust to v1.91.0 and fix new clippy lints (#6785) by
@Copilot
- allow dprint to format `packages/rolldown/tests` except diagnostics
directory (#6772) by @Copilot
- deps: update dependency tsdown to v0.15.12 (#6759) by @renovate[bot]
- deps: update dependency rolldown-plugin-dts to v0.17.3 (#6758) by
@renovate[bot]
- test/dev: collect multiple build outputs for each step (#6736) by
@hyf0
- rolldown: change the NAPI-RS binding file to the cjs (#6688) by
@Brooooooklyn
- test: automatically run extra test with `preserve_entry_signatures:
'allow-extension'` (#6727) by @Copilot
- deps: update dependency rolldown-plugin-dts to v0.17.2 (#6732) by
@renovate[bot]
- fix node validation (#6728) by @shulaoda
- deps: lock file maintenance rust crates (#6636) by @renovate[bot]
- deps: update dependency tsdown to v0.15.11 (#6725) by @renovate[bot]

### ❤️ New Contributors

* @huang-julien made their first contribution in
[#6782](#6782)

Co-authored-by: shulaoda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants