Skip to content

Conversation

@generall
Copy link
Member

Apparently, some users don't expect this method to delete existing collection.

Adds deprecation warning as a preparation for further removal.

@netlify
Copy link

netlify bot commented Apr 16, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 3a7ec51
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/661fd81e5e8e310007de6df6
😎 Deploy Preview https://deploy-preview-601--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@generall
Copy link
Member Author

@joein there is some problem with formatting.

the tool which generates async client, pre-commit hook, and CI - all three have a unique opinion on how to format the code.

@joein joein self-requested a review April 17, 2024 15:38
@generall generall mentioned this pull request Apr 18, 2024
@generall generall merged commit 0ccac25 into dev Apr 18, 2024
joein added a commit that referenced this pull request Apr 22, 2024
* add deprecation warning

* async client

* fmt

* fix: replace logging.warning with warnings.warn

* refactoring: update warning

---------

Co-authored-by: George Panchuk <[email protected]>
@generall generall deleted the deprecate-recreate-collection branch May 3, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants