new: add sparse vectors support in discovery and recommend in local mode #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
agourlay
reviewed
Apr 4, 2024
tests/fixtures/points.py
Outdated
|
|
||
| def random_sparse_vectors( | ||
| vector_sizes: Union[Dict[str, int], int], | ||
| vector_sizes: Union[Dict[str, int]], |
Member
There was a problem hiding this comment.
can we remove the Union completely then?
agourlay
approved these changes
Apr 4, 2024
Member
agourlay
left a comment
agourlay
left a comment
There was a problem hiding this comment.
The test coverage looks excellent!
I did not review in details the scoring implementation but I am confident due to the congruence tests 👍
This was referenced Apr 4, 2024
Closed
This was
linked to
issues
Apr 4, 2024
coszio
approved these changes
Apr 5, 2024
Contributor
coszio
left a comment
coszio
left a comment
There was a problem hiding this comment.
Lots of work in a single PR, but still easy to go through. Nothing to complain aside from some nits
qdrant_client/local/distances.py
Outdated
| class DistanceOrder(str, Enum): | ||
| BIGGER_IS_BETTER = "bigger_is_better" | ||
| SMALLER_IS_BETTER = "smaller_is_better" | ||
| QueryVector = Union[ |
Contributor
There was a problem hiding this comment.
Only a suggestion, I'll leave it to your criteria
Suggested change
| QueryVector = Union[ | |
| DenseQueryVector = Union[ |
| List[models.SparseVector], | ||
| types.Filter, | ||
| ]: | ||
| def split_examples( |
Contributor
There was a problem hiding this comment.
I had to read a few times to understand what this was doing, maybe:
Suggested change
| def split_examples( | |
| def examples_into_vectors( |
?
Comment on lines
+795
to
+798
| else: | ||
| query_vector = SparseRecoQuery( | ||
| positive=sparse_positive_vectors, negative=sparse_negative_vectors | ||
| ) |
Contributor
There was a problem hiding this comment.
what if there are no sparse_positive_vectors nor sparse_negative_vectors either?
Edit: it is already checked in
Member
Author
|
tests are failing now due to #580 |
Co-authored-by: Luis Cossío <[email protected]>
Co-authored-by: Luis Cossío <[email protected]>
joein
force-pushed
the
add-sparse-recommendation-and-discovery-local
branch
from
a4f5892 to
50d7b6e
Compare
skvark
pushed a commit
to skvark/qdrant-client
that referenced
this pull request
Apr 8, 2024
…ode (qdrant#571) * new: add sparse vectors support in discovery and recommend in local mode * chore: remove redundant file * chore: remove another redundant file * fix: fix type hint for python3.8 * fix: remove redundant types from check * refactoring: remove redundant union * refactoring: remove redundant import * fix: fix type hint * fix: fix type hint * refactoring: improve exception description Co-authored-by: Luis Cossío <[email protected]> * refactoring: improve exception description Co-authored-by: Luis Cossío <[email protected]> * refactoring: address review comments --------- Co-authored-by: Luis Cossío <[email protected]>
joein
added a commit
that referenced
this pull request
Apr 22, 2024
…ode (#571) * new: add sparse vectors support in discovery and recommend in local mode * chore: remove redundant file * chore: remove another redundant file * fix: fix type hint for python3.8 * fix: remove redundant types from check * refactoring: remove redundant union * refactoring: remove redundant import * fix: fix type hint * fix: fix type hint * refactoring: improve exception description Co-authored-by: Luis Cossío <[email protected]> * refactoring: improve exception description Co-authored-by: Luis Cossío <[email protected]> * refactoring: address review comments --------- Co-authored-by: Luis Cossío <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more than a half of the PR are tests 🙈