fix: fix QueryVector isinstance check in local mode #562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
coszio
approved these changes
Apr 2, 2024
Contributor
coszio
left a comment
coszio
left a comment
There was a problem hiding this comment.
get_args or get_args_subscribed in this scenario. But ok ✅
joein
force-pushed
the
fix-query-vector-check-local
branch
from
eb9e52c to
a62bffa
Compare
joein
added a commit
that referenced
this pull request
Apr 22, 2024
* fix: fix QueryVector isinstance check in local mode * fix: update query vector type, fix invalid vector type in search in local mode * fix: remove get_args_subscribed type hint, restore QueryVector, remove redundant array check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if we pass unexpected type to search, check
isinstance(query_vector, QueryVector)fails when it gets to numpy arrays