Skip to content

Conversation

@joein
Copy link
Member

@joein joein commented Apr 1, 2024

@netlify
Copy link

netlify bot commented Apr 1, 2024

Deploy Preview for poetic-froyo-8baba7 ready!

Name Link
🔨 Latest commit 5c53cf5
🔍 Latest deploy log https://app.netlify.com/sites/poetic-froyo-8baba7/deploys/660c13159f8227000851e957
😎 Deploy Preview https://deploy-preview-560--poetic-froyo-8baba7.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@joein joein force-pushed the check-nan-vectors-local-mode branch from bdfa8b7 to 5c53cf5 Compare April 2, 2024 14:15
@joein joein requested a review from coszio April 2, 2024 14:24
Copy link
Contributor

@coszio coszio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joein joein merged commit af2f2e9 into dev Apr 2, 2024
joein added a commit that referenced this pull request Apr 22, 2024
* new: check for nan vectors in local mode

* tests: add tests for search with query containing nans

* refactoring: move sparse nan test to test_sparse_search

* tests: add tests for queries with nans in recommendation api

* tests: add tests for query with nan in discovery

* refactoring: update imports in discovery tests
@generall generall deleted the check-nan-vectors-local-mode branch May 3, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants