Break out of retry loop upon successful upsert #531
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for poetic-froyo-8baba7 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Mar 11, 2024
joein
approved these changes
Mar 11, 2024
Member
|
Hey @almostimplemented, thanks a lot for fixing! 🙏 |
|
It was a bit worrisome to see so many outgoing calls to qdrant server in the logs. I am really glad to find that it has been fixed and merged. @joein When could we expect this fix to be released? |
Member
|
@amitshukla-evs hopefully this week |
joein
pushed a commit
that referenced
this pull request
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
devbranch. Did you create your branch fromdev?Discussion:
The current retry logic in the uploader code invokes the upsert operation
max_retriestimes, regardless of whether the request succeeds or fails. Then, an exception is raised if the last of the attempts fails. The code should insteadbreakupon a successful request andreturn True.