Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken PyYAML 6.0 on MacOS x86 #116551

Merged
merged 1 commit into from
Dec 30, 2023
Merged

Fix broken PyYAML 6.0 on MacOS x86 #116551

merged 1 commit into from
Dec 30, 2023

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Dec 30, 2023

May be we should just get rid of x86 jobs, but that's for another day. This one should fix the broken build in trunk, i.e. https://github.com/pytorch/pytorch/actions/runs/7227220153/job/19694420117.

I guess that the failure looks flaky depending on the version of default python3 on the GitHub x86 runner.

The issue from PyYAML yaml/pyyaml#601
Cherry-pick of #115956 into release/2.2

(cherry picked from commit 94d2816)

May be we should just get rid of x86 jobs, but that's for another day.  This one should fix the broken build in trunk, i.e. https://github.com/pytorch/pytorch/actions/runs/7227220153/job/19694420117.

I guess that the failure looks flaky depending on the version of default python3 on the GitHub x86 runner.

The issue from PyYAML yaml/pyyaml#601
Pull Request resolved: #115956
Approved by: https://github.com/malfet

(cherry picked from commit 94d2816)
@malfet malfet requested a review from a team as a code owner December 30, 2023 01:23
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Dec 30, 2023
Copy link

pytorch-bot bot commented Dec 30, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116551

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit aca55ee with merge base a8bd593 (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@malfet malfet changed the title Fix broken PyYAML 6.0 on MacOS x86 (#115956) Fix broken PyYAML 6.0 on MacOS x86 Dec 30, 2023
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for preparing the cherry pick! I was looking at the failure on release branch and it all looks familiar :)

@huydhn huydhn added the ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR label Dec 30, 2023
@huydhn huydhn merged commit ab7505f into release/2.2 Dec 30, 2023
@malfet malfet deleted the malfet/cp-115956 branch January 20, 2024 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/periodic Trigger jobs ran periodically on master (periodic.yml) on the PR topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants