Drop runtime error in PEP 705 implementation #333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srittau
approved these changes
Feb 14, 2024
alicederyn
reviewed
Feb 14, 2024
| @@ -1,5 +1,8 @@ | |||
| # Unreleased | |||
|
|
|||
| - Drop runtime error when a mutable `TypedDict` key overrides a read-only | |||
Contributor
There was a problem hiding this comment.
This comment is back to front I think @JelleZijlstra ? May be confusing
Member
Author
There was a problem hiding this comment.
You're right, thanks
alicederyn
reviewed
Feb 14, 2024
| else: | ||
| optional_keys.add(annotation_key) | ||
| if ReadOnly in qualifiers: | ||
| if annotation_key in mutable_keys: |
Contributor
There was a problem hiding this comment.
Did you not want to replace this with a mutable_keys.discard? I think that would be symmetric with how this code handles other "illegal" overrides, e.g. with Required.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://discuss.python.org/t/pep-705-read-only-typeddict-items/37867/10
cc @alicederyn